[INFO] updating cached repository maidsafe/datachains_sim
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/maidsafe/datachains_sim
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/maidsafe/datachains_sim" "work/ex/clippy-test-run/sources/stable/gh/maidsafe/datachains_sim"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maidsafe/datachains_sim'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/maidsafe/datachains_sim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maidsafe/datachains_sim"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maidsafe/datachains_sim'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5b67cffb4ca40b0639c6f43f38556502123a28ec
[INFO] sha for GitHub repo maidsafe/datachains_sim: 5b67cffb4ca40b0639c6f43f38556502123a28ec
[INFO] validating manifest of maidsafe/datachains_sim on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of maidsafe/datachains_sim on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing maidsafe/datachains_sim
[INFO] finished frobbing maidsafe/datachains_sim
[INFO] frobbed toml for maidsafe/datachains_sim written to work/ex/clippy-test-run/sources/stable/gh/maidsafe/datachains_sim/Cargo.toml
[INFO] started frobbing maidsafe/datachains_sim
[INFO] finished frobbing maidsafe/datachains_sim
[INFO] frobbed toml for maidsafe/datachains_sim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maidsafe/datachains_sim/Cargo.toml
[INFO] crate maidsafe/datachains_sim has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting maidsafe/datachains_sim against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maidsafe/datachains_sim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 678a83569ac293d2dbd60919e9e4ee6a34a5ebf4f18b3a0bc6591ba0936f85c5
[INFO] running `"docker" "start" "-a" "678a83569ac293d2dbd60919e9e4ee6a34a5ebf4f18b3a0bc6591ba0936f85c5"`
[INFO] [stderr]     Checking tiny-keccak v1.4.0
[INFO] [stderr]     Checking ctrlc v3.1.0
[INFO] [stderr]     Checking clap v2.29.2
[INFO] [stderr]     Checking datachains_sim v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/stats.rs:233:17
[INFO] [stderr]     |
[INFO] [stderr] 233 | /                 write!(
[INFO] [stderr] 234 | |                 file,
[INFO] [stderr] 235 | |                 "{} {} {} {} {} {} {}\n",
[INFO] [stderr] 236 | |                 sample.iteration,
[INFO] [stderr] ...   |
[INFO] [stderr] 242 | |                 sample.rejections,
[INFO] [stderr] 243 | |             );
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/stats.rs:233:17
[INFO] [stderr]     |
[INFO] [stderr] 233 | /                 write!(
[INFO] [stderr] 234 | |                 file,
[INFO] [stderr] 235 | |                 "{} {} {} {} {} {} {}\n",
[INFO] [stderr] 236 | |                 sample.iteration,
[INFO] [stderr] ...   |
[INFO] [stderr] 242 | |                 sample.rejections,
[INFO] [stderr] 243 | |             );
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/stats.rs:194:48
[INFO] [stderr]     |
[INFO] [stderr] 194 |     #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/stats.rs:194:48
[INFO] [stderr]     |
[INFO] [stderr] 194 |     #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/stats.rs:194:48
[INFO] [stderr]     |
[INFO] [stderr] 194 |     #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/stats.rs:194:48
[INFO] [stderr]     |
[INFO] [stderr] 194 |     #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments`
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/log.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub fn name(name: &Name) -> ColoredString {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `Name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/stats.rs:229:32
[INFO] [stderr]     |
[INFO] [stderr] 229 |             File::create(path).expect(&format!("Couldn't create file {}!", path.display()));
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't create file {}!", path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/log.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub fn name(name: &Name) -> ColoredString {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `Name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/stats.rs:229:32
[INFO] [stderr]     |
[INFO] [stderr] 229 |             File::create(path).expect(&format!("Couldn't create file {}!", path.display()));
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't create file {}!", path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.04s
[INFO] running `"docker" "inspect" "678a83569ac293d2dbd60919e9e4ee6a34a5ebf4f18b3a0bc6591ba0936f85c5"`
[INFO] running `"docker" "rm" "-f" "678a83569ac293d2dbd60919e9e4ee6a34a5ebf4f18b3a0bc6591ba0936f85c5"`
[INFO] [stdout] 678a83569ac293d2dbd60919e9e4ee6a34a5ebf4f18b3a0bc6591ba0936f85c5