[INFO] updating cached repository mahepe/rssget [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mahepe/rssget [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mahepe/rssget" "work/ex/clippy-test-run/sources/stable/gh/mahepe/rssget"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mahepe/rssget'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mahepe/rssget" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahepe/rssget"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahepe/rssget'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a9ea0d988997311307a025e42d81d86a676a52f [INFO] sha for GitHub repo mahepe/rssget: 7a9ea0d988997311307a025e42d81d86a676a52f [INFO] validating manifest of mahepe/rssget on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mahepe/rssget on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mahepe/rssget [INFO] finished frobbing mahepe/rssget [INFO] frobbed toml for mahepe/rssget written to work/ex/clippy-test-run/sources/stable/gh/mahepe/rssget/Cargo.toml [INFO] started frobbing mahepe/rssget [INFO] finished frobbing mahepe/rssget [INFO] frobbed toml for mahepe/rssget written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mahepe/rssget/Cargo.toml [INFO] crate mahepe/rssget has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mahepe/rssget against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mahepe/rssget:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2844b5fff5f81409b5df69c5a8efc39874002d21dff7a1a49b389724e10c7ea5 [INFO] running `"docker" "start" "-a" "2844b5fff5f81409b5df69c5a8efc39874002d21dff7a1a49b389724e10c7ea5"` [INFO] [stderr] Compiling openssl v0.10.13 [INFO] [stderr] Compiling openssl-sys v0.9.37 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking rssget v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fetch.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return tmp; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | return re.is_match(url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `re.is_match(url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | return Err(format!("alias {} not found", feed_alias).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("alias {} not found", feed_alias).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fetch.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return tmp; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | return re.is_match(url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `re.is_match(url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | return Err(format!("alias {} not found", feed_alias).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("alias {} not found", feed_alias).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/fetch.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / let mut fetch_url = url.to_string(); [INFO] [stderr] 23 | | if !utils::is_url(&url.to_string()) { [INFO] [stderr] 24 | | fetch_url = utils::alias_to_url(&url.to_string(), &alias_fname)?; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let fetch_url = if !utils::is_url(&url.to_string()) { utils::alias_to_url(&url.to_string(), &alias_fname)? } else { url.to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/read.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | let regexes: Vec = attrs [INFO] [stderr] | _______________________________^ [INFO] [stderr] 19 | | .iter() [INFO] [stderr] 20 | | .into_iter() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 18 | let regexes: Vec = attrs [INFO] [stderr] 19 | .iter() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if url.len() > 0 && !utils::is_url(&feed_url) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | if url.len() > 0 && !utils::hashes_equal(utils::hash(&feed_url), header.feed_hash) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hash(input: &String) -> [u8; HASH_BYTES] { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | item: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | url: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn count_items(aux_fname: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | aux_fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:133:10 [INFO] [stderr] | [INFO] [stderr] 133 | url: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | regexes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:166:15 [INFO] [stderr] | [INFO] [stderr] 166 | item_txt: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | regexes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn is_url(url: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | feed_alias: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | alias_fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/fetch.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / let mut fetch_url = url.to_string(); [INFO] [stderr] 23 | | if !utils::is_url(&url.to_string()) { [INFO] [stderr] 24 | | fetch_url = utils::alias_to_url(&url.to_string(), &alias_fname)?; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let fetch_url = if !utils::is_url(&url.to_string()) { utils::alias_to_url(&url.to_string(), &alias_fname)? } else { url.to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/read.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | let regexes: Vec = attrs [INFO] [stderr] | _______________________________^ [INFO] [stderr] 19 | | .iter() [INFO] [stderr] 20 | | .into_iter() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 18 | let regexes: Vec = attrs [INFO] [stderr] 19 | .iter() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if url.len() > 0 && !utils::is_url(&feed_url) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | if url.len() > 0 && !utils::hashes_equal(utils::hash(&feed_url), header.feed_hash) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn hash(input: &String) -> [u8; HASH_BYTES] { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | item: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | url: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn count_items(aux_fname: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | aux_fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:133:10 [INFO] [stderr] | [INFO] [stderr] 133 | url: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | regexes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:166:15 [INFO] [stderr] | [INFO] [stderr] 166 | item_txt: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | regexes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn is_url(url: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | feed_alias: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | alias_fname: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.58s [INFO] running `"docker" "inspect" "2844b5fff5f81409b5df69c5a8efc39874002d21dff7a1a49b389724e10c7ea5"` [INFO] running `"docker" "rm" "-f" "2844b5fff5f81409b5df69c5a8efc39874002d21dff7a1a49b389724e10c7ea5"` [INFO] [stdout] 2844b5fff5f81409b5df69c5a8efc39874002d21dff7a1a49b389724e10c7ea5