[INFO] updating cached repository maeln/r_astar
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/maeln/r_astar
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/maeln/r_astar" "work/ex/clippy-test-run/sources/stable/gh/maeln/r_astar"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maeln/r_astar'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/maeln/r_astar" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maeln/r_astar"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maeln/r_astar'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] da1978594239365e21dc4512b537920660928c96
[INFO] sha for GitHub repo maeln/r_astar: da1978594239365e21dc4512b537920660928c96
[INFO] validating manifest of maeln/r_astar on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of maeln/r_astar on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing maeln/r_astar
[INFO] finished frobbing maeln/r_astar
[INFO] frobbed toml for maeln/r_astar written to work/ex/clippy-test-run/sources/stable/gh/maeln/r_astar/Cargo.toml
[INFO] started frobbing maeln/r_astar
[INFO] finished frobbing maeln/r_astar
[INFO] frobbed toml for maeln/r_astar written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maeln/r_astar/Cargo.toml
[INFO] crate maeln/r_astar has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting maeln/r_astar against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maeln/r_astar:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5c124e7462212723c1b06a29715708082decca27838f7263362617f703236ad8
[INFO] running `"docker" "start" "-a" "5c124e7462212723c1b06a29715708082decca27838f7263362617f703236ad8"`
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking astar v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maze.rs:39:11
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Point { x: x, y: y }
[INFO] [stderr]    |                 ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maze.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Point { x: x, y: y }
[INFO] [stderr]    |                       ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:101:4
[INFO] [stderr]     |
[INFO] [stderr] 101 |             map: map,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `map`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:102:4
[INFO] [stderr]     |
[INFO] [stderr] 102 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:103:4
[INFO] [stderr]     |
[INFO] [stderr] 103 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:104:4
[INFO] [stderr]     |
[INFO] [stderr] 104 |             trace: trace,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `trace`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]   --> src/maze.rs:39:11
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Point { x: x, y: y }
[INFO] [stderr]    |                 ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/maze.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Point { x: x, y: y }
[INFO] [stderr]    |                       ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:101:4
[INFO] [stderr]     |
[INFO] [stderr] 101 |             map: map,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `map`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:102:4
[INFO] [stderr]     |
[INFO] [stderr] 102 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:103:4
[INFO] [stderr]     |
[INFO] [stderr] 103 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maze.rs:104:4
[INFO] [stderr]     |
[INFO] [stderr] 104 |             trace: trace,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `trace`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/maze.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn opposite(&self) -> Dir {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/maze.rs:22:3
[INFO] [stderr]    |
[INFO] [stderr] 22 |           match self {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 23 | |             &Dir::N => Dir::S,
[INFO] [stderr] 24 | |             &Dir::S => Dir::N,
[INFO] [stderr] 25 | |             &Dir::E => Dir::W,
[INFO] [stderr] 26 | |             &Dir::W => Dir::E,
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         match *self {
[INFO] [stderr] 23 |             Dir::N => Dir::S,
[INFO] [stderr] 24 |             Dir::S => Dir::N,
[INFO] [stderr] 25 |             Dir::E => Dir::W,
[INFO] [stderr] 26 |             Dir::W => Dir::E,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/maze.rs:43:17
[INFO] [stderr]    |
[INFO] [stderr] 43 | #[derive(Debug, Hash, Eq, Clone)]
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/maze.rs:64:1
[INFO] [stderr]    |
[INFO] [stderr] 64 | / impl PartialEq for Cell {
[INFO] [stderr] 65 | |     fn eq(&self, other: &Cell) -> bool {
[INFO] [stderr] 66 | |         self.filled == other.filled
[INFO] [stderr] 67 | |             && self.walls.contains(&Dir::N) == other.walls.contains(&Dir::N)
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |     }
[INFO] [stderr] 72 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `map`.
[INFO] [stderr]   --> src/maze.rs:94:12
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for x in 0..width {
[INFO] [stderr]    |                  ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for <item> in map.iter_mut().take(width) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/maze.rs:187:63
[INFO] [stderr]     |
[INFO] [stderr] 187 |     pub fn to_svg_file(&self, path: &str, current: Point, astar: &Vec<Point>) {
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/maze.rs:198:46
[INFO] [stderr]     |
[INFO] [stderr] 198 |     pub fn to_svg(&self, current: Point, astar: &Vec<Point>) -> String {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/maze.rs:243:38
[INFO] [stderr]     |
[INFO] [stderr] 243 |     fn draw_wall(x: usize, y: usize, d: &Dir) -> String {
[INFO] [stderr]     |                                         ^^^^ help: consider passing by value instead: `Dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/maze.rs:244:3
[INFO] [stderr]     |
[INFO] [stderr] 244 |           match d {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 245 | |             &Dir::N => format!(
[INFO] [stderr] 246 | |                 "<line x1='{}' y1='{}' x2='{}' y2='{}'/>",
[INFO] [stderr] 247 | |                 x * SIZE,
[INFO] [stderr] ...   |
[INFO] [stderr] 272 | |             ),
[INFO] [stderr] 273 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 244 |         match *d {
[INFO] [stderr] 245 |             Dir::N => format!(
[INFO] [stderr] 246 |                 "<line x1='{}' y1='{}' x2='{}' y2='{}'/>",
[INFO] [stderr] 247 |                 x * SIZE,
[INFO] [stderr] 248 |                 y * SIZE,
[INFO] [stderr] 249 |                 x * SIZE + WALL_SIZE,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/maze.rs:276:21
[INFO] [stderr]     |
[INFO] [stderr] 276 |     fn draw_path(path: &Vec<Point>) -> String {
[INFO] [stderr]     |                        ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/maze.rs:277:15
[INFO] [stderr]     |
[INFO] [stderr] 277 |           let mut s = String::from(format!(
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 278 | |             "<polyline fill='none' stroke='green' stroke-width='{}' points='",
[INFO] [stderr] 279 | |             WALL_STROKE
[INFO] [stderr] 280 | |         ));
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `String::from()`
[INFO] [stderr]     |
[INFO] [stderr] 277 |         let mut s = format!(
[INFO] [stderr] 278 |             "<polyline fill='none' stroke='green' stroke-width='{}' points='",
[INFO] [stderr] 279 |             WALL_STROKE
[INFO] [stderr] 280 |         );
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/maze.rs:314:17
[INFO] [stderr]     |
[INFO] [stderr] 314 |                     current = *from.get(&current).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&from[&current]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:325:11
[INFO] [stderr]     |
[INFO] [stderr] 325 |               if let None = closed.iter().position(|&x| x == current) {
[INFO] [stderr]     |  _____________-      ^^^^
[INFO] [stderr] 326 | |                 closed.push(current);
[INFO] [stderr] 327 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if closed.iter().position(|&x| x == current).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/maze.rs:331:12
[INFO] [stderr]     |
[INFO] [stderr] 331 |                   if let Some(_) = closed.iter().position(|x| x == n) {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 332 | |                     continue;
[INFO] [stderr] 333 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if closed.iter().position(|x| x == n).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:335:12
[INFO] [stderr]     |
[INFO] [stderr] 335 |                   if let None = opened.iter().position(|x| x == n) {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 336 | |                     opened.push(*n);
[INFO] [stderr] 337 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if opened.iter().position(|x| x == n).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/maze.rs:339:26
[INFO] [stderr]     |
[INFO] [stderr] 339 |                 let tgscore: usize = gscore.get(&current).unwrap() + 1;
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gscore[&current]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/maze.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn opposite(&self) -> Dir {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/maze.rs:340:34
[INFO] [stderr]     |
[INFO] [stderr] 340 |                 if gscore.contains_key(n) && &tgscore >= gscore.get(n).unwrap() {
[INFO] [stderr]     |                                              --------^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |                                              |
[INFO] [stderr]     |                                              help: use the left value directly: `tgscore`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/maze.rs:340:46
[INFO] [stderr]     |
[INFO] [stderr] 340 |                 if gscore.contains_key(n) && &tgscore >= gscore.get(n).unwrap() {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gscore[n]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/maze.rs:22:3
[INFO] [stderr]    |
[INFO] [stderr] 22 |           match self {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 23 | |             &Dir::N => Dir::S,
[INFO] [stderr] 24 | |             &Dir::S => Dir::N,
[INFO] [stderr] 25 | |             &Dir::E => Dir::W,
[INFO] [stderr] 26 | |             &Dir::W => Dir::E,
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         match *self {
[INFO] [stderr] 23 |             Dir::N => Dir::S,
[INFO] [stderr] 24 |             Dir::S => Dir::N,
[INFO] [stderr] 25 |             Dir::E => Dir::W,
[INFO] [stderr] 26 |             Dir::W => Dir::E,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:362:10
[INFO] [stderr]     |
[INFO] [stderr] 362 |           if let None = c.walls.iter().position(|x| x == &Dir::E) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 363 | |             if x + 1 < self.width {
[INFO] [stderr] 364 | |                 n.push(Point::new(x + 1, y));
[INFO] [stderr] 365 | |             }
[INFO] [stderr] 366 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::E).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:368:10
[INFO] [stderr]     |
[INFO] [stderr] 368 |           if let None = c.walls.iter().position(|x| x == &Dir::S) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 369 | |             if y + 1 < self.height {
[INFO] [stderr] 370 | |                 n.push(Point::new(x, y + 1));
[INFO] [stderr] 371 | |             }
[INFO] [stderr] 372 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::S).is_none()`
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/maze.rs:43:17
[INFO] [stderr]    |
[INFO] [stderr] 43 | #[derive(Debug, Hash, Eq, Clone)]
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/maze.rs:64:1
[INFO] [stderr]    |
[INFO] [stderr] 64 | / impl PartialEq for Cell {
[INFO] [stderr] 65 | |     fn eq(&self, other: &Cell) -> bool {
[INFO] [stderr] 66 | |         self.filled == other.filled
[INFO] [stderr] 67 | |             && self.walls.contains(&Dir::N) == other.walls.contains(&Dir::N)
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |     }
[INFO] [stderr] 72 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:374:10
[INFO] [stderr]     |
[INFO] [stderr] 374 |           if let None = c.walls.iter().position(|x| x == &Dir::W) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 375 | |             if x > 0 {
[INFO] [stderr] 376 | |                 n.push(Point::new(x - 1, y));
[INFO] [stderr] 377 | |             }
[INFO] [stderr] 378 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::W).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:380:10
[INFO] [stderr]     |
[INFO] [stderr] 380 |           if let None = c.walls.iter().position(|x| x == &Dir::N) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 381 | |             if y > 0 {
[INFO] [stderr] 382 | |                 n.push(Point::new(x, y - 1));
[INFO] [stderr] 383 | |             }
[INFO] [stderr] 384 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::N).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `astar`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the loop variable `x` is only used to index `map`.
[INFO] [stderr]   --> src/maze.rs:94:12
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for x in 0..width {
[INFO] [stderr]    |                  ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for <item> in map.iter_mut().take(width) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/maze.rs:187:63
[INFO] [stderr]     |
[INFO] [stderr] 187 |     pub fn to_svg_file(&self, path: &str, current: Point, astar: &Vec<Point>) {
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/maze.rs:198:46
[INFO] [stderr]     |
[INFO] [stderr] 198 |     pub fn to_svg(&self, current: Point, astar: &Vec<Point>) -> String {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/maze.rs:243:38
[INFO] [stderr]     |
[INFO] [stderr] 243 |     fn draw_wall(x: usize, y: usize, d: &Dir) -> String {
[INFO] [stderr]     |                                         ^^^^ help: consider passing by value instead: `Dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/maze.rs:244:3
[INFO] [stderr]     |
[INFO] [stderr] 244 |           match d {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 245 | |             &Dir::N => format!(
[INFO] [stderr] 246 | |                 "<line x1='{}' y1='{}' x2='{}' y2='{}'/>",
[INFO] [stderr] 247 | |                 x * SIZE,
[INFO] [stderr] ...   |
[INFO] [stderr] 272 | |             ),
[INFO] [stderr] 273 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 244 |         match *d {
[INFO] [stderr] 245 |             Dir::N => format!(
[INFO] [stderr] 246 |                 "<line x1='{}' y1='{}' x2='{}' y2='{}'/>",
[INFO] [stderr] 247 |                 x * SIZE,
[INFO] [stderr] 248 |                 y * SIZE,
[INFO] [stderr] 249 |                 x * SIZE + WALL_SIZE,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/maze.rs:276:21
[INFO] [stderr]     |
[INFO] [stderr] 276 |     fn draw_path(path: &Vec<Point>) -> String {
[INFO] [stderr]     |                        ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/maze.rs:277:15
[INFO] [stderr]     |
[INFO] [stderr] 277 |           let mut s = String::from(format!(
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 278 | |             "<polyline fill='none' stroke='green' stroke-width='{}' points='",
[INFO] [stderr] 279 | |             WALL_STROKE
[INFO] [stderr] 280 | |         ));
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `String::from()`
[INFO] [stderr]     |
[INFO] [stderr] 277 |         let mut s = format!(
[INFO] [stderr] 278 |             "<polyline fill='none' stroke='green' stroke-width='{}' points='",
[INFO] [stderr] 279 |             WALL_STROKE
[INFO] [stderr] 280 |         );
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/maze.rs:314:17
[INFO] [stderr]     |
[INFO] [stderr] 314 |                     current = *from.get(&current).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&from[&current]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:325:11
[INFO] [stderr]     |
[INFO] [stderr] 325 |               if let None = closed.iter().position(|&x| x == current) {
[INFO] [stderr]     |  _____________-      ^^^^
[INFO] [stderr] 326 | |                 closed.push(current);
[INFO] [stderr] 327 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if closed.iter().position(|&x| x == current).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/maze.rs:331:12
[INFO] [stderr]     |
[INFO] [stderr] 331 |                   if let Some(_) = closed.iter().position(|x| x == n) {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 332 | |                     continue;
[INFO] [stderr] 333 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if closed.iter().position(|x| x == n).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:335:12
[INFO] [stderr]     |
[INFO] [stderr] 335 |                   if let None = opened.iter().position(|x| x == n) {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 336 | |                     opened.push(*n);
[INFO] [stderr] 337 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if opened.iter().position(|x| x == n).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/maze.rs:339:26
[INFO] [stderr]     |
[INFO] [stderr] 339 |                 let tgscore: usize = gscore.get(&current).unwrap() + 1;
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gscore[&current]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/maze.rs:340:34
[INFO] [stderr]     |
[INFO] [stderr] 340 |                 if gscore.contains_key(n) && &tgscore >= gscore.get(n).unwrap() {
[INFO] [stderr]     |                                              --------^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |                                              |
[INFO] [stderr]     |                                              help: use the left value directly: `tgscore`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/maze.rs:340:46
[INFO] [stderr]     |
[INFO] [stderr] 340 |                 if gscore.contains_key(n) && &tgscore >= gscore.get(n).unwrap() {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&gscore[n]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:362:10
[INFO] [stderr]     |
[INFO] [stderr] 362 |           if let None = c.walls.iter().position(|x| x == &Dir::E) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 363 | |             if x + 1 < self.width {
[INFO] [stderr] 364 | |                 n.push(Point::new(x + 1, y));
[INFO] [stderr] 365 | |             }
[INFO] [stderr] 366 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::E).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:368:10
[INFO] [stderr]     |
[INFO] [stderr] 368 |           if let None = c.walls.iter().position(|x| x == &Dir::S) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 369 | |             if y + 1 < self.height {
[INFO] [stderr] 370 | |                 n.push(Point::new(x, y + 1));
[INFO] [stderr] 371 | |             }
[INFO] [stderr] 372 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::S).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:374:10
[INFO] [stderr]     |
[INFO] [stderr] 374 |           if let None = c.walls.iter().position(|x| x == &Dir::W) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 375 | |             if x > 0 {
[INFO] [stderr] 376 | |                 n.push(Point::new(x - 1, y));
[INFO] [stderr] 377 | |             }
[INFO] [stderr] 378 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::W).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/maze.rs:380:10
[INFO] [stderr]     |
[INFO] [stderr] 380 |           if let None = c.walls.iter().position(|x| x == &Dir::N) {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 381 | |             if y > 0 {
[INFO] [stderr] 382 | |                 n.push(Point::new(x, y - 1));
[INFO] [stderr] 383 | |             }
[INFO] [stderr] 384 | |         }
[INFO] [stderr]     | |_________- help: try this: `if c.walls.iter().position(|x| x == &Dir::N).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `astar`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "5c124e7462212723c1b06a29715708082decca27838f7263362617f703236ad8"`
[INFO] running `"docker" "rm" "-f" "5c124e7462212723c1b06a29715708082decca27838f7263362617f703236ad8"`
[INFO] [stdout] 5c124e7462212723c1b06a29715708082decca27838f7263362617f703236ad8