[INFO] updating cached repository maeln/Oneliner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/maeln/Oneliner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/maeln/Oneliner" "work/ex/clippy-test-run/sources/stable/gh/maeln/Oneliner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/maeln/Oneliner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/maeln/Oneliner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maeln/Oneliner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maeln/Oneliner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d4387599db55cf8146ef7a82186cc9a1c3d7dea7 [INFO] sha for GitHub repo maeln/Oneliner: d4387599db55cf8146ef7a82186cc9a1c3d7dea7 [INFO] validating manifest of maeln/Oneliner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maeln/Oneliner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maeln/Oneliner [INFO] finished frobbing maeln/Oneliner [INFO] frobbed toml for maeln/Oneliner written to work/ex/clippy-test-run/sources/stable/gh/maeln/Oneliner/Cargo.toml [INFO] started frobbing maeln/Oneliner [INFO] finished frobbing maeln/Oneliner [INFO] frobbed toml for maeln/Oneliner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/maeln/Oneliner/Cargo.toml [INFO] crate maeln/Oneliner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maeln/Oneliner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/maeln/Oneliner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f299e0c38e799091807bbc8c00de3970d0557a0ab356c019d68628a3cf08ecc [INFO] running `"docker" "start" "-a" "4f299e0c38e799091807bbc8c00de3970d0557a0ab356c019d68628a3cf08ecc"` [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking crossbeam-channel v0.3.2 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking crossbeam v0.5.0 [INFO] [stderr] Checking oneliner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 101 | | if mkc.save_binary(bin_path).is_err() { [INFO] [stderr] 102 | | panic!("Could not save binary"); [INFO] [stderr] 103 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if mkc.save_binary(bin_path).is_err() { [INFO] [stderr] 101 | panic!("Could not save binary"); [INFO] [stderr] 102 | } else { [INFO] [stderr] 103 | println!( [INFO] [stderr] 104 | "Binary serialized in {}s in file: {}", [INFO] [stderr] 105 | get_fract_s(now), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 101 | | if mkc.save_binary(bin_path).is_err() { [INFO] [stderr] 102 | | panic!("Could not save binary"); [INFO] [stderr] 103 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if mkc.save_binary(bin_path).is_err() { [INFO] [stderr] 101 | panic!("Could not save binary"); [INFO] [stderr] 102 | } else { [INFO] [stderr] 103 | println!( [INFO] [stderr] 104 | "Binary serialized in {}s in file: {}", [INFO] [stderr] 105 | get_fract_s(now), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SerializeError` [INFO] [stderr] --> src/serialize/errors.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | SerializeError, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnserializeError` [INFO] [stderr] --> src/serialize/errors.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | UnserializeError, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_serialize` [INFO] [stderr] --> src/serialize/errors.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_serialize() -> Error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_unserialize` [INFO] [stderr] --> src/serialize/errors.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn new_unserialize() -> Error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_cause` [INFO] [stderr] --> src/serialize/errors.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn into_cause(self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/markovchain.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if prob.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prob.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/markovchain.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | probvec.push((k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/markovchain.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | probvec.push((k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/markovchain.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | let mut current = self.start.choose(&mut rng).unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.start.choose(&mut rng).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/markovchain.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | .map_err(|e| Error::new_io_error(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::new_io_error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/markovchain.rs:192:66 [INFO] [stderr] | [INFO] [stderr] 192 | Ok(mut bin_file) => bin_file.write_all(&ser).map_err(|e| Error::new_io_error(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::new_io_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SerializeError` [INFO] [stderr] --> src/serialize/errors.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | SerializeError, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnserializeError` [INFO] [stderr] --> src/serialize/errors.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | UnserializeError, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_serialize` [INFO] [stderr] --> src/serialize/errors.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_serialize() -> Error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_unserialize` [INFO] [stderr] --> src/serialize/errors.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn new_unserialize() -> Error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_cause` [INFO] [stderr] --> src/serialize/errors.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn into_cause(self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/markovchain.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if prob.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prob.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/markovchain.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | probvec.push((k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/markovchain.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | probvec.push((k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/markovchain.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | let mut current = self.start.choose(&mut rng).unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.start.choose(&mut rng).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/markovchain.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | .map_err(|e| Error::new_io_error(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::new_io_error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/markovchain.rs:192:66 [INFO] [stderr] | [INFO] [stderr] 192 | Ok(mut bin_file) => bin_file.write_all(&ser).map_err(|e| Error::new_io_error(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::new_io_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.12s [INFO] running `"docker" "inspect" "4f299e0c38e799091807bbc8c00de3970d0557a0ab356c019d68628a3cf08ecc"` [INFO] running `"docker" "rm" "-f" "4f299e0c38e799091807bbc8c00de3970d0557a0ab356c019d68628a3cf08ecc"` [INFO] [stdout] 4f299e0c38e799091807bbc8c00de3970d0557a0ab356c019d68628a3cf08ecc