[INFO] updating cached repository macabu/headliner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/macabu/headliner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/macabu/headliner" "work/ex/clippy-test-run/sources/stable/gh/macabu/headliner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/macabu/headliner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/macabu/headliner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/macabu/headliner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/macabu/headliner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9d2af1e945581073ac98a0e207856ac1fec3ba21 [INFO] sha for GitHub repo macabu/headliner: 9d2af1e945581073ac98a0e207856ac1fec3ba21 [INFO] validating manifest of macabu/headliner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of macabu/headliner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing macabu/headliner [INFO] finished frobbing macabu/headliner [INFO] frobbed toml for macabu/headliner written to work/ex/clippy-test-run/sources/stable/gh/macabu/headliner/Cargo.toml [INFO] started frobbing macabu/headliner [INFO] finished frobbing macabu/headliner [INFO] frobbed toml for macabu/headliner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/macabu/headliner/Cargo.toml [INFO] crate macabu/headliner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting macabu/headliner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/macabu/headliner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8d87f55bef669cbc46b420a616ff0f4fbefd476da88f94704ec00f9d4f2849a [INFO] running `"docker" "start" "-a" "c8d87f55bef669cbc46b420a616ff0f4fbefd476da88f94704ec00f9d4f2849a"` [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking uuid v0.6.3 [INFO] [stderr] Checking os_type v2.0.0 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking human-panic v0.4.0 [INFO] [stderr] Checking headliner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | let _ok = write!(temp_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | let _ok = write!(temp_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:112:19 [INFO] [stderr] | [INFO] [stderr] 112 | let _ok = write!(input_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | let _ok = write!(list_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | let _ok = write!(temp_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | let _ok = write!(temp_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:112:19 [INFO] [stderr] | [INFO] [stderr] 112 | let _ok = write!(input_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/test.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | let _ok = write!(list_file, "{}\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/args.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/args.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/test.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::PathBuf` [INFO] [stderr] --> src/test.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::path::PathBuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `File`, `remove_file` [INFO] [stderr] --> src/test.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::{File, remove_file}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/test.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let valid_csv =` [INFO] [stderr] --> src/test.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | let valid_csv = write_to_csv(valid_path, valid_rows).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.67s [INFO] running `"docker" "inspect" "c8d87f55bef669cbc46b420a616ff0f4fbefd476da88f94704ec00f9d4f2849a"` [INFO] running `"docker" "rm" "-f" "c8d87f55bef669cbc46b420a616ff0f4fbefd476da88f94704ec00f9d4f2849a"` [INFO] [stdout] c8d87f55bef669cbc46b420a616ff0f4fbefd476da88f94704ec00f9d4f2849a