[INFO] updating cached repository mabraca/Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mabraca/Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mabraca/Rust" "work/ex/clippy-test-run/sources/stable/gh/mabraca/Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mabraca/Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mabraca/Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mabraca/Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mabraca/Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d5a85c2c3c6c1ddd2cda03cedbbc67d4bc434656 [INFO] sha for GitHub repo mabraca/Rust: d5a85c2c3c6c1ddd2cda03cedbbc67d4bc434656 [INFO] validating manifest of mabraca/Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mabraca/Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mabraca/Rust [INFO] finished frobbing mabraca/Rust [INFO] frobbed toml for mabraca/Rust written to work/ex/clippy-test-run/sources/stable/gh/mabraca/Rust/Cargo.toml [INFO] started frobbing mabraca/Rust [INFO] finished frobbing mabraca/Rust [INFO] frobbed toml for mabraca/Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mabraca/Rust/Cargo.toml [INFO] crate mabraca/Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mabraca/Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mabraca/Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fba21875f8eac81a8d0334bff4b3b326e4703a1f1f12afcb78122bb70816ef6a [INFO] running `"docker" "start" "-a" "fba21875f8eac81a8d0334bff4b3b326e4703a1f1f12afcb78122bb70816ef6a"` [INFO] [stderr] Checking walkdir v2.1.4 [INFO] [stderr] Checking project v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | let revisar = if args.len() == 3 && &args[2] == "i" { false } else { true }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(args.len() == 3 && &args[2] == "i")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | let revisar = if args.len() == 3 && &args[2] == "i" { false } else { true }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(args.len() == 3 && &args[2] == "i")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | let valor = line.rfind("$"); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | let valor = line.rfind("$"); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "fba21875f8eac81a8d0334bff4b3b326e4703a1f1f12afcb78122bb70816ef6a"` [INFO] running `"docker" "rm" "-f" "fba21875f8eac81a8d0334bff4b3b326e4703a1f1f12afcb78122bb70816ef6a"` [INFO] [stdout] fba21875f8eac81a8d0334bff4b3b326e4703a1f1f12afcb78122bb70816ef6a