[INFO] updating cached repository m4b/cargo-sym [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/m4b/cargo-sym [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/m4b/cargo-sym" "work/ex/clippy-test-run/sources/stable/gh/m4b/cargo-sym"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/m4b/cargo-sym'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/m4b/cargo-sym" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m4b/cargo-sym"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m4b/cargo-sym'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9622ffb7217d565b03bf90cba19df3bc781c8b0f [INFO] sha for GitHub repo m4b/cargo-sym: 9622ffb7217d565b03bf90cba19df3bc781c8b0f [INFO] validating manifest of m4b/cargo-sym on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of m4b/cargo-sym on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing m4b/cargo-sym [INFO] finished frobbing m4b/cargo-sym [INFO] frobbed toml for m4b/cargo-sym written to work/ex/clippy-test-run/sources/stable/gh/m4b/cargo-sym/Cargo.toml [INFO] started frobbing m4b/cargo-sym [INFO] finished frobbing m4b/cargo-sym [INFO] frobbed toml for m4b/cargo-sym written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m4b/cargo-sym/Cargo.toml [INFO] crate m4b/cargo-sym has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting m4b/cargo-sym against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/m4b/cargo-sym:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4161d08a9626a1c2403497e9ad6ddf407310f4787c299218b0c6e74357f618a1 [INFO] running `"docker" "start" "-a" "4161d08a9626a1c2403497e9ad6ddf407310f4787c299218b0c6e74357f618a1"` [INFO] [stderr] Compiling quote v0.3.12 [INFO] [stderr] Checking scroll v0.3.0 [INFO] [stderr] Checking walkdir v1.0.1 [INFO] [stderr] Compiling cmake v0.1.18 [INFO] [stderr] Checking term_size v0.2.1 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Checking clap v2.18.0 [INFO] [stderr] Compiling syn v0.10.7 [INFO] [stderr] Compiling capstone-sys v0.2.0 [INFO] [stderr] Compiling scroll_derive v0.3.0 [INFO] [stderr] Checking goblin v0.0.8 [INFO] [stderr] Checking capstone3 v0.1.0 [INFO] [stderr] Checking cargo-sym v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | demangle: demangle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `demangle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | vaddr: vaddr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | is_function: is_function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marksman.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | crate_name: crate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marksman.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | demangle: demangle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `demangle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | exports: exports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `exports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | disassemble: disassemble, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `disassemble` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | dump: dump, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dump` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | release: release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | example: example, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `example` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | crate_name: crate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | demangle: demangle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `demangle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | vaddr: vaddr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | is_function: is_function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marksman.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | crate_name: crate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marksman.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | demangle: demangle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `demangle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | exports: exports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `exports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | disassemble: disassemble, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `disassemble` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | dump: dump, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dump` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | release: release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | example: example, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `example` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | crate_name: crate_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/symbol.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | if use_delimiter { [INFO] [stderr] 51 | | format!("{:08x} <{}>", self.vaddr, &name) [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | format!("{:016x} {}", self.vaddr, &name) [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | } else if use_delimiter { [INFO] [stderr] 50 | format!("{:08x} <{}>", self.vaddr, &name) [INFO] [stderr] 51 | } else { [INFO] [stderr] 52 | format!("{:016x} {}", self.vaddr, &name) [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/symbol.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | if use_delimiter { [INFO] [stderr] 51 | | format!("{:08x} <{}>", self.vaddr, &name) [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | format!("{:016x} {}", self.vaddr, &name) [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | } else if use_delimiter { [INFO] [stderr] 50 | format!("{:08x} <{}>", self.vaddr, &name) [INFO] [stderr] 51 | } else { [INFO] [stderr] 52 | format!("{:016x} {}", self.vaddr, &name) [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut hex_buffer = &mut stack_buffer[..column_width * NCOLUMNS]; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | let mut bytes = &mut Cursor::new(&buffer); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/symbol.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / let mut name: &str = &self.demangle(); [INFO] [stderr] 39 | | if !demangle { [INFO] [stderr] 40 | | name = &self.name(); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let name = if !demangle { &self.name() } else { &self.demangle() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | _mode: &capstone::Mode) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `capstone::Mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:168:43 [INFO] [stderr] | [INFO] [stderr] 168 | mode: &capstone::Mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `capstone::Mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:273:12 [INFO] [stderr] | [INFO] [stderr] 273 | if section_headers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `section_headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:276:56 [INFO] [stderr] | [INFO] [stderr] 276 | let sections: Vec<(_, &str)> = section_headers.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:283:12 [INFO] [stderr] | [INFO] [stderr] 283 | if syms.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `syms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:288:33 [INFO] [stderr] | [INFO] [stderr] 288 | let mut elf_syms = syms.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | / match section_name { [INFO] [stderr] 322 | | // TODO: this is now a _broken_ hack for printing PLT entries (it doesn't print them, [INFO] [stderr] 323 | | // because there are no longer any symbols with the plt section to set off this logic) [INFO] [stderr] 324 | | &".plt" | &".plt.got" => { [INFO] [stderr] ... | [INFO] [stderr] 349 | | _ => (), [INFO] [stderr] 350 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | match *section_name { [INFO] [stderr] 322 | // TODO: this is now a _broken_ hack for printing PLT entries (it doesn't print them, [INFO] [stderr] 323 | // because there are no longer any symbols with the plt section to set off this logic) [INFO] [stderr] 324 | ".plt" | ".plt.got" => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut hex_buffer = &mut stack_buffer[..column_width * NCOLUMNS]; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:377:25 [INFO] [stderr] | [INFO] [stderr] 377 | vaddr = vaddr - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `vaddr -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:378:25 [INFO] [stderr] | [INFO] [stderr] 378 | offset = offset - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:405:5 [INFO] [stderr] | [INFO] [stderr] 405 | bytes.read(&mut magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:408:55 [INFO] [stderr] | [INFO] [stderr] 408 | let archive = goblin::archive::Archive::parse(&mut bytes, metadata.len() as usize)?; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-sym`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | let mut bytes = &mut Cursor::new(&buffer); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/symbol.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / let mut name: &str = &self.demangle(); [INFO] [stderr] 39 | | if !demangle { [INFO] [stderr] 40 | | name = &self.name(); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let name = if !demangle { &self.name() } else { &self.demangle() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | _mode: &capstone::Mode) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `capstone::Mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:168:43 [INFO] [stderr] | [INFO] [stderr] 168 | mode: &capstone::Mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `capstone::Mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:273:12 [INFO] [stderr] | [INFO] [stderr] 273 | if section_headers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `section_headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:276:56 [INFO] [stderr] | [INFO] [stderr] 276 | let sections: Vec<(_, &str)> = section_headers.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:283:12 [INFO] [stderr] | [INFO] [stderr] 283 | if syms.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `syms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:288:33 [INFO] [stderr] | [INFO] [stderr] 288 | let mut elf_syms = syms.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | / match section_name { [INFO] [stderr] 322 | | // TODO: this is now a _broken_ hack for printing PLT entries (it doesn't print them, [INFO] [stderr] 323 | | // because there are no longer any symbols with the plt section to set off this logic) [INFO] [stderr] 324 | | &".plt" | &".plt.got" => { [INFO] [stderr] ... | [INFO] [stderr] 349 | | _ => (), [INFO] [stderr] 350 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | match *section_name { [INFO] [stderr] 322 | // TODO: this is now a _broken_ hack for printing PLT entries (it doesn't print them, [INFO] [stderr] 323 | // because there are no longer any symbols with the plt section to set off this logic) [INFO] [stderr] 324 | ".plt" | ".plt.got" => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:377:25 [INFO] [stderr] | [INFO] [stderr] 377 | vaddr = vaddr - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `vaddr -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:378:25 [INFO] [stderr] | [INFO] [stderr] 378 | offset = offset - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:405:5 [INFO] [stderr] | [INFO] [stderr] 405 | bytes.read(&mut magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:408:55 [INFO] [stderr] | [INFO] [stderr] 408 | let archive = goblin::archive::Archive::parse(&mut bytes, metadata.len() as usize)?; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-sym`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4161d08a9626a1c2403497e9ad6ddf407310f4787c299218b0c6e74357f618a1"` [INFO] running `"docker" "rm" "-f" "4161d08a9626a1c2403497e9ad6ddf407310f4787c299218b0c6e74357f618a1"` [INFO] [stdout] 4161d08a9626a1c2403497e9ad6ddf407310f4787c299218b0c6e74357f618a1