[INFO] updating cached repository lyuha/viewing_system.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lyuha/viewing_system.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lyuha/viewing_system.rs" "work/ex/clippy-test-run/sources/stable/gh/lyuha/viewing_system.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lyuha/viewing_system.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lyuha/viewing_system.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lyuha/viewing_system.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lyuha/viewing_system.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32d3a798e45753f2134cd8dd927c93499f5c171f [INFO] sha for GitHub repo lyuha/viewing_system.rs: 32d3a798e45753f2134cd8dd927c93499f5c171f [INFO] validating manifest of lyuha/viewing_system.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lyuha/viewing_system.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lyuha/viewing_system.rs [INFO] finished frobbing lyuha/viewing_system.rs [INFO] frobbed toml for lyuha/viewing_system.rs written to work/ex/clippy-test-run/sources/stable/gh/lyuha/viewing_system.rs/Cargo.toml [INFO] started frobbing lyuha/viewing_system.rs [INFO] finished frobbing lyuha/viewing_system.rs [INFO] frobbed toml for lyuha/viewing_system.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lyuha/viewing_system.rs/Cargo.toml [INFO] crate lyuha/viewing_system.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lyuha/viewing_system.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lyuha/viewing_system.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 493e3e8db83264aa05e493e8e48b2e27e3d576eebc0e3c840764b9793fb3c5e1 [INFO] running `"docker" "start" "-a" "493e3e8db83264aa05e493e8e48b2e27e3d576eebc0e3c840764b9793fb3c5e1"` [INFO] [stderr] Compiling nfd v0.0.4 [INFO] [stderr] Compiling glium v0.21.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking conrod v0.60.0 [INFO] [stderr] Checking viewing_system v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | const FONT_PATH: &'static str = concat!( [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | texture [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:274:23 [INFO] [stderr] | [INFO] [stderr] 274 | let texture = glium::texture::Texture2d::new(display, raw_image).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | const FONT_PATH: &'static str = concat!( [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | texture [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:274:23 [INFO] [stderr] | [INFO] [stderr] 274 | let texture = glium::texture::Texture2d::new(display, raw_image).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:57:93 [INFO] [stderr] | [INFO] [stderr] 57 | let screen = image_to_texture2d(image::RgbaImage::from_fn(SCREEN_WIDTH, HEIGHT, |x, y| { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `view_mode` is never read [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | view_mode = if is_perspective { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:57:93 [INFO] [stderr] | [INFO] [stderr] 57 | let screen = image_to_texture2d(image::RgbaImage::from_fn(SCREEN_WIDTH, HEIGHT, |x, y| { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `view_mode` is never read [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | view_mode = if is_perspective { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MARGIN` [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | const MARGIN: conrod::Scalar = 30.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MARGIN` [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | const MARGIN: conrod::Scalar = 30.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:46 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:60 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:46 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:60 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | / match event.clone() { [INFO] [stderr] 91 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 92 | | glium::glutin::WindowEvent::Closed [INFO] [stderr] 93 | | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let glium::glutin::Event::WindowEvent { event, .. } = event.clone() { match event { [INFO] [stderr] 91 | glium::glutin::WindowEvent::Closed [INFO] [stderr] 92 | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 93 | input: [INFO] [stderr] 94 | glium::glutin::KeyboardInput { [INFO] [stderr] 95 | virtual_keycode: Some(glium::glutin::VirtualKeyCode::Escape), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | / match event.clone() { [INFO] [stderr] 91 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 92 | | glium::glutin::WindowEvent::Closed [INFO] [stderr] 93 | | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let glium::glutin::Event::WindowEvent { event, .. } = event.clone() { match event { [INFO] [stderr] 91 | glium::glutin::WindowEvent::Closed [INFO] [stderr] 92 | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 93 | input: [INFO] [stderr] 94 | glium::glutin::KeyboardInput { [INFO] [stderr] 95 | virtual_keycode: Some(glium::glutin::VirtualKeyCode::Escape), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | widget::Image::new(screen).w_h(screen_w as conrod::Scalar, screen_h as conrod::Scalar).middle_of(ids.draw_panel).set(ids.draw_texture, ui); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(screen_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:121:80 [INFO] [stderr] | [INFO] [stderr] 121 | widget::Image::new(screen).w_h(screen_w as conrod::Scalar, screen_h as conrod::Scalar).middle_of(ids.draw_panel).set(ids.draw_texture, ui); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(screen_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | widget::Image::new(screen).w_h(screen_w as conrod::Scalar, screen_h as conrod::Scalar).middle_of(ids.draw_panel).set(ids.draw_texture, ui); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(screen_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:121:80 [INFO] [stderr] | [INFO] [stderr] 121 | widget::Image::new(screen).w_h(screen_w as conrod::Scalar, screen_h as conrod::Scalar).middle_of(ids.draw_panel).set(ids.draw_texture, ui); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(screen_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:70 [INFO] [stderr] | [INFO] [stderr] 147 | widget::Canvas::new().color(color::BLACK).length(SCREEN_WIDTH as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCREEN_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:70 [INFO] [stderr] | [INFO] [stderr] 147 | widget::Canvas::new().color(color::BLACK).length(SCREEN_WIDTH as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCREEN_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.04s [INFO] running `"docker" "inspect" "493e3e8db83264aa05e493e8e48b2e27e3d576eebc0e3c840764b9793fb3c5e1"` [INFO] running `"docker" "rm" "-f" "493e3e8db83264aa05e493e8e48b2e27e3d576eebc0e3c840764b9793fb3c5e1"` [INFO] [stdout] 493e3e8db83264aa05e493e8e48b2e27e3d576eebc0e3c840764b9793fb3c5e1