[INFO] updating cached repository lypnol/adventofcode-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lypnol/adventofcode-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lypnol/adventofcode-2017" "work/ex/clippy-test-run/sources/stable/gh/lypnol/adventofcode-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lypnol/adventofcode-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lypnol/adventofcode-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lypnol/adventofcode-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lypnol/adventofcode-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 03ced3df3eb80e5c7965c4120e3932919067cb15 [INFO] sha for GitHub repo lypnol/adventofcode-2017: 03ced3df3eb80e5c7965c4120e3932919067cb15 [INFO] validating manifest of lypnol/adventofcode-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lypnol/adventofcode-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lypnol/adventofcode-2017 [INFO] finished frobbing lypnol/adventofcode-2017 [INFO] frobbed toml for lypnol/adventofcode-2017 written to work/ex/clippy-test-run/sources/stable/gh/lypnol/adventofcode-2017/Cargo.toml [INFO] started frobbing lypnol/adventofcode-2017 [INFO] finished frobbing lypnol/adventofcode-2017 [INFO] frobbed toml for lypnol/adventofcode-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lypnol/adventofcode-2017/Cargo.toml [INFO] crate lypnol/adventofcode-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lypnol/adventofcode-2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lypnol/adventofcode-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2bf0ceb7c7ec15b8b4364b49af11f1541c4cbee79ccfccddf196c7e9820a240 [INFO] running `"docker" "start" "-a" "e2bf0ceb7c7ec15b8b4364b49af11f1541c4cbee79ccfccddf196c7e9820a240"` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping elements of `v` manually [INFO] [stderr] --> day-14/part-2/enizor.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / let x = v[(pos + i) % n]; [INFO] [stderr] 44 | | v[(pos + i) % n] = v[(pos + len - 1 - i) % n]; [INFO] [stderr] 45 | | v[(pos + len - 1 - i) % n] = x; [INFO] [stderr] | |______________________________________^ help: try: `v.swap((pos + i) % n, (pos + len - 1 - i) % n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> day-14/part-2/enizor.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | fn find_item(k: (usize, usize), v: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(usize, usize)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> day-14/part-2/enizor.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | for i in 1..129 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 78 | for (i, ) in grid.iter_mut().enumerate().take(129).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `v` manually [INFO] [stderr] --> day-14/part-1/enizor.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / let x = v[(pos + i) % n]; [INFO] [stderr] 60 | | v[(pos + i) % n] = v[(pos + len - 1 - i) % n]; [INFO] [stderr] 61 | | v[(pos + len - 1 - i) % n] = x; [INFO] [stderr] | |______________________________________^ help: try: `v.swap((pos + i) % n, (pos + len - 1 - i) % n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `v` manually [INFO] [stderr] --> day-14/part-2/enizor.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / let x = v[(pos + i) % n]; [INFO] [stderr] 44 | | v[(pos + i) % n] = v[(pos + len - 1 - i) % n]; [INFO] [stderr] 45 | | v[(pos + len - 1 - i) % n] = x; [INFO] [stderr] | |______________________________________^ help: try: `v.swap((pos + i) % n, (pos + len - 1 - i) % n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> day-14/part-2/enizor.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | fn find_item(k: (usize, usize), v: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(usize, usize)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> day-14/part-2/enizor.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | for i in 1..129 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 78 | for (i, ) in grid.iter_mut().enumerate().take(129).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `v` manually [INFO] [stderr] --> day-14/part-1/enizor.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / let x = v[(pos + i) % n]; [INFO] [stderr] 60 | | v[(pos + i) % n] = v[(pos + len - 1 - i) % n]; [INFO] [stderr] 61 | | v[(pos + len - 1 - i) % n] = x; [INFO] [stderr] | |______________________________________^ help: try: `v.swap((pos + i) % n, (pos + len - 1 - i) % n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "e2bf0ceb7c7ec15b8b4364b49af11f1541c4cbee79ccfccddf196c7e9820a240"` [INFO] running `"docker" "rm" "-f" "e2bf0ceb7c7ec15b8b4364b49af11f1541c4cbee79ccfccddf196c7e9820a240"` [INFO] [stdout] e2bf0ceb7c7ec15b8b4364b49af11f1541c4cbee79ccfccddf196c7e9820a240