[INFO] updating cached repository luser/tracetree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luser/tracetree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luser/tracetree" "work/ex/clippy-test-run/sources/stable/gh/luser/tracetree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luser/tracetree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luser/tracetree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/tracetree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/tracetree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 587eaaa90ad2469b37a6a8568e024276e99e11dc [INFO] sha for GitHub repo luser/tracetree: 587eaaa90ad2469b37a6a8568e024276e99e11dc [INFO] validating manifest of luser/tracetree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luser/tracetree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luser/tracetree [INFO] finished frobbing luser/tracetree [INFO] frobbed toml for luser/tracetree written to work/ex/clippy-test-run/sources/stable/gh/luser/tracetree/Cargo.toml [INFO] started frobbing luser/tracetree [INFO] finished frobbing luser/tracetree [INFO] frobbed toml for luser/tracetree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/tracetree/Cargo.toml [INFO] crate luser/tracetree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luser/tracetree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luser/tracetree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8f2b08c2a479c56b72c5b81aa923449acc6a85b78bb1b5860896a08e4afefc8 [INFO] running `"docker" "start" "-a" "d8f2b08c2a479c56b72c5b81aa923449acc6a85b78bb1b5860896a08e4afefc8"` [INFO] [stderr] Compiling libc v0.2.23 [INFO] [stderr] Compiling getopts v0.2.14 [INFO] [stderr] Checking indextree v1.0.1 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking backtrace-sys v0.1.11 [INFO] [stderr] Checking num v0.1.39 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking nix v0.7.0 [INFO] [stderr] Checking chrono v0.3.1 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking clap v2.25.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Compiling pulldown-cmark v0.0.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Compiling tempdir v0.3.5 [INFO] [stderr] Compiling skeptic v0.5.0 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Compiling spawn-ptrace v0.1.0 [INFO] [stderr] Checking tracetree v0.1.6-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | pids: pids, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | started: started, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `started` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:38 [INFO] [stderr] | [INFO] [stderr] 275 | arena.new_node(ProcessInfo { pid: pid, .. ProcessInfo::default() }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | pids: pids, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | started: started, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `started` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:38 [INFO] [stderr] | [INFO] [stderr] 275 | arena.new_node(ProcessInfo { pid: pid, .. ProcessInfo::default() }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / pub fn traverse<'a>(&'a self) -> Traverse<'a> { [INFO] [stderr] 189 | | Traverse { [INFO] [stderr] 190 | | inner: self.root.traverse(&self.arena), [INFO] [stderr] 191 | | arena: &self.arena, [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / pub fn traverse<'a>(&'a self) -> Traverse<'a> { [INFO] [stderr] 189 | | Traverse { [INFO] [stderr] 190 | | inner: self.root.traverse(&self.arena), [INFO] [stderr] 191 | | arena: &self.arena, [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:29:72 [INFO] [stderr] | [INFO] [stderr] 29 | format!("{}.{:03}s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:29:72 [INFO] [stderr] | [INFO] [stderr] 29 | format!("{}.{:03}s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / arg_enum!{ [INFO] [stderr] 64 | | #[derive(Debug)] [INFO] [stderr] 65 | | #[allow(non_camel_case_types)] [INFO] [stderr] 66 | | pub enum OutputFormat { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / arg_enum!{ [INFO] [stderr] 64 | | #[derive(Debug)] [INFO] [stderr] 65 | | #[allow(non_camel_case_types)] [INFO] [stderr] 66 | | pub enum OutputFormat { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:29:46 [INFO] [stderr] | [INFO] [stderr] 29 | format!("{}.{:03}s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:52:141 [INFO] [stderr] | [INFO] [stderr] 52 | println!("{}{} {} {}[{}]", "\t".repeat(depth), info.pid, p, cmdline, info.ended.map(|e| fmt_duration(e - info.started)).unwrap_or("?".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:29:46 [INFO] [stderr] | [INFO] [stderr] 29 | format!("{}.{:03}s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:52:141 [INFO] [stderr] | [INFO] [stderr] 52 | println!("{}{} {} {}[{}]", "\t".repeat(depth), info.pid, p, cmdline, info.ended.map(|e| fmt_duration(e - info.started)).unwrap_or("?".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.96s [INFO] running `"docker" "inspect" "d8f2b08c2a479c56b72c5b81aa923449acc6a85b78bb1b5860896a08e4afefc8"` [INFO] running `"docker" "rm" "-f" "d8f2b08c2a479c56b72c5b81aa923449acc6a85b78bb1b5860896a08e4afefc8"` [INFO] [stdout] d8f2b08c2a479c56b72c5b81aa923449acc6a85b78bb1b5860896a08e4afefc8