[INFO] updating cached repository luser/query-crates-index [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luser/query-crates-index [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luser/query-crates-index" "work/ex/clippy-test-run/sources/stable/gh/luser/query-crates-index"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luser/query-crates-index'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luser/query-crates-index" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/query-crates-index"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/query-crates-index'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 26a825fc11ac8d29b32bdf35a92748e3e31dedf4 [INFO] sha for GitHub repo luser/query-crates-index: 26a825fc11ac8d29b32bdf35a92748e3e31dedf4 [INFO] validating manifest of luser/query-crates-index on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luser/query-crates-index on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luser/query-crates-index [INFO] finished frobbing luser/query-crates-index [INFO] frobbed toml for luser/query-crates-index written to work/ex/clippy-test-run/sources/stable/gh/luser/query-crates-index/Cargo.toml [INFO] started frobbing luser/query-crates-index [INFO] finished frobbing luser/query-crates-index [INFO] frobbed toml for luser/query-crates-index written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/query-crates-index/Cargo.toml [INFO] crate luser/query-crates-index has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luser/query-crates-index against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luser/query-crates-index:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8be5a963318906c86e1d5950852cf7f451d52fb49be9c9d4e79400bd6f960967 [INFO] running `"docker" "start" "-a" "8be5a963318906c86e1d5950852cf7f451d52fb49be9c9d4e79400bd6f960967"` [INFO] [stderr] Checking home v0.3.0 [INFO] [stderr] Checking termcolor v0.3.3 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking rand v0.3.20 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking jobserver v0.1.9 [INFO] [stderr] Checking socket2 v0.3.0 [INFO] [stderr] Checking filetime v0.1.14 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking semver v0.8.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking petgraph v0.4.11 [INFO] [stderr] Checking walkdir v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking openssl-sys v0.9.24 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking miniz-sys v0.1.10 [INFO] [stderr] Checking tar v0.4.14 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking openssl v0.9.23 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Checking globset v0.2.1 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking ignore v0.2.2 [INFO] [stderr] Checking crypto-hash v0.3.0 [INFO] [stderr] Checking curl v0.4.11 [INFO] [stderr] Checking crates-io v0.13.0 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking git2-curl v0.7.0 [INFO] [stderr] Checking cargo v0.24.0 [INFO] [stderr] Checking query-crates-index v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:133:73 [INFO] [stderr] | [INFO] [stderr] 133 | format!("{}.{:03} s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:133:73 [INFO] [stderr] | [INFO] [stderr] 133 | format!("{}.{:03} s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/main.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | / impl Hash for CrateVersion { [INFO] [stderr] 124 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 125 | | self.name.hash(state); [INFO] [stderr] 126 | | self.version.hash(state); [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/main.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:133:47 [INFO] [stderr] | [INFO] [stderr] 133 | format!("{}.{:03} s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | c.versions.iter().filter(|v| dep.req.matches(&v.version)).next() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|v| dep.req.matches(&v.version)).next()` with `find(|v| dep.req.matches(&v.version))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | let idx = *crate_nodes.get(v).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&crate_nodes[v]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:194:32 [INFO] [stderr] | [INFO] [stderr] 194 | let dep_idx = *crate_nodes.get(depver).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&crate_nodes[depver]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `query-crates-index`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/main.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | / impl Hash for CrateVersion { [INFO] [stderr] 124 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 125 | | self.name.hash(state); [INFO] [stderr] 126 | | self.version.hash(state); [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/main.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:133:47 [INFO] [stderr] | [INFO] [stderr] 133 | format!("{}.{:03} s", duration.as_secs(), duration.subsec_nanos() / 1000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | c.versions.iter().filter(|v| dep.req.matches(&v.version)).next() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|v| dep.req.matches(&v.version)).next()` with `find(|v| dep.req.matches(&v.version))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | let idx = *crate_nodes.get(v).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&crate_nodes[v]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:194:32 [INFO] [stderr] | [INFO] [stderr] 194 | let dep_idx = *crate_nodes.get(depver).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&crate_nodes[depver]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `query-crates-index`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8be5a963318906c86e1d5950852cf7f451d52fb49be9c9d4e79400bd6f960967"` [INFO] running `"docker" "rm" "-f" "8be5a963318906c86e1d5950852cf7f451d52fb49be9c9d4e79400bd6f960967"` [INFO] [stdout] 8be5a963318906c86e1d5950852cf7f451d52fb49be9c9d4e79400bd6f960967