[INFO] updating cached repository luser/procio-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luser/procio-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luser/procio-rs" "work/ex/clippy-test-run/sources/stable/gh/luser/procio-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luser/procio-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luser/procio-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/procio-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/procio-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8cb69bad021308390da7b6182baca3081224045d [INFO] sha for GitHub repo luser/procio-rs: 8cb69bad021308390da7b6182baca3081224045d [INFO] validating manifest of luser/procio-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luser/procio-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luser/procio-rs [INFO] finished frobbing luser/procio-rs [INFO] frobbed toml for luser/procio-rs written to work/ex/clippy-test-run/sources/stable/gh/luser/procio-rs/Cargo.toml [INFO] started frobbing luser/procio-rs [INFO] finished frobbing luser/procio-rs [INFO] frobbed toml for luser/procio-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/procio-rs/Cargo.toml [INFO] crate luser/procio-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luser/procio-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luser/procio-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 464eed1763f4e7c538827454448cf74577c2cf2e44eef66d5265b237b7a1f79b [INFO] running `"docker" "start" "-a" "464eed1763f4e7c538827454448cf74577c2cf2e44eef66d5265b237b7a1f79b"` [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking number_prefix v0.2.7 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking procio v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | write!(writer, "{}.{:03} s", duration.as_secs(), duration.subsec_nanos() / NS_PER_SEC)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | let bps = (bps as f64) + (d.subsec_nanos() / NS_PER_SEC) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos() / NS_PER_SEC)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | let bps = (bps as f64) + (d.subsec_nanos() / NS_PER_SEC) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `d.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | if let Some(_) = p.try_wait()? { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 111 | | return Ok(()); [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________- help: try this: `if p.try_wait()?.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/main.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | e @ _ => return Err(format_err!("Unexpected wait status: {:?}", e)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | write!(writer, "{}.{:03} s", duration.as_secs(), duration.subsec_nanos() / NS_PER_SEC)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | let bps = (bps as f64) + (d.subsec_nanos() / NS_PER_SEC) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos() / NS_PER_SEC)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | let bps = (bps as f64) + (d.subsec_nanos() / NS_PER_SEC) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `d.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | if let Some(_) = p.try_wait()? { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 111 | | return Ok(()); [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________- help: try this: `if p.try_wait()?.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/main.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | e @ _ => return Err(format_err!("Unexpected wait status: {:?}", e)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.86s [INFO] running `"docker" "inspect" "464eed1763f4e7c538827454448cf74577c2cf2e44eef66d5265b237b7a1f79b"` [INFO] running `"docker" "rm" "-f" "464eed1763f4e7c538827454448cf74577c2cf2e44eef66d5265b237b7a1f79b"` [INFO] [stdout] 464eed1763f4e7c538827454448cf74577c2cf2e44eef66d5265b237b7a1f79b