[INFO] updating cached repository luser/hexdump [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luser/hexdump [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luser/hexdump" "work/ex/clippy-test-run/sources/stable/gh/luser/hexdump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luser/hexdump'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luser/hexdump" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/hexdump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/hexdump'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78e82f88f64fbe2411914afec13ff09e9695c9a2 [INFO] sha for GitHub repo luser/hexdump: 78e82f88f64fbe2411914afec13ff09e9695c9a2 [INFO] validating manifest of luser/hexdump on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luser/hexdump on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luser/hexdump [INFO] finished frobbing luser/hexdump [INFO] frobbed toml for luser/hexdump written to work/ex/clippy-test-run/sources/stable/gh/luser/hexdump/Cargo.toml [INFO] started frobbing luser/hexdump [INFO] finished frobbing luser/hexdump [INFO] frobbed toml for luser/hexdump written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luser/hexdump/Cargo.toml [INFO] crate luser/hexdump has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luser/hexdump against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luser/hexdump:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5d467c0a28e75ac2ca1c694c39b1c42c7365ee4f7604f402d98095d987ad1b7 [INFO] running `"docker" "start" "-a" "a5d467c0a28e75ac2ca1c694c39b1c42c7365ee4f7604f402d98095d987ad1b7"` [INFO] [stderr] Compiling pulldown-cmark v0.1.0 [INFO] [stderr] Compiling libc v0.2.30 [INFO] [stderr] Compiling serde v1.0.11 [INFO] [stderr] Compiling itoa v0.3.3 [INFO] [stderr] Compiling bytecount v0.1.7 [INFO] [stderr] Compiling error-chain v0.10.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.5 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Compiling tempdir v0.3.5 [INFO] [stderr] Compiling toml v0.4.5 [INFO] [stderr] Compiling serde_json v1.0.2 [INFO] [stderr] Compiling skeptic v0.12.3 [INFO] [stderr] Compiling read-byte-slice v0.1.0 [INFO] [stderr] Checking hexdump v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | fn printable(b: &u8) -> char { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | ::std::char::from_u32(b as u32).unwrap() [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | fn printable(b: &u8) -> char { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | ::std::char::from_u32(b as u32).unwrap() [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.21s [INFO] running `"docker" "inspect" "a5d467c0a28e75ac2ca1c694c39b1c42c7365ee4f7604f402d98095d987ad1b7"` [INFO] running `"docker" "rm" "-f" "a5d467c0a28e75ac2ca1c694c39b1c42c7365ee4f7604f402d98095d987ad1b7"` [INFO] [stdout] a5d467c0a28e75ac2ca1c694c39b1c42c7365ee4f7604f402d98095d987ad1b7