[INFO] updating cached repository lukaspustina/mhost [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lukaspustina/mhost [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lukaspustina/mhost" "work/ex/clippy-test-run/sources/stable/gh/lukaspustina/mhost"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lukaspustina/mhost'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lukaspustina/mhost" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukaspustina/mhost"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukaspustina/mhost'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 700aecb04285fb74b9408030957d56e9c538a8eb [INFO] sha for GitHub repo lukaspustina/mhost: 700aecb04285fb74b9408030957d56e9c538a8eb [INFO] validating manifest of lukaspustina/mhost on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lukaspustina/mhost on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lukaspustina/mhost [INFO] finished frobbing lukaspustina/mhost [INFO] frobbed toml for lukaspustina/mhost written to work/ex/clippy-test-run/sources/stable/gh/lukaspustina/mhost/Cargo.toml [INFO] started frobbing lukaspustina/mhost [INFO] finished frobbing lukaspustina/mhost [INFO] frobbed toml for lukaspustina/mhost written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukaspustina/mhost/Cargo.toml [INFO] crate lukaspustina/mhost has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lukaspustina/mhost against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lukaspustina/mhost:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e69e65ae30e09cac9b330d9226320f2eb68c5c6b3f16c2d02dbbe2c9fe56cc73 [INFO] running `"docker" "start" "-a" "e69e65ae30e09cac9b330d9226320f2eb68c5c6b3f16c2d02dbbe2c9fe56cc73"` [INFO] [stderr] Compiling cc v1.0.1 [INFO] [stderr] Compiling rustc-demangle v0.1.5 [INFO] [stderr] Compiling pulldown-cmark v0.1.0 [INFO] [stderr] Compiling serde v1.0.15 [INFO] [stderr] Compiling openssl v0.9.20 [INFO] [stderr] Checking either v1.3.0 [INFO] [stderr] Checking data-encoding v1.2.0 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking relay v0.1.0 [INFO] [stderr] Checking colored v1.5.3 [INFO] [stderr] Compiling tempdir v0.3.5 [INFO] [stderr] Checking itertools v0.7.1 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking futures-cpupool v0.1.7 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking mime v0.3.5 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling openssl-sys v0.9.20 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Checking tokio-core v0.1.10 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.6 [INFO] [stderr] Checking tokio-openssl v0.1.3 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.4 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking trust-dns v0.11.3 [INFO] [stderr] Compiling cargo_metadata v0.3.0 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Checking mhost v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dns.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | Server { ip_addr: ip_addr.into(), port: port, protocol: Protocol::Udp, source: from, desc: None } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dns.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dns.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/summary.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | responses.into_iter().partition(|x| x.is_ok()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/txt_records.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn from_str(txt: &'a str) -> Result { [INFO] [stderr] 58 | | match parser::spf(txt.as_bytes()) { [INFO] [stderr] 59 | | IResult::Error(e) => Err(Error::with_chain(e, ErrorKind::SpfParsingFailed)), [INFO] [stderr] 60 | | IResult::Incomplete(_) => Err(Error::from_kind(ErrorKind::SpfParsingFailed)), [INFO] [stderr] 61 | | IResult::Done(_, spf) => Ok(spf) [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dns.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | Server { ip_addr: ip_addr.into(), port: port, protocol: Protocol::Udp, source: from, desc: None } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dns.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dns.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/summary.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | 1209600, [INFO] [stderr] | ^^^^^^^ help: consider: `1_209_600` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/summary.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | 1209600, [INFO] [stderr] | ^^^^^^^ help: consider: `1_209_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/summary.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | responses.into_iter().partition(|x| x.is_ok()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/txt_records.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn from_str(txt: &'a str) -> Result { [INFO] [stderr] 58 | | match parser::spf(txt.as_bytes()) { [INFO] [stderr] 59 | | IResult::Error(e) => Err(Error::with_chain(e, ErrorKind::SpfParsingFailed)), [INFO] [stderr] 60 | | IResult::Incomplete(_) => Err(Error::from_kind(ErrorKind::SpfParsingFailed)), [INFO] [stderr] 61 | | IResult::Done(_, spf) => Ok(spf) [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ungefiltert_surfen.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(servers.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!servers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `"docker" "inspect" "e69e65ae30e09cac9b330d9226320f2eb68c5c6b3f16c2d02dbbe2c9fe56cc73"` [INFO] running `"docker" "rm" "-f" "e69e65ae30e09cac9b330d9226320f2eb68c5c6b3f16c2d02dbbe2c9fe56cc73"` [INFO] [stdout] e69e65ae30e09cac9b330d9226320f2eb68c5c6b3f16c2d02dbbe2c9fe56cc73