[INFO] updating cached repository lukaspustina/luftpost [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lukaspustina/luftpost [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lukaspustina/luftpost" "work/ex/clippy-test-run/sources/stable/gh/lukaspustina/luftpost"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lukaspustina/luftpost'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lukaspustina/luftpost" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukaspustina/luftpost"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukaspustina/luftpost'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ba5f8145811dbb02834b81ef3a6f9cfbc8d21db [INFO] sha for GitHub repo lukaspustina/luftpost: 9ba5f8145811dbb02834b81ef3a6f9cfbc8d21db [INFO] validating manifest of lukaspustina/luftpost on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lukaspustina/luftpost on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lukaspustina/luftpost [INFO] finished frobbing lukaspustina/luftpost [INFO] frobbed toml for lukaspustina/luftpost written to work/ex/clippy-test-run/sources/stable/gh/lukaspustina/luftpost/Cargo.toml [INFO] started frobbing lukaspustina/luftpost [INFO] finished frobbing lukaspustina/luftpost [INFO] frobbed toml for lukaspustina/luftpost written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukaspustina/luftpost/Cargo.toml [INFO] crate lukaspustina/luftpost has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lukaspustina/luftpost against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lukaspustina/luftpost:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a197e08a405cf5400c01b032b04f41e49360151addd19a5983669ff838f47863 [INFO] running `"docker" "start" "-a" "a197e08a405cf5400c01b032b04f41e49360151addd19a5983669ff838f47863"` [INFO] [stderr] Compiling email v0.0.19 [INFO] [stderr] Checking tabwriter v1.0.4 [INFO] [stderr] Checking pretty_assertions v0.1.2 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking mktemp v0.3.1 [INFO] [stderr] Checking handlebars v0.27.0 [INFO] [stderr] Checking lettre v0.6.2 [INFO] [stderr] Checking luftpost v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | CheckedMeasurement { measurement: measurement, has_violations: !violations.is_empty(), violations: violations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `measurement` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:24:92 [INFO] [stderr] | [INFO] [stderr] 24 | CheckedMeasurement { measurement: measurement, has_violations: !violations.is_empty(), violations: violations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `violations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | sensor: sensor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sensor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | threshold_pm10: threshold_pm10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold_pm10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | threshold_pm2: threshold_pm2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold_pm2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | defaults: defaults, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `defaults` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | sensors: sensors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sensors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/mail.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | sensor: sensor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sensor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | measurement: measurement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `measurement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | sensor: sensor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sensor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | CheckedMeasurement { measurement: measurement, has_violations: !violations.is_empty(), violations: violations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `measurement` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:24:92 [INFO] [stderr] | [INFO] [stderr] 24 | CheckedMeasurement { measurement: measurement, has_violations: !violations.is_empty(), violations: violations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `violations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | sensor: sensor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sensor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | threshold_pm10: threshold_pm10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold_pm10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | threshold_pm2: threshold_pm2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold_pm2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | defaults: defaults, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `defaults` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | sensors: sensors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sensors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/mail.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | sensor: sensor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sensor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | measurement: measurement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `measurement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | sensor: sensor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sensor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/measurement.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | data_values: data_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/output.rs:5:58 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn print_measurements(measurements: &[&Measurement]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/check.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | fn check_measurement_okay() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/config.rs:164:39 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn config_from_min_str_okay() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/config.rs:182:39 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn config_from_max_str_okay() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/config.rs:264:43 [INFO] [stderr] | [INFO] [stderr] 264 | pub fn config_from_str_parser_error() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/config.rs:276:24 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn from_file() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/config.rs:285:32 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn from_minimal_file() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/config.rs:293:35 [INFO] [stderr] | [INFO] [stderr] 293 | pub fn from_file_not_exists() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/mail.rs:140:32 [INFO] [stderr] | [INFO] [stderr] 140 | fn mail_measurement_okay() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mail.rs:155:41 [INFO] [stderr] | [INFO] [stderr] 155 | data_values.push(Value::SAMPLES(739514f32)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `739_514f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | fn value_type_from_str_ok() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:121:38 [INFO] [stderr] | [INFO] [stderr] 121 | fn value_type_from_str_unknown() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | fn wire_to_measurement_ok() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/measurement.rs:174:41 [INFO] [stderr] | [INFO] [stderr] 174 | data_values.push(Value::SAMPLES(739514f32)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `739_514f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:190:49 [INFO] [stderr] | [INFO] [stderr] 190 | fn wire_to_measurement_unknown_value_type() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:211:44 [INFO] [stderr] | [INFO] [stderr] 211 | fn wire_to_measurement_invalid_value() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:272:44 [INFO] [stderr] | [INFO] [stderr] 272 | fn decode_json_to_measurement_ok() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/measurement.rs:319:54 [INFO] [stderr] | [INFO] [stderr] 319 | fn decode_json_to_measurement_invalid_json() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/output.rs:5:58 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn print_measurements(measurements: &[&Measurement]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/state.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn save_state_to_file_ok() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/state.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn load_from_file_ok() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/mail.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / error_chain!{ [INFO] [stderr] 13 | | errors { [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | foreign_links { [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:40:44 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn load>(sensor_id: &SensorId, state_dir: P) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | fn create_filepath>(sensor_id: &SensorId, state_dir: P) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/config.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(config.defaults.threshold_pm10.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/config.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(config.defaults.threshold_pm10.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/config.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(config.defaults.threshold_pm2.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/config.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(config.defaults.threshold_pm2.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/config.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | assert_eq!(s1.threshold_pm10.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/config.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | assert_eq!(s1.threshold_pm10.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/config.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(s1.threshold_pm2.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/config.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(s1.threshold_pm2.unwrap(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/config.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(s2.threshold_pm10.unwrap(), 20.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/config.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(s2.threshold_pm10.unwrap(), 20.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/config.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | assert_eq!(s2.threshold_pm2.unwrap(), 20.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/config.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | assert_eq!(s2.threshold_pm2.unwrap(), 20.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:296:40 [INFO] [stderr] | [INFO] [stderr] 296 | let config = Config::from_file(path.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/mail.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / error_chain!{ [INFO] [stderr] 13 | | errors { [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | foreign_links { [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:40:44 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn load>(sensor_id: &SensorId, state_dir: P) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/state.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | fn create_filepath>(sensor_id: &SensorId, state_dir: P) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `luftpost`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/sensor_it.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | fn read_measurement_local() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / error_chain! { [INFO] [stderr] 22 | | errors { [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | links { [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:129:91 [INFO] [stderr] | [INFO] [stderr] 129 | fn alarm_state_changed(sensor_states: Option<&HashMap>, sensor_id: &SensorId, has_violation: bool) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / error_chain! { [INFO] [stderr] 22 | | errors { [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | links { [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:129:91 [INFO] [stderr] | [INFO] [stderr] 129 | fn alarm_state_changed(sensor_states: Option<&HashMap>, sensor_id: &SensorId, has_violation: bool) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a197e08a405cf5400c01b032b04f41e49360151addd19a5983669ff838f47863"` [INFO] running `"docker" "rm" "-f" "a197e08a405cf5400c01b032b04f41e49360151addd19a5983669ff838f47863"` [INFO] [stdout] a197e08a405cf5400c01b032b04f41e49360151addd19a5983669ff838f47863