[INFO] updating cached repository luciusmagn/rustlang1
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/luciusmagn/rustlang1
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/luciusmagn/rustlang1" "work/ex/clippy-test-run/sources/stable/gh/luciusmagn/rustlang1"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luciusmagn/rustlang1'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/luciusmagn/rustlang1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/rustlang1"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/rustlang1'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] efc40f9495dc5ad7662165f655db6bd74b3d2859
[INFO] sha for GitHub repo luciusmagn/rustlang1: efc40f9495dc5ad7662165f655db6bd74b3d2859
[INFO] validating manifest of luciusmagn/rustlang1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of luciusmagn/rustlang1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing luciusmagn/rustlang1
[INFO] finished frobbing luciusmagn/rustlang1
[INFO] frobbed toml for luciusmagn/rustlang1 written to work/ex/clippy-test-run/sources/stable/gh/luciusmagn/rustlang1/Cargo.toml
[INFO] started frobbing luciusmagn/rustlang1
[INFO] finished frobbing luciusmagn/rustlang1
[INFO] frobbed toml for luciusmagn/rustlang1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/rustlang1/Cargo.toml
[INFO] crate luciusmagn/rustlang1 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting luciusmagn/rustlang1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luciusmagn/rustlang1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2400f1038a3c071bfe5fca82bd71519e46e30d1066c305deac1e65c2216d22da
[INFO] running `"docker" "start" "-a" "2400f1038a3c071bfe5fca82bd71519e46e30d1066c305deac1e65c2216d22da"`
[INFO] [stderr]     Checking rustlang1 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/examples/example1.rs:10:17
[INFO] [stderr]    |
[INFO] [stderr] 10 |     let age: i32 = 12345678;
[INFO] [stderr]    |                    ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/examples/example13.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |     sum
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/examples/example13.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let sum = v1.iter()
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 21 | |         .fold(
[INFO] [stderr] 22 | |             0, |mut sum, &x| {
[INFO] [stderr] 23 | |                 sum += x;
[INFO] [stderr] 24 | |                 sum
[INFO] [stderr] 25 | |             }
[INFO] [stderr] 26 | |         );
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/examples/example1.rs:10:17
[INFO] [stderr]    |
[INFO] [stderr] 10 |     let age: i32 = 12345678;
[INFO] [stderr]    |                    ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/examples/example13.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |     sum
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/examples/example13.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let sum = v1.iter()
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 21 | |         .fold(
[INFO] [stderr] 22 | |             0, |mut sum, &x| {
[INFO] [stderr] 23 | |                 sum += x;
[INFO] [stderr] 24 | |                 sum
[INFO] [stderr] 25 | |             }
[INFO] [stderr] 26 | |         );
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/examples/example3.rs:22:34
[INFO] [stderr]    |
[INFO] [stderr] 22 |     xprintln!("PI to Degrees = {}", 3.14f64.to_degrees());
[INFO] [stderr]    |                                     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/examples/example4.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let can_vote = if age_old >= 18 { true } else { false };
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `age_old >= 18`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/examples/example6.rs:13:2
[INFO] [stderr]    |
[INFO] [stderr] 13 |       loop
[INFO] [stderr]    |  _____^
[INFO] [stderr] 14 | |     {
[INFO] [stderr] 15 | |         match indiv_char
[INFO] [stderr] 16 | |         {
[INFO] [stderr] ...  |
[INFO] [stderr] 20 | |         indiv_char = chars.next();
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(x) = indiv_char { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/examples/example6.rs:26:2
[INFO] [stderr]    |
[INFO] [stderr] 26 |       loop
[INFO] [stderr]    |  _____^
[INFO] [stderr] 27 | |     {
[INFO] [stderr] 28 | |         match indiv_word
[INFO] [stderr] 29 | |         {
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         indiv_word = iter.next();
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(x) = indiv_word { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/examples/example6.rs:40:2
[INFO] [stderr]    |
[INFO] [stderr] 40 |       loop
[INFO] [stderr]    |  _____^
[INFO] [stderr] 41 | |     {
[INFO] [stderr] 42 | |         match indiv_line
[INFO] [stderr] 43 | |         {
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         indiv_line = lines.next();
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(x) = indiv_line { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]   --> src/examples/example7.rs:15:29
[INFO] [stderr]    |
[INFO] [stderr] 15 |               let guess: Option<i32> = input
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 16 | |                 .ok()
[INFO] [stderr] 17 | |                 .map_or(None, |_| line.trim().parse().ok());
[INFO] [stderr]    | |___________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] help: try using and_then instead
[INFO] [stderr]    |
[INFO] [stderr] 15 |             let guess: Option<i32> = input
[INFO] [stderr] 16 |                 .ok().and_then(|_| line.trim().parse().ok());
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/examples/example13.rs:18:18
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn sum_vects(v1: &Vec<i32>) -> i32
[INFO] [stderr]    |                  ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/examples/example14.rs:63:3
[INFO] [stderr]    |
[INFO] [stderr] 63 |         3.14159 * (self.radius) * (self.radius)
[INFO] [stderr]    |         ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustlang1`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/examples/example3.rs:22:34
[INFO] [stderr]    |
[INFO] [stderr] 22 |     xprintln!("PI to Degrees = {}", 3.14f64.to_degrees());
[INFO] [stderr]    |                                     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/examples/example4.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let can_vote = if age_old >= 18 { true } else { false };
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `age_old >= 18`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/examples/example6.rs:13:2
[INFO] [stderr]    |
[INFO] [stderr] 13 |       loop
[INFO] [stderr]    |  _____^
[INFO] [stderr] 14 | |     {
[INFO] [stderr] 15 | |         match indiv_char
[INFO] [stderr] 16 | |         {
[INFO] [stderr] ...  |
[INFO] [stderr] 20 | |         indiv_char = chars.next();
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(x) = indiv_char { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/examples/example6.rs:26:2
[INFO] [stderr]    |
[INFO] [stderr] 26 |       loop
[INFO] [stderr]    |  _____^
[INFO] [stderr] 27 | |     {
[INFO] [stderr] 28 | |         match indiv_word
[INFO] [stderr] 29 | |         {
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         indiv_word = iter.next();
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(x) = indiv_word { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/examples/example6.rs:40:2
[INFO] [stderr]    |
[INFO] [stderr] 40 |       loop
[INFO] [stderr]    |  _____^
[INFO] [stderr] 41 | |     {
[INFO] [stderr] 42 | |         match indiv_line
[INFO] [stderr] 43 | |         {
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         indiv_line = lines.next();
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(x) = indiv_line { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]   --> src/examples/example7.rs:15:29
[INFO] [stderr]    |
[INFO] [stderr] 15 |               let guess: Option<i32> = input
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 16 | |                 .ok()
[INFO] [stderr] 17 | |                 .map_or(None, |_| line.trim().parse().ok());
[INFO] [stderr]    | |___________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] help: try using and_then instead
[INFO] [stderr]    |
[INFO] [stderr] 15 |             let guess: Option<i32> = input
[INFO] [stderr] 16 |                 .ok().and_then(|_| line.trim().parse().ok());
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/examples/example13.rs:18:18
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn sum_vects(v1: &Vec<i32>) -> i32
[INFO] [stderr]    |                  ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/examples/example14.rs:63:3
[INFO] [stderr]    |
[INFO] [stderr] 63 |         3.14159 * (self.radius) * (self.radius)
[INFO] [stderr]    |         ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustlang1`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "2400f1038a3c071bfe5fca82bd71519e46e30d1066c305deac1e65c2216d22da"`
[INFO] running `"docker" "rm" "-f" "2400f1038a3c071bfe5fca82bd71519e46e30d1066c305deac1e65c2216d22da"`
[INFO] [stdout] 2400f1038a3c071bfe5fca82bd71519e46e30d1066c305deac1e65c2216d22da