[INFO] updating cached repository luciusmagn/markov [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luciusmagn/markov [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luciusmagn/markov" "work/ex/clippy-test-run/sources/stable/gh/luciusmagn/markov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luciusmagn/markov'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luciusmagn/markov" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/markov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/markov'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b9de6c11d4322b57eb674fb23b52e8aa154074d [INFO] sha for GitHub repo luciusmagn/markov: 1b9de6c11d4322b57eb674fb23b52e8aa154074d [INFO] validating manifest of luciusmagn/markov on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luciusmagn/markov on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luciusmagn/markov [INFO] finished frobbing luciusmagn/markov [INFO] frobbed toml for luciusmagn/markov written to work/ex/clippy-test-run/sources/stable/gh/luciusmagn/markov/Cargo.toml [INFO] started frobbing luciusmagn/markov [INFO] finished frobbing luciusmagn/markov [INFO] frobbed toml for luciusmagn/markov written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/markov/Cargo.toml [INFO] crate luciusmagn/markov has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luciusmagn/markov against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luciusmagn/markov:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69649575e8506144422363ea34addc8d2dbee57ba6798d4cfb66c1a2efc4ef20 [INFO] running `"docker" "start" "-a" "69649575e8506144422363ea34addc8d2dbee57ba6798d4cfb66c1a2efc4ef20"` [INFO] [stderr] Checking markov v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("something went wrong"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | loop [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | { [INFO] [stderr] 22 | | let word1 = match words.next() [INFO] [stderr] 23 | | { [INFO] [stderr] ... | [INFO] [stderr] 39 | | keys.push((word1, word2)) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = words.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | let mut third = transition.get(¤t).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&transition[¤t]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | transition.get(¤t).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&transition[¤t]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("something went wrong"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | loop [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | { [INFO] [stderr] 22 | | let word1 = match words.next() [INFO] [stderr] 23 | | { [INFO] [stderr] ... | [INFO] [stderr] 39 | | keys.push((word1, word2)) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = words.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | let mut third = transition.get(¤t).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&transition[¤t]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | transition.get(¤t).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&transition[¤t]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "69649575e8506144422363ea34addc8d2dbee57ba6798d4cfb66c1a2efc4ef20"` [INFO] running `"docker" "rm" "-f" "69649575e8506144422363ea34addc8d2dbee57ba6798d4cfb66c1a2efc4ef20"` [INFO] [stdout] 69649575e8506144422363ea34addc8d2dbee57ba6798d4cfb66c1a2efc4ef20