[INFO] updating cached repository luchoman08/best_pair_assignment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luchoman08/best_pair_assignment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luchoman08/best_pair_assignment" "work/ex/clippy-test-run/sources/stable/gh/luchoman08/best_pair_assignment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luchoman08/best_pair_assignment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luchoman08/best_pair_assignment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luchoman08/best_pair_assignment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luchoman08/best_pair_assignment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ed4d25b0f6a0707af53fca865dba779ab785c684 [INFO] sha for GitHub repo luchoman08/best_pair_assignment: ed4d25b0f6a0707af53fca865dba779ab785c684 [INFO] validating manifest of luchoman08/best_pair_assignment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luchoman08/best_pair_assignment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luchoman08/best_pair_assignment [INFO] finished frobbing luchoman08/best_pair_assignment [INFO] frobbed toml for luchoman08/best_pair_assignment written to work/ex/clippy-test-run/sources/stable/gh/luchoman08/best_pair_assignment/Cargo.toml [INFO] started frobbing luchoman08/best_pair_assignment [INFO] finished frobbing luchoman08/best_pair_assignment [INFO] frobbed toml for luchoman08/best_pair_assignment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luchoman08/best_pair_assignment/Cargo.toml [INFO] crate luchoman08/best_pair_assignment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luchoman08/best_pair_assignment against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luchoman08/best_pair_assignment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a5cb84edcbd3cce76d4bc5b028884bfcbf672c4be62d8231058697ae1c7b838 [INFO] running `"docker" "start" "-a" "7a5cb84edcbd3cce76d4bc5b028884bfcbf672c4be62d8231058697ae1c7b838"` [INFO] [stderr] Checking lp-modeler v0.3.1 [INFO] [stderr] Checking pair_assignment v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair_assignment.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | Agent {id: id, skills: skills} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair_assignment.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | Agent {id: id, skills: skills} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `skills` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair_assignment.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | Agent {id: id, skills: skills} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pair_assignment.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | Agent {id: id, skills: skills} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `skills` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `LpObjective`, `LpProblem` [INFO] [stderr] --> src/pair_assignment.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | use lp_modeler::problem::{LpObjective, LpProblem}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `LpOperations` [INFO] [stderr] --> src/pair_assignment.rs:3:30 [INFO] [stderr] | [INFO] [stderr] 3 | use lp_modeler::operations::{LpOperations}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `lp_modeler::variables::LpInteger` [INFO] [stderr] --> src/pair_assignment.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use lp_modeler::variables::LpInteger; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CbcSolver`, `SolverTrait` [INFO] [stderr] --> src/pair_assignment.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | use lp_modeler::solvers::{SolverTrait, CbcSolver}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `max`, `min` [INFO] [stderr] --> src/pair_assignment.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | use std::cmp::{max, min}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pair_assignment.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const DEFAULT_ID: u32 = 854554; [INFO] [stderr] | ^^^^^^ help: consider: `854_554` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pair_assignment.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return Ok(Agent::new(DEFAULT_ID, skills_media)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Agent::new(DEFAULT_ID, skills_media))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `LpObjective`, `LpProblem` [INFO] [stderr] --> src/pair_assignment.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | use lp_modeler::problem::{LpObjective, LpProblem}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `LpOperations` [INFO] [stderr] --> src/pair_assignment.rs:3:30 [INFO] [stderr] | [INFO] [stderr] 3 | use lp_modeler::operations::{LpOperations}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `lp_modeler::variables::LpInteger` [INFO] [stderr] --> src/pair_assignment.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use lp_modeler::variables::LpInteger; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `CbcSolver`, `SolverTrait` [INFO] [stderr] --> src/pair_assignment.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | use lp_modeler::solvers::{SolverTrait, CbcSolver}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `max`, `min` [INFO] [stderr] --> src/pair_assignment.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | use std::cmp::{max, min}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pair_assignment.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const DEFAULT_ID: u32 = 854554; [INFO] [stderr] | ^^^^^^ help: consider: `854_554` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pair_assignment.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return Ok(Agent::new(DEFAULT_ID, skills_media)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Agent::new(DEFAULT_ID, skills_media))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DEFAULT_SKILL_ID` [INFO] [stderr] --> src/pair_assignment.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DEFAULT_SKILL_ID: i8 = -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MINIMUM_SKILL_VALUE` [INFO] [stderr] --> src/pair_assignment.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub const MINIMUM_SKILL_VALUE: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/pair_assignment.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | id: u32, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_id` [INFO] [stderr] --> src/pair_assignment.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn get_id(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_little_skillfull_agent` [INFO] [stderr] --> src/pair_assignment.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn get_little_skillfull_agent(sample_skills: &Skills) -> Agent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pair_assignment.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | fn skill_average(agents: &Vec<&Agent>, id_skill: &u16) -> SkillValue { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[&Agent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pair_assignment.rs:48:54 [INFO] [stderr] | [INFO] [stderr] 48 | fn skill_average(agents: &Vec<&Agent>, id_skill: &u16) -> SkillValue { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pair_assignment.rs:55:39 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_standard_agent(agents: &Vec<&Agent>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[&Agent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pair_assignment.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | skills_media.insert(id_skill.clone() as u16, skill_media_punctuation / agent_quantity); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*id_skill` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pair_assignment.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | low_skills.insert(id_skill.clone(), MINIMUM_SKILL_VALUE as SkillValue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(MINIMUM_SKILL_VALUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DEFAULT_SKILL_ID` [INFO] [stderr] --> src/pair_assignment.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DEFAULT_SKILL_ID: i8 = -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MINIMUM_SKILL_VALUE` [INFO] [stderr] --> src/pair_assignment.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub const MINIMUM_SKILL_VALUE: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/pair_assignment.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | id: u32, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_id` [INFO] [stderr] --> src/pair_assignment.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn get_id(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_little_skillfull_agent` [INFO] [stderr] --> src/pair_assignment.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn get_little_skillfull_agent(sample_skills: &Skills) -> Agent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pair_assignment.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | fn skill_average(agents: &Vec<&Agent>, id_skill: &u16) -> SkillValue { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[&Agent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pair_assignment.rs:48:54 [INFO] [stderr] | [INFO] [stderr] 48 | fn skill_average(agents: &Vec<&Agent>, id_skill: &u16) -> SkillValue { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pair_assignment.rs:55:39 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_standard_agent(agents: &Vec<&Agent>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[&Agent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pair_assignment.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | skills_media.insert(id_skill.clone() as u16, skill_media_punctuation / agent_quantity); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*id_skill` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/pair_assignment.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | low_skills.insert(id_skill.clone(), MINIMUM_SKILL_VALUE as SkillValue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(MINIMUM_SKILL_VALUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.82s [INFO] running `"docker" "inspect" "7a5cb84edcbd3cce76d4bc5b028884bfcbf672c4be62d8231058697ae1c7b838"` [INFO] running `"docker" "rm" "-f" "7a5cb84edcbd3cce76d4bc5b028884bfcbf672c4be62d8231058697ae1c7b838"` [INFO] [stdout] 7a5cb84edcbd3cce76d4bc5b028884bfcbf672c4be62d8231058697ae1c7b838