[INFO] updating cached repository luben/repro-hyper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luben/repro-hyper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luben/repro-hyper" "work/ex/clippy-test-run/sources/stable/gh/luben/repro-hyper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luben/repro-hyper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luben/repro-hyper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luben/repro-hyper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luben/repro-hyper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7aae82ad6d806f86f9d542d5c324143edb8dec3c [INFO] sha for GitHub repo luben/repro-hyper: 7aae82ad6d806f86f9d542d5c324143edb8dec3c [INFO] validating manifest of luben/repro-hyper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luben/repro-hyper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luben/repro-hyper [INFO] finished frobbing luben/repro-hyper [INFO] frobbed toml for luben/repro-hyper written to work/ex/clippy-test-run/sources/stable/gh/luben/repro-hyper/Cargo.toml [INFO] started frobbing luben/repro-hyper [INFO] finished frobbing luben/repro-hyper [INFO] frobbed toml for luben/repro-hyper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luben/repro-hyper/Cargo.toml [INFO] crate luben/repro-hyper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luben/repro-hyper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/luben/repro-hyper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5ee75a8aada7672cb7681304894d8b31a326c73ad664c29cfa58bff5a61efcf [INFO] running `"docker" "start" "-a" "a5ee75a8aada7672cb7681304894d8b31a326c73ad664c29cfa58bff5a61efcf"` [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking broker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bin/broker.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | worker_queue: Rc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/broker.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | if let Ok(_) = send.send(resp) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 105 | | debug!("Sent id {:?}", id); [INFO] [stderr] 106 | | self.empty(StatusCode::ACCEPTED) [INFO] [stderr] 107 | | } else { [INFO] [stderr] 108 | | error!("Error sending id {:?}", id); [INFO] [stderr] 109 | | self.empty(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________- help: try this: `if send.send(resp).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/worker.rs:61:8 [INFO] [stderr] | [INFO] [stderr] 61 | Ok(rt::run(process)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 61 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bin/broker.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | worker_queue: Rc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/broker.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | if let Ok(_) = send.send(resp) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 105 | | debug!("Sent id {:?}", id); [INFO] [stderr] 106 | | self.empty(StatusCode::ACCEPTED) [INFO] [stderr] 107 | | } else { [INFO] [stderr] 108 | | error!("Error sending id {:?}", id); [INFO] [stderr] 109 | | self.empty(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________- help: try this: `if send.send(resp).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/worker-non-stream.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(rt::run(process)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 66 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/worker-non-stream.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(rt::run(process)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 66 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/worker.rs:61:8 [INFO] [stderr] | [INFO] [stderr] 61 | Ok(rt::run(process)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 61 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.93s [INFO] running `"docker" "inspect" "a5ee75a8aada7672cb7681304894d8b31a326c73ad664c29cfa58bff5a61efcf"` [INFO] running `"docker" "rm" "-f" "a5ee75a8aada7672cb7681304894d8b31a326c73ad664c29cfa58bff5a61efcf"` [INFO] [stdout] a5ee75a8aada7672cb7681304894d8b31a326c73ad664c29cfa58bff5a61efcf