[INFO] updating cached repository ltriant/advent-of-code-2017
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ltriant/advent-of-code-2017
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ltriant/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable/gh/ltriant/advent-of-code-2017"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ltriant/advent-of-code-2017'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ltriant/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ltriant/advent-of-code-2017"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ltriant/advent-of-code-2017'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f57c003f4ecc9f6758cd3a3551f8a9488d0f9306
[INFO] sha for GitHub repo ltriant/advent-of-code-2017: f57c003f4ecc9f6758cd3a3551f8a9488d0f9306
[INFO] validating manifest of ltriant/advent-of-code-2017 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ltriant/advent-of-code-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ltriant/advent-of-code-2017
[INFO] finished frobbing ltriant/advent-of-code-2017
[INFO] frobbed toml for ltriant/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable/gh/ltriant/advent-of-code-2017/Cargo.toml
[INFO] started frobbing ltriant/advent-of-code-2017
[INFO] finished frobbing ltriant/advent-of-code-2017
[INFO] frobbed toml for ltriant/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ltriant/advent-of-code-2017/Cargo.toml
[INFO] crate ltriant/advent-of-code-2017 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ltriant/advent-of-code-2017 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ltriant/advent-of-code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f3d75ecdd46742ed4d195d28676aef71870ce0cb04c4814883f5da05bea941bf
[INFO] running `"docker" "start" "-a" "f3d75ecdd46742ed4d195d28676aef71870ce0cb04c4814883f5da05bea941bf"`
[INFO] [stderr]     Checking advent-of-code-2017 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day3.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day3.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |         registers: registers,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registers`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         biggest_reg_val: biggest_reg_val,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `biggest_reg_val`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 |         reg: reg,
[INFO] [stderr]     |         ^^^^^^^^ help: replace it with: `reg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:144:9
[INFO] [stderr]     |
[INFO] [stderr] 144 |         cond: cond,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `cond`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/day16.rs:123:37
[INFO] [stderr]     |
[INFO] [stderr] 123 |                                 let d = n.to_digit(10).unwrap();
[INFO] [stderr]     |                                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/day19.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             n => {
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day20.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day21.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day21.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day22.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         map: map,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `map`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day22.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day22.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day24.rs:64:25
[INFO] [stderr]    |
[INFO] [stderr] 64 |                         children: children,
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day24.rs:72:17
[INFO] [stderr]    |
[INFO] [stderr] 72 |                 children: children,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day3.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day3.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |         registers: registers,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registers`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         biggest_reg_val: biggest_reg_val,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `biggest_reg_val`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 |         reg: reg,
[INFO] [stderr]     |         ^^^^^^^^ help: replace it with: `reg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day8.rs:144:9
[INFO] [stderr]     |
[INFO] [stderr] 144 |         cond: cond,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `cond`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/day16.rs:123:37
[INFO] [stderr]     |
[INFO] [stderr] 123 |                                 let d = n.to_digit(10).unwrap();
[INFO] [stderr]     |                                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/day19.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             n => {
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day20.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day21.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day21.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day22.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         map: map,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `map`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day22.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/day22.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day24.rs:64:25
[INFO] [stderr]    |
[INFO] [stderr] 64 |                         children: children,
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day24.rs:72:17
[INFO] [stderr]    |
[INFO] [stderr] 72 |                 children: children,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day1.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     return (0 .. len)
[INFO] [stderr] 37 | |         .filter( |&i| data[i] == data[(halfway+i)%len] )
[INFO] [stderr] 38 | |         .map(|i| data[i])
[INFO] [stderr] 39 | |         .sum();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 36 |     (0 .. len)
[INFO] [stderr] 37 |         .filter( |&i| data[i] == data[(halfway+i)%len] )
[INFO] [stderr] 38 |         .map(|i| data[i])
[INFO] [stderr] 39 |         .sum()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day1.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     return (0 .. len)
[INFO] [stderr] 49 | |         .filter( |&i| data[i] == data[(i+1)%len] )
[INFO] [stderr] 50 | |         .map(|i| data[i])
[INFO] [stderr] 51 | |         .sum();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 48 |     (0 .. len)
[INFO] [stderr] 49 |         .filter( |&i| data[i] == data[(i+1)%len] )
[INFO] [stderr] 50 |         .map(|i| data[i])
[INFO] [stderr] 51 |         .sum()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day2.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/day3.rs:4:17
[INFO] [stderr]   |
[INFO] [stderr] 4 |     let input = 289326;
[INFO] [stderr]   |                 ^^^^^^ help: consider: `289_326`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/day3.rs:134:10
[INFO] [stderr]     |
[INFO] [stderr] 134 |         (((spiral[0].len() / 2)) as f32).ceil() as usize 
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day3.rs:166:9
[INFO] [stderr]     |
[INFO] [stderr] 166 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day4.rs:546:5
[INFO] [stderr]     |
[INFO] [stderr] 546 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day4.rs:559:5
[INFO] [stderr]     |
[INFO] [stderr] 559 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day5.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 |     return steps;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day5.rs:140:5
[INFO] [stderr]     |
[INFO] [stderr] 140 |     return steps;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day7.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return rv;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `rv`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day7.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 |     return None;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day8.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 | /     return Environment {
[INFO] [stderr] 107 | |         registers: registers,
[INFO] [stderr] 108 | |         biggest_reg_val: biggest_reg_val,
[INFO] [stderr] 109 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 106 |     Environment {
[INFO] [stderr] 107 |         registers: registers,
[INFO] [stderr] 108 |         biggest_reg_val: biggest_reg_val,
[INFO] [stderr] 109 |     }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day8.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 | /     return Some( Instruction {
[INFO] [stderr] 151 | |         op: operation,
[INFO] [stderr] 152 | |         cond: condition,
[INFO] [stderr] 153 | |     } );
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 150 |     Some( Instruction {
[INFO] [stderr] 151 |         op: operation,
[INFO] [stderr] 152 |         cond: condition,
[INFO] [stderr] 153 |     } )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day9.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return (score, non_garbage_score);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(score, non_garbage_score)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day10.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return dense_hash.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dense_hash.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day10.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return data;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day11.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     return (
[INFO] [stderr] 54 | |         ((x.abs() + y.abs() + z.abs()) / 2) as u32,
[INFO] [stderr] 55 | |         max_dist as u32,
[INFO] [stderr] 56 | |     );
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |     (
[INFO] [stderr] 54 |         ((x.abs() + y.abs() + z.abs()) / 2) as u32,
[INFO] [stderr] 55 |         max_dist as u32,
[INFO] [stderr] 56 |     )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day12.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return subs;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `subs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day12.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return visited;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `visited`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day14.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return n;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day14.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return dense_hash.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dense_hash.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day14.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     return data;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:44:51
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 next_x = (next_x * gen_a.coeff) % 2147483647;
[INFO] [stderr]    |                                                   ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:51:47
[INFO] [stderr]    |
[INFO] [stderr] 51 |             next_x = (next_x * gen_a.coeff) % 2147483647;
[INFO] [stderr]    |                                               ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:56:51
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 next_y = (next_y * gen_b.coeff) % 2147483647;
[INFO] [stderr]    |                                                   ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:63:47
[INFO] [stderr]    |
[INFO] [stderr] 63 |             next_y = (next_y * gen_b.coeff) % 2147483647;
[INFO] [stderr]    |                                               ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day23.rs:149:33
[INFO] [stderr]     |
[INFO] [stderr] 149 |     let start: i64 = 84 * 100 + 100000;
[INFO] [stderr]     |                                 ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day1.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     return (0 .. len)
[INFO] [stderr] 37 | |         .filter( |&i| data[i] == data[(halfway+i)%len] )
[INFO] [stderr] 38 | |         .map(|i| data[i])
[INFO] [stderr] 39 | |         .sum();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 36 |     (0 .. len)
[INFO] [stderr] 37 |         .filter( |&i| data[i] == data[(halfway+i)%len] )
[INFO] [stderr] 38 |         .map(|i| data[i])
[INFO] [stderr] 39 |         .sum()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day1.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     return (0 .. len)
[INFO] [stderr] 49 | |         .filter( |&i| data[i] == data[(i+1)%len] )
[INFO] [stderr] 50 | |         .map(|i| data[i])
[INFO] [stderr] 51 | |         .sum();
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 48 |     (0 .. len)
[INFO] [stderr] 49 |         .filter( |&i| data[i] == data[(i+1)%len] )
[INFO] [stderr] 50 |         .map(|i| data[i])
[INFO] [stderr] 51 |         .sum()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day2.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/day3.rs:4:17
[INFO] [stderr]   |
[INFO] [stderr] 4 |     let input = 289326;
[INFO] [stderr]   |                 ^^^^^^ help: consider: `289_326`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/day3.rs:134:10
[INFO] [stderr]     |
[INFO] [stderr] 134 |         (((spiral[0].len() / 2)) as f32).ceil() as usize 
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day3.rs:166:9
[INFO] [stderr]     |
[INFO] [stderr] 166 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day3.rs:269:36
[INFO] [stderr]     |
[INFO] [stderr] 269 |         assert_eq!(spiral_distance(289326), 419);
[INFO] [stderr]     |                                    ^^^^^^ help: consider: `289_326`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day4.rs:546:5
[INFO] [stderr]     |
[INFO] [stderr] 546 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day4.rs:559:5
[INFO] [stderr]     |
[INFO] [stderr] 559 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day5.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 |     return steps;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day5.rs:140:5
[INFO] [stderr]     |
[INFO] [stderr] 140 |     return steps;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day7.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return rv;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `rv`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day7.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 |     return None;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day8.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 | /     return Environment {
[INFO] [stderr] 107 | |         registers: registers,
[INFO] [stderr] 108 | |         biggest_reg_val: biggest_reg_val,
[INFO] [stderr] 109 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 106 |     Environment {
[INFO] [stderr] 107 |         registers: registers,
[INFO] [stderr] 108 |         biggest_reg_val: biggest_reg_val,
[INFO] [stderr] 109 |     }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day8.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 | /     return Some( Instruction {
[INFO] [stderr] 151 | |         op: operation,
[INFO] [stderr] 152 | |         cond: condition,
[INFO] [stderr] 153 | |     } );
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 150 |     Some( Instruction {
[INFO] [stderr] 151 |         op: operation,
[INFO] [stderr] 152 |         cond: condition,
[INFO] [stderr] 153 |     } )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day9.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return (score, non_garbage_score);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(score, non_garbage_score)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day10.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return dense_hash.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dense_hash.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day10.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return data;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day11.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     return (
[INFO] [stderr] 54 | |         ((x.abs() + y.abs() + z.abs()) / 2) as u32,
[INFO] [stderr] 55 | |         max_dist as u32,
[INFO] [stderr] 56 | |     );
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 53 |     (
[INFO] [stderr] 54 |         ((x.abs() + y.abs() + z.abs()) / 2) as u32,
[INFO] [stderr] 55 |         max_dist as u32,
[INFO] [stderr] 56 |     )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day12.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return subs;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `subs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day12.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return visited;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `visited`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day14.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return n;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day14.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return dense_hash.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dense_hash.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day14.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     return data;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:44:51
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 next_x = (next_x * gen_a.coeff) % 2147483647;
[INFO] [stderr]    |                                                   ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:51:47
[INFO] [stderr]    |
[INFO] [stderr] 51 |             next_x = (next_x * gen_a.coeff) % 2147483647;
[INFO] [stderr]    |                                               ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:56:51
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 next_y = (next_y * gen_b.coeff) % 2147483647;
[INFO] [stderr]    |                                                   ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day15.rs:63:47
[INFO] [stderr]    |
[INFO] [stderr] 63 |             next_y = (next_y * gen_b.coeff) % 2147483647;
[INFO] [stderr]    |                                               ^^^^^^^^^^ help: consider: `2_147_483_647`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day23.rs:149:33
[INFO] [stderr]     |
[INFO] [stderr] 149 |     let start: i64 = 84 * 100 + 100000;
[INFO] [stderr]     |                                 ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:29:23
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn captcha_ext(input: &String) -> u32 {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn captcha(input: &String) -> u32 {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn checksum_div(input: &String) -> u32 {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 | fn checksum(input: &String) -> u32 {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/day4.rs:531:36
[INFO] [stderr]     |
[INFO] [stderr] 531 | fn validate_password_ext(password: &String) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/day4.rs:549:32
[INFO] [stderr]     |
[INFO] [stderr] 549 | fn validate_password(password: &String) -> bool {
[INFO] [stderr]     |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day5.rs:113:33
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn steps_to_exit_maze_ext(maze: &Vec<i32>) -> u32 {
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn steps_to_exit_maze_ext(maze: &[i32]) -> u32 {
[INFO] [stderr]     |                                 ^^^^^^
[INFO] [stderr] help: change `maze.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 114 |     let mut new_maze = maze.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day5.rs:128:29
[INFO] [stderr]     |
[INFO] [stderr] 128 | fn steps_to_exit_maze(maze: &Vec<i32>) -> u32 {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 128 | fn steps_to_exit_maze(maze: &[i32]) -> u32 {
[INFO] [stderr]     |                             ^^^^^^
[INFO] [stderr] help: change `maze.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 129 |     let mut new_maze = maze.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6.rs:10:34
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn steps_for_reallocation(banks: &Vec<u32>) -> (u32, u32) {
[INFO] [stderr]    |                                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn steps_for_reallocation(banks: &[u32]) -> (u32, u32) {
[INFO] [stderr]    |                                  ^^^^^^
[INFO] [stderr] help: change `banks.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let mut new_banks = banks.to_owned();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]   --> src/day7.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |         let mut foo = x.split_whitespace();
[INFO] [stderr]    |                 ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/day7.rs:20:16
[INFO] [stderr]    |
[INFO] [stderr] 20 |           if let Some(_) = foo.next() {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 21 | |             while let Some(n) = foo.next() {
[INFO] [stderr] 22 | |                 let child_name = n.replace(",", "").to_string();
[INFO] [stderr] 23 | |                 child_set.insert(child_name.clone());
[INFO] [stderr] 24 | |                 children.push(child_name);
[INFO] [stderr] 25 | |             }
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________- help: try this: `if foo.next().is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/day7.rs:21:33
[INFO] [stderr]    |
[INFO] [stderr] 21 |             while let Some(n) = foo.next() {
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: try: `for n in foo { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day7.rs:60:68
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn find_unweighted<'a>(tree: &'a HashMap<String, Node>, node_name: &'a String) -> Option<&'a String> {
[INFO] [stderr]    |                                                                    ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day8.rs:63:25
[INFO] [stderr]    |
[INFO] [stderr] 63 | fn run_program(program: &Vec<Instruction>) -> Environment {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day10.rs:36:44
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn knot_hash_step(steps: u32, len: u32, v: &Vec<usize>) -> Vec<u32> {
[INFO] [stderr]    |                                            ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day10.rs:37:20
[INFO] [stderr]    |
[INFO] [stderr] 37 |     let mut data = (0 .. len + 1).collect::<Vec<u32>>();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: use: `(0..=len)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/day12.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 |         while let Some(adj) = i.next() {
[INFO] [stderr]    |                               ^^^^^^^^ help: try: `for adj in i { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day14.rs:105:44
[INFO] [stderr]     |
[INFO] [stderr] 105 | fn knot_hash_step(steps: u32, len: u32, v: &Vec<usize>) -> Vec<u32> {
[INFO] [stderr]     |                                            ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/day14.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let mut data = (0 .. len + 1).collect::<Vec<u32>>();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^ help: use: `(0..=len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `next_dancers` manually
[INFO] [stderr]    --> src/day16.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 | /                     let t = next_dancers[a_idx];
[INFO] [stderr] 147 | |                     next_dancers[a_idx] = next_dancers[b_idx];
[INFO] [stderr] 148 | |                     next_dancers[b_idx] = t;
[INFO] [stderr]     | |___________________________________________^ help: try: `next_dancers.swap(a_idx, b_idx)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/day16.rs:120:21
[INFO] [stderr]     |
[INFO] [stderr] 120 | /                     loop {
[INFO] [stderr] 121 | |                         match irev.next() {
[INFO] [stderr] 122 | |                             Some(n) => {
[INFO] [stderr] 123 | |                                 let d = n.to_digit(10).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 135 | |                         }
[INFO] [stderr] 136 | |                     }
[INFO] [stderr]     | |_____________________^ help: try: `while let Some(n) = irev.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `next_dancers` manually
[INFO] [stderr]    --> src/day16.rs:161:21
[INFO] [stderr]     |
[INFO] [stderr] 161 | /                     let t = next_dancers[a_idx];
[INFO] [stderr] 162 | |                     next_dancers[a_idx] = next_dancers[b_idx];
[INFO] [stderr] 163 | |                     next_dancers[b_idx] = t;
[INFO] [stderr]     | |___________________________________________^ help: try: `next_dancers.swap(a_idx, b_idx)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day16.rs:155:34
[INFO] [stderr]     |
[INFO] [stderr] 155 |                     let &a_idx = lookup.get(&a).unwrap();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup[&a]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day16.rs:156:34
[INFO] [stderr]     |
[INFO] [stderr] 156 |                     let &b_idx = lookup.get(&b).unwrap();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup[&b]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day18.rs:23:40
[INFO] [stderr]    |
[INFO] [stderr] 23 |             && channels.iter().all(|x| x.len() == 0 )
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/day20.rs:112:16
[INFO] [stderr]     |
[INFO] [stderr] 112 |         .split(",")
[INFO] [stderr]     |                ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn pretty_print(p: &Pattern) {
[INFO] [stderr]    |                    ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn n_on(p: &Pattern) -> usize {
[INFO] [stderr]    |            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day21.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |     s.split("/").map( |b| b.chars().collect() ).collect()
[INFO] [stderr]    |             ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 | fn transpose(p: &Pattern) -> Pattern {
[INFO] [stderr]    |                 ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `p`.
[INFO] [stderr]   --> src/day21.rs:57:18
[INFO] [stderr]    |
[INFO] [stderr] 57 |         for j in 0 .. p[i].len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 57 |         for <item> in p.iter().take(p[i].len()) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:66:12
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn flip(p: &Pattern) -> Pattern {
[INFO] [stderr]    |            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/day21.rs:148:34
[INFO] [stderr]     |
[INFO] [stderr] 148 |                         for k in 0 .. v[j].len() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^ help: try replacing the loop by: `rv[x_off+j][y_off..(v[j].len() + y_off)].clone_from_slice(&v[j][..])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day23.rs:32:36
[INFO] [stderr]    |
[INFO] [stderr] 32 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day23.rs:53:36
[INFO] [stderr]    |
[INFO] [stderr] 53 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day23.rs:86:36
[INFO] [stderr]    |
[INFO] [stderr] 86 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day23.rs:110:36
[INFO] [stderr]     |
[INFO] [stderr] 110 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day23.rs:129:36
[INFO] [stderr]     |
[INFO] [stderr] 129 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/day23.rs:152:30
[INFO] [stderr]     |
[INFO] [stderr] 152 |     let not_prime = |n: i64| (2 .. sqrt(n) + 1).any(|v| n % v == 0);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^ help: use: `(2..=sqrt(n))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day24.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |         .map(|line| line.split("/"))
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day24.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 | fn build_tree(magnets: &Vec<(u32, u32)>, anchor: u32) -> Vec<Node> {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, u32)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/day24.rs:51:34
[INFO] [stderr]    |
[INFO] [stderr] 51 |                       let subset = magnets.iter()
[INFO] [stderr]    |  __________________________________^
[INFO] [stderr] 52 | |                         .filter( |&&(x, y)|
[INFO] [stderr] 53 | |                                  (x, y) != child &&
[INFO] [stderr] 54 | |                                  (x, y) != *root)
[INFO] [stderr] 55 | |                         .map(|&x| x)
[INFO] [stderr]    | |____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 51 |                     let subset = magnets.iter()
[INFO] [stderr] 52 |                         .filter( |&&(x, y)|
[INFO] [stderr] 53 |                                  (x, y) != child &&
[INFO] [stderr] 54 |                                  (x, y) != *root).cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:29:23
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn captcha_ext(input: &String) -> u32 {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn captcha(input: &String) -> u32 {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn checksum_div(input: &String) -> u32 {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 | fn checksum(input: &String) -> u32 {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/day4.rs:531:36
[INFO] [stderr]     |
[INFO] [stderr] 531 | fn validate_password_ext(password: &String) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/day4.rs:549:32
[INFO] [stderr]     |
[INFO] [stderr] 549 | fn validate_password(password: &String) -> bool {
[INFO] [stderr]     |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day5.rs:113:33
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn steps_to_exit_maze_ext(maze: &Vec<i32>) -> u32 {
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn steps_to_exit_maze_ext(maze: &[i32]) -> u32 {
[INFO] [stderr]     |                                 ^^^^^^
[INFO] [stderr] help: change `maze.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 114 |     let mut new_maze = maze.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day5.rs:128:29
[INFO] [stderr]     |
[INFO] [stderr] 128 | fn steps_to_exit_maze(maze: &Vec<i32>) -> u32 {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 128 | fn steps_to_exit_maze(maze: &[i32]) -> u32 {
[INFO] [stderr]     |                             ^^^^^^
[INFO] [stderr] help: change `maze.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 129 |     let mut new_maze = maze.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6.rs:10:34
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn steps_for_reallocation(banks: &Vec<u32>) -> (u32, u32) {
[INFO] [stderr]    |                                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn steps_for_reallocation(banks: &[u32]) -> (u32, u32) {
[INFO] [stderr]    |                                  ^^^^^^
[INFO] [stderr] help: change `banks.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let mut new_banks = banks.to_owned();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]   --> src/day7.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |         let mut foo = x.split_whitespace();
[INFO] [stderr]    |                 ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/day7.rs:20:16
[INFO] [stderr]    |
[INFO] [stderr] 20 |           if let Some(_) = foo.next() {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 21 | |             while let Some(n) = foo.next() {
[INFO] [stderr] 22 | |                 let child_name = n.replace(",", "").to_string();
[INFO] [stderr] 23 | |                 child_set.insert(child_name.clone());
[INFO] [stderr] 24 | |                 children.push(child_name);
[INFO] [stderr] 25 | |             }
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________- help: try this: `if foo.next().is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/day7.rs:21:33
[INFO] [stderr]    |
[INFO] [stderr] 21 |             while let Some(n) = foo.next() {
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: try: `for n in foo { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day7.rs:60:68
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn find_unweighted<'a>(tree: &'a HashMap<String, Node>, node_name: &'a String) -> Option<&'a String> {
[INFO] [stderr]    |                                                                    ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day8.rs:63:25
[INFO] [stderr]    |
[INFO] [stderr] 63 | fn run_program(program: &Vec<Instruction>) -> Environment {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day10.rs:36:44
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn knot_hash_step(steps: u32, len: u32, v: &Vec<usize>) -> Vec<u32> {
[INFO] [stderr]    |                                            ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day10.rs:37:20
[INFO] [stderr]    |
[INFO] [stderr] 37 |     let mut data = (0 .. len + 1).collect::<Vec<u32>>();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: use: `(0..=len)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/day12.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 |         while let Some(adj) = i.next() {
[INFO] [stderr]    |                               ^^^^^^^^ help: try: `for adj in i { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day14.rs:105:44
[INFO] [stderr]     |
[INFO] [stderr] 105 | fn knot_hash_step(steps: u32, len: u32, v: &Vec<usize>) -> Vec<u32> {
[INFO] [stderr]     |                                            ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/day14.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let mut data = (0 .. len + 1).collect::<Vec<u32>>();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^ help: use: `(0..=len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `next_dancers` manually
[INFO] [stderr]    --> src/day16.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 | /                     let t = next_dancers[a_idx];
[INFO] [stderr] 147 | |                     next_dancers[a_idx] = next_dancers[b_idx];
[INFO] [stderr] 148 | |                     next_dancers[b_idx] = t;
[INFO] [stderr]     | |___________________________________________^ help: try: `next_dancers.swap(a_idx, b_idx)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/day16.rs:120:21
[INFO] [stderr]     |
[INFO] [stderr] 120 | /                     loop {
[INFO] [stderr] 121 | |                         match irev.next() {
[INFO] [stderr] 122 | |                             Some(n) => {
[INFO] [stderr] 123 | |                                 let d = n.to_digit(10).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 135 | |                         }
[INFO] [stderr] 136 | |                     }
[INFO] [stderr]     | |_____________________^ help: try: `while let Some(n) = irev.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `next_dancers` manually
[INFO] [stderr]    --> src/day16.rs:161:21
[INFO] [stderr]     |
[INFO] [stderr] 161 | /                     let t = next_dancers[a_idx];
[INFO] [stderr] 162 | |                     next_dancers[a_idx] = next_dancers[b_idx];
[INFO] [stderr] 163 | |                     next_dancers[b_idx] = t;
[INFO] [stderr]     | |___________________________________________^ help: try: `next_dancers.swap(a_idx, b_idx)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day16.rs:155:34
[INFO] [stderr]     |
[INFO] [stderr] 155 |                     let &a_idx = lookup.get(&a).unwrap();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup[&a]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day16.rs:156:34
[INFO] [stderr]     |
[INFO] [stderr] 156 |                     let &b_idx = lookup.get(&b).unwrap();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup[&b]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day18.rs:23:40
[INFO] [stderr]    |
[INFO] [stderr] 23 |             && channels.iter().all(|x| x.len() == 0 )
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/day20.rs:112:16
[INFO] [stderr]     |
[INFO] [stderr] 112 |         .split(",")
[INFO] [stderr]     |                ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn pretty_print(p: &Pattern) {
[INFO] [stderr]    |                    ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:43:12
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn n_on(p: &Pattern) -> usize {
[INFO] [stderr]    |            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day21.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |     s.split("/").map( |b| b.chars().collect() ).collect()
[INFO] [stderr]    |             ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 | fn transpose(p: &Pattern) -> Pattern {
[INFO] [stderr]    |                 ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `p`.
[INFO] [stderr]   --> src/day21.rs:57:18
[INFO] [stderr]    |
[INFO] [stderr] 57 |         for j in 0 .. p[i].len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 57 |         for <item> in p.iter().take(p[i].len()) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day21.rs:66:12
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn flip(p: &Pattern) -> Pattern {
[INFO] [stderr]    |            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/day21.rs:148:34
[INFO] [stderr]     |
[INFO] [stderr] 148 |                         for k in 0 .. v[j].len() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^ help: try replacing the loop by: `rv[x_off+j][y_off..(v[j].len() + y_off)].clone_from_slice(&v[j][..])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day23.rs:32:36
[INFO] [stderr]    |
[INFO] [stderr] 32 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day23.rs:53:36
[INFO] [stderr]    |
[INFO] [stderr] 53 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day23.rs:86:36
[INFO] [stderr]    |
[INFO] [stderr] 86 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day23.rs:110:36
[INFO] [stderr]     |
[INFO] [stderr] 110 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day23.rs:129:36
[INFO] [stderr]     |
[INFO] [stderr] 129 |                         let val = *regs.get(&val_reg).unwrap();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&regs[&val_reg]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/day23.rs:152:30
[INFO] [stderr]     |
[INFO] [stderr] 152 |     let not_prime = |n: i64| (2 .. sqrt(n) + 1).any(|v| n % v == 0);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^ help: use: `(2..=sqrt(n))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day24.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |         .map(|line| line.split("/"))
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day24.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 | fn build_tree(magnets: &Vec<(u32, u32)>, anchor: u32) -> Vec<Node> {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, u32)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/day24.rs:51:34
[INFO] [stderr]    |
[INFO] [stderr] 51 |                       let subset = magnets.iter()
[INFO] [stderr]    |  __________________________________^
[INFO] [stderr] 52 | |                         .filter( |&&(x, y)|
[INFO] [stderr] 53 | |                                  (x, y) != child &&
[INFO] [stderr] 54 | |                                  (x, y) != *root)
[INFO] [stderr] 55 | |                         .map(|&x| x)
[INFO] [stderr]    | |____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 51 |                     let subset = magnets.iter()
[INFO] [stderr] 52 |                         .filter( |&&(x, y)|
[INFO] [stderr] 53 |                                  (x, y) != child &&
[INFO] [stderr] 54 |                                  (x, y) != *root).cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.95s
[INFO] running `"docker" "inspect" "f3d75ecdd46742ed4d195d28676aef71870ce0cb04c4814883f5da05bea941bf"`
[INFO] running `"docker" "rm" "-f" "f3d75ecdd46742ed4d195d28676aef71870ce0cb04c4814883f5da05bea941bf"`
[INFO] [stdout] f3d75ecdd46742ed4d195d28676aef71870ce0cb04c4814883f5da05bea941bf