[INFO] updating cached repository lshlyapnikov/grokking-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lshlyapnikov/grokking-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lshlyapnikov/grokking-rust" "work/ex/clippy-test-run/sources/stable/gh/lshlyapnikov/grokking-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lshlyapnikov/grokking-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lshlyapnikov/grokking-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lshlyapnikov/grokking-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lshlyapnikov/grokking-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32a6326f7d1443ec01c0a022a8bf14d260729d80 [INFO] sha for GitHub repo lshlyapnikov/grokking-rust: 32a6326f7d1443ec01c0a022a8bf14d260729d80 [INFO] validating manifest of lshlyapnikov/grokking-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lshlyapnikov/grokking-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lshlyapnikov/grokking-rust [INFO] finished frobbing lshlyapnikov/grokking-rust [INFO] frobbed toml for lshlyapnikov/grokking-rust written to work/ex/clippy-test-run/sources/stable/gh/lshlyapnikov/grokking-rust/Cargo.toml [INFO] started frobbing lshlyapnikov/grokking-rust [INFO] finished frobbing lshlyapnikov/grokking-rust [INFO] frobbed toml for lshlyapnikov/grokking-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lshlyapnikov/grokking-rust/Cargo.toml [INFO] crate lshlyapnikov/grokking-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lshlyapnikov/grokking-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lshlyapnikov/grokking-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31ff6d960b9cb56b72887365bc41937cdb40b9f301688271d68dc56dfa487034 [INFO] running `"docker" "start" "-a" "31ff6d960b9cb56b72887365bc41937cdb40b9f301688271d68dc56dfa487034"` [INFO] [stderr] Checking libc v0.2.6 [INFO] [stderr] Checking regex-syntax v0.2.2 [INFO] [stderr] Compiling advapi32-sys v0.1.2 [INFO] [stderr] Checking memchr v0.1.7 [INFO] [stderr] Checking log v0.3.5 [INFO] [stderr] Checking rand v0.3.13 [INFO] [stderr] Checking aho-corasick v0.4.1 [INFO] [stderr] Checking regex v0.1.48 [INFO] [stderr] Checking env_logger v0.3.2 [INFO] [stderr] Checking quickcheck v0.2.25 [INFO] [stderr] Checking grokking-rust v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `volumes` [INFO] [stderr] --> src/grok/waterpouring.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | let volumes: Vec = vec![0, max_volumes.len()]; [INFO] [stderr] | ^^^^^^^ help: consider using `_volumes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `required_volume` [INFO] [stderr] --> src/grok/waterpouring.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn solve(max_volumes: &Vec, required_volume: usize) -> State { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_required_volume` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Fill` [INFO] [stderr] --> src/grok/waterpouring.rs:5:3 [INFO] [stderr] | [INFO] [stderr] 5 | Fill { glass: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Empty` [INFO] [stderr] --> src/grok/waterpouring.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | Empty { glass: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Transfer` [INFO] [stderr] --> src/grok/waterpouring.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | Transfer { from: usize, to: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/grok/waterpouring.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn solve(max_volumes: &Vec, required_volume: usize) -> State { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/mergesort.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn sort(xs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/mergesort.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | fn merge_sort_vectors(xs: &Vec, ys: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/mergesort.rs:18:63 [INFO] [stderr] | [INFO] [stderr] 18 | fn merge_sort_vectors(xs: &Vec, ys: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/quicksort.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn sort(xs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/waterpouring.rs:17:52 [INFO] [stderr] | [INFO] [stderr] 17 | fn change(&self, action: &Action, glass_volumes: &Vec) -> State; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/grok/waterpouring.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | new_glasses[from] = new_glasses[from] - change; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_glasses[from] -= change` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/grok/waterpouring.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | new_glasses[to] = new_glasses[to] + change; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_glasses[to] += change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/waterpouring.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn solve(max_volumes: &Vec, required_volume: usize) -> State { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:34:66 [INFO] [stderr] | [INFO] [stderr] 34 | fn test_sort_function(sut: F, input: &Vec) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `volumes` [INFO] [stderr] --> src/grok/waterpouring.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | let volumes: Vec = vec![0, max_volumes.len()]; [INFO] [stderr] | ^^^^^^^ help: consider using `_volumes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `required_volume` [INFO] [stderr] --> src/grok/waterpouring.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn solve(max_volumes: &Vec, required_volume: usize) -> State { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_required_volume` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Fill` [INFO] [stderr] --> src/grok/waterpouring.rs:5:3 [INFO] [stderr] | [INFO] [stderr] 5 | Fill { glass: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Empty` [INFO] [stderr] --> src/grok/waterpouring.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | Empty { glass: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Transfer` [INFO] [stderr] --> src/grok/waterpouring.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | Transfer { from: usize, to: usize }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/grok/waterpouring.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn solve(max_volumes: &Vec, required_volume: usize) -> State { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/mergesort.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn sort(xs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/mergesort.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | fn merge_sort_vectors(xs: &Vec, ys: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/mergesort.rs:18:63 [INFO] [stderr] | [INFO] [stderr] 18 | fn merge_sort_vectors(xs: &Vec, ys: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/quicksort.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn sort(xs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/waterpouring.rs:17:52 [INFO] [stderr] | [INFO] [stderr] 17 | fn change(&self, action: &Action, glass_volumes: &Vec) -> State; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/grok/waterpouring.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | new_glasses[from] = new_glasses[from] - change; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_glasses[from] -= change` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/grok/waterpouring.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | new_glasses[to] = new_glasses[to] + change; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_glasses[to] += change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grok/waterpouring.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn solve(max_volumes: &Vec, required_volume: usize) -> State { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:34:66 [INFO] [stderr] | [INFO] [stderr] 34 | fn test_sort_function(sut: F, input: &Vec) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.64s [INFO] running `"docker" "inspect" "31ff6d960b9cb56b72887365bc41937cdb40b9f301688271d68dc56dfa487034"` [INFO] running `"docker" "rm" "-f" "31ff6d960b9cb56b72887365bc41937cdb40b9f301688271d68dc56dfa487034"` [INFO] [stdout] 31ff6d960b9cb56b72887365bc41937cdb40b9f301688271d68dc56dfa487034