[INFO] updating cached repository lrssnn/HockeyStat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lrssnn/HockeyStat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lrssnn/HockeyStat" "work/ex/clippy-test-run/sources/stable/gh/lrssnn/HockeyStat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lrssnn/HockeyStat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lrssnn/HockeyStat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lrssnn/HockeyStat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lrssnn/HockeyStat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f338b55cf59f3ffd7b139f5e38da177e765fee53 [INFO] sha for GitHub repo lrssnn/HockeyStat: f338b55cf59f3ffd7b139f5e38da177e765fee53 [INFO] validating manifest of lrssnn/HockeyStat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lrssnn/HockeyStat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lrssnn/HockeyStat [INFO] finished frobbing lrssnn/HockeyStat [INFO] frobbed toml for lrssnn/HockeyStat written to work/ex/clippy-test-run/sources/stable/gh/lrssnn/HockeyStat/Cargo.toml [INFO] started frobbing lrssnn/HockeyStat [INFO] finished frobbing lrssnn/HockeyStat [INFO] frobbed toml for lrssnn/HockeyStat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lrssnn/HockeyStat/Cargo.toml [INFO] crate lrssnn/HockeyStat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lrssnn/HockeyStat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lrssnn/HockeyStat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32f80741450c39179bf71d6498b00fbf443518a0fe09fefb9f0184eec8f92abd [INFO] running `"docker" "start" "-a" "32f80741450c39179bf71d6498b00fbf443518a0fe09fefb9f0184eec8f92abd"` [INFO] [stderr] Compiling cc v1.0.6 [INFO] [stderr] Checking serde v1.0.29 [INFO] [stderr] Checking svg v0.5.10 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking socket2 v0.3.3 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling serde_derive_internals v0.20.0 [INFO] [stderr] Checking plotlib v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.30 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking serde_json v1.0.11 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking curl v0.4.11 [INFO] [stderr] Checking HockeyStat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `plotlib::style::Line` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use plotlib::style::Line; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `date` [INFO] [stderr] --> src/main.rs:95:79 [INFO] [stderr] | [INFO] [stderr] 95 | fn update_team(teams: &mut HashMap, team: &ApiTeamResult, date: &String) { [INFO] [stderr] | ^^^^ help: consider using `_date` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `plotlib::style::Line` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use plotlib::style::Line; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `HockeyStat` should have a snake case name such as `hockey_stat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | file.write_all(format!("{}\n", team).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | file.write_all(format!(",{}", score).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | file.write_all(format!("\n").as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | file.write_all(format!("\n").as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:66:79 [INFO] [stderr] | [INFO] [stderr] 66 | fn ingest_game(teams: &mut HashMap, game: &ApiGame, date: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:95:85 [INFO] [stderr] | [INFO] [stderr] 95 | fn update_team(teams: &mut HashMap, team: &ApiTeamResult, date: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `date` [INFO] [stderr] --> src/main.rs:95:79 [INFO] [stderr] | [INFO] [stderr] 95 | fn update_team(teams: &mut HashMap, team: &ApiTeamResult, date: &String) { [INFO] [stderr] | ^^^^ help: consider using `_date` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `HockeyStat` should have a snake case name such as `hockey_stat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | file.write_all(format!("{}\n", team).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | file.write_all(format!(",{}", score).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | file.write_all(format!("\n").as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | file.write_all(format!("\n").as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:66:79 [INFO] [stderr] | [INFO] [stderr] 66 | fn ingest_game(teams: &mut HashMap, game: &ApiGame, date: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:95:85 [INFO] [stderr] | [INFO] [stderr] 95 | fn update_team(teams: &mut HashMap, team: &ApiTeamResult, date: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 46s [INFO] running `"docker" "inspect" "32f80741450c39179bf71d6498b00fbf443518a0fe09fefb9f0184eec8f92abd"` [INFO] running `"docker" "rm" "-f" "32f80741450c39179bf71d6498b00fbf443518a0fe09fefb9f0184eec8f92abd"` [INFO] [stdout] 32f80741450c39179bf71d6498b00fbf443518a0fe09fefb9f0184eec8f92abd