[INFO] updating cached repository lpil/sonic-pi-tool
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lpil/sonic-pi-tool
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lpil/sonic-pi-tool" "work/ex/clippy-test-run/sources/stable/gh/lpil/sonic-pi-tool"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lpil/sonic-pi-tool'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lpil/sonic-pi-tool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lpil/sonic-pi-tool"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lpil/sonic-pi-tool'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 35e355dd85693ee0dc63ac8e00aa13311b24e1fd
[INFO] sha for GitHub repo lpil/sonic-pi-tool: 35e355dd85693ee0dc63ac8e00aa13311b24e1fd
[INFO] validating manifest of lpil/sonic-pi-tool on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lpil/sonic-pi-tool on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lpil/sonic-pi-tool
[INFO] finished frobbing lpil/sonic-pi-tool
[INFO] frobbed toml for lpil/sonic-pi-tool written to work/ex/clippy-test-run/sources/stable/gh/lpil/sonic-pi-tool/Cargo.toml
[INFO] started frobbing lpil/sonic-pi-tool
[INFO] finished frobbing lpil/sonic-pi-tool
[INFO] frobbed toml for lpil/sonic-pi-tool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lpil/sonic-pi-tool/Cargo.toml
[INFO] crate lpil/sonic-pi-tool has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lpil/sonic-pi-tool against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lpil/sonic-pi-tool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7decf23df050567d591c8b3f8ebe47d2872cd6168a006eedacac774c25b85be7
[INFO] running `"docker" "start" "-a" "7decf23df050567d591c8b3f8ebe47d2872cd6168a006eedacac774c25b85be7"`
[INFO] [stderr]     Checking clap v2.20.0
[INFO] [stderr]     Checking nix v0.7.0
[INFO] [stderr]     Checking sonic-pi-tool v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/log_packet.rs:123:13
[INFO] [stderr]     |
[INFO] [stderr] 123 |             job_id: job_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `job_id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/log_packet.rs:126:13
[INFO] [stderr]     |
[INFO] [stderr] 126 |             messages: messages,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/log_packet.rs:123:13
[INFO] [stderr]     |
[INFO] [stderr] 123 |             job_id: job_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `job_id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/log_packet.rs:126:13
[INFO] [stderr]     |
[INFO] [stderr] 126 |             messages: messages,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:99:35
[INFO] [stderr]    |
[INFO] [stderr] 99 |     if let Some(home_directory) = env::home_dir() {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:99:35
[INFO] [stderr]    |
[INFO] [stderr] 99 |     if let Some(home_directory) = env::home_dir() {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/server.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     match UdpSocket::bind("127.0.0.1:4557") {
[INFO] [stderr] 16 | |         Ok(_) => false,
[INFO] [stderr] 17 | |         Err(_) => true,
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^ help: try this: `UdpSocket::bind("127.0.0.1:4557").is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/lib.rs:109:29
[INFO] [stderr]     |
[INFO] [stderr] 109 |             execv(cmd, &[]).expect(&format!("Unable to start {}", *p))
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to start {}", *p))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/server.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     match UdpSocket::bind("127.0.0.1:4557") {
[INFO] [stderr] 16 | |         Ok(_) => false,
[INFO] [stderr] 17 | |         Err(_) => true,
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^ help: try this: `UdpSocket::bind("127.0.0.1:4557").is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/lib.rs:109:29
[INFO] [stderr]     |
[INFO] [stderr] 109 |             execv(cmd, &[]).expect(&format!("Unable to start {}", *p))
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to start {}", *p))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.38s
[INFO] running `"docker" "inspect" "7decf23df050567d591c8b3f8ebe47d2872cd6168a006eedacac774c25b85be7"`
[INFO] running `"docker" "rm" "-f" "7decf23df050567d591c8b3f8ebe47d2872cd6168a006eedacac774c25b85be7"`
[INFO] [stdout] 7decf23df050567d591c8b3f8ebe47d2872cd6168a006eedacac774c25b85be7