[INFO] updating cached repository lostintime/aws-s3-webdav [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lostintime/aws-s3-webdav [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lostintime/aws-s3-webdav" "work/ex/clippy-test-run/sources/stable/gh/lostintime/aws-s3-webdav"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lostintime/aws-s3-webdav'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lostintime/aws-s3-webdav" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lostintime/aws-s3-webdav"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lostintime/aws-s3-webdav'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c7daea24449bee5c806340131dec86d5d42af221 [INFO] sha for GitHub repo lostintime/aws-s3-webdav: c7daea24449bee5c806340131dec86d5d42af221 [INFO] validating manifest of lostintime/aws-s3-webdav on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lostintime/aws-s3-webdav on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lostintime/aws-s3-webdav [INFO] finished frobbing lostintime/aws-s3-webdav [INFO] frobbed toml for lostintime/aws-s3-webdav written to work/ex/clippy-test-run/sources/stable/gh/lostintime/aws-s3-webdav/Cargo.toml [INFO] started frobbing lostintime/aws-s3-webdav [INFO] finished frobbing lostintime/aws-s3-webdav [INFO] frobbed toml for lostintime/aws-s3-webdav written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lostintime/aws-s3-webdav/Cargo.toml [INFO] crate lostintime/aws-s3-webdav has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lostintime/aws-s3-webdav against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lostintime/aws-s3-webdav:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 853316905ee487c78810c636bbc689477822319ac8bc98c5c7afc95892163260 [INFO] running `"docker" "start" "-a" "853316905ee487c78810c636bbc689477822319ac8bc98c5c7afc95892163260"` [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking rusoto_credential v0.13.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking rusoto_core v0.34.0 [INFO] [stderr] Checking actix v0.7.4 [INFO] [stderr] Checking rusoto_s3 v0.34.0 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking actix-web v0.7.8 [INFO] [stderr] Checking rusoto_credential v0.11.0 [INFO] [stderr] Checking aws_s3_webdav v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/routes.rs:300:53 [INFO] [stderr] | [INFO] [stderr] 300 | bucket: bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/routes.rs:301:53 [INFO] [stderr] | [INFO] [stderr] 301 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/routes.rs:451:21 [INFO] [stderr] | [INFO] [stderr] 451 | bucket: bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/routes.rs:300:53 [INFO] [stderr] | [INFO] [stderr] 300 | bucket: bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/routes.rs:301:53 [INFO] [stderr] | [INFO] [stderr] 301 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/routes.rs:451:21 [INFO] [stderr] | [INFO] [stderr] 451 | bucket: bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/routes.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / return Box::new( [INFO] [stderr] 267 | | state [INFO] [stderr] 268 | | .s3 [INFO] [stderr] 269 | | .create_multipart_upload(CreateMultipartUploadRequest { [INFO] [stderr] ... | [INFO] [stderr] 371 | | .map(|_| HttpResponse::Ok().finish()), [INFO] [stderr] 372 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 266 | Box::new( [INFO] [stderr] 267 | state [INFO] [stderr] 268 | .s3 [INFO] [stderr] 269 | .create_multipart_upload(CreateMultipartUploadRequest { [INFO] [stderr] 270 | bucket: bucket.to_owned(), [INFO] [stderr] 271 | key: key.to_owned(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return S3Config { [INFO] [stderr] 27 | | bucket: bucket.into(), [INFO] [stderr] 28 | | prefix: prefix.map(|p| p.into()), [INFO] [stderr] 29 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | S3Config { [INFO] [stderr] 27 | bucket: bucket.into(), [INFO] [stderr] 28 | prefix: prefix.map(|p| p.into()), [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/routes.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / return Box::new( [INFO] [stderr] 267 | | state [INFO] [stderr] 268 | | .s3 [INFO] [stderr] 269 | | .create_multipart_upload(CreateMultipartUploadRequest { [INFO] [stderr] ... | [INFO] [stderr] 371 | | .map(|_| HttpResponse::Ok().finish()), [INFO] [stderr] 372 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 266 | Box::new( [INFO] [stderr] 267 | state [INFO] [stderr] 268 | .s3 [INFO] [stderr] 269 | .create_multipart_upload(CreateMultipartUploadRequest { [INFO] [stderr] 270 | bucket: bucket.to_owned(), [INFO] [stderr] 271 | key: key.to_owned(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return S3Config { [INFO] [stderr] 27 | | bucket: bucket.into(), [INFO] [stderr] 28 | | prefix: prefix.map(|p| p.into()), [INFO] [stderr] 29 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | S3Config { [INFO] [stderr] 27 | bucket: bucket.into(), [INFO] [stderr] 28 | prefix: prefix.map(|p| p.into()), [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/routes.rs:20:82 [INFO] [stderr] | [INFO] [stderr] 20 | Some(ref prefix) => format!("{}{}", prefix, req.path().trim_left_matches("/")), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/routes.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | None => req.path().trim_left_matches("/").to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/routes.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | .map_err(|e| ErrorInternalServerError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorInternalServerError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/routes.rs:290:29 [INFO] [stderr] | [INFO] [stderr] 290 | / let c: Box>; [INFO] [stderr] 291 | | [INFO] [stderr] 292 | | if parts.is_empty() { [INFO] [stderr] 293 | | // no parts upload - file is empty [INFO] [stderr] ... | [INFO] [stderr] 346 | | ); [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 290 | let c = if parts.is_empty() { Box::new( [INFO] [stderr] 291 | abort_upload(&state, &upload) [INFO] [stderr] 292 | .then(move |_| { [INFO] [stderr] 293 | state [INFO] [stderr] 294 | .s3 [INFO] [stderr] 295 | .put_object(PutObjectRequest { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/routes.rs:404:51 [INFO] [stderr] | [INFO] [stderr] 404 | Ok(dest) => Ok(dest.trim_left_matches("/").to_owned()), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/routes.rs:20:82 [INFO] [stderr] | [INFO] [stderr] 20 | Some(ref prefix) => format!("{}{}", prefix, req.path().trim_left_matches("/")), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/routes.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | None => req.path().trim_left_matches("/").to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:117:10 [INFO] [stderr] | [INFO] [stderr] 117 | .expect(&format!("Cannot bind to {}", &bind_port)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &bind_port))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/routes.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | .map_err(|e| ErrorInternalServerError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorInternalServerError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/routes.rs:290:29 [INFO] [stderr] | [INFO] [stderr] 290 | / let c: Box>; [INFO] [stderr] 291 | | [INFO] [stderr] 292 | | if parts.is_empty() { [INFO] [stderr] 293 | | // no parts upload - file is empty [INFO] [stderr] ... | [INFO] [stderr] 346 | | ); [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 290 | let c = if parts.is_empty() { Box::new( [INFO] [stderr] 291 | abort_upload(&state, &upload) [INFO] [stderr] 292 | .then(move |_| { [INFO] [stderr] 293 | state [INFO] [stderr] 294 | .s3 [INFO] [stderr] 295 | .put_object(PutObjectRequest { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/routes.rs:404:51 [INFO] [stderr] | [INFO] [stderr] 404 | Ok(dest) => Ok(dest.trim_left_matches("/").to_owned()), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:117:10 [INFO] [stderr] | [INFO] [stderr] 117 | .expect(&format!("Cannot bind to {}", &bind_port)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &bind_port))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.49s [INFO] running `"docker" "inspect" "853316905ee487c78810c636bbc689477822319ac8bc98c5c7afc95892163260"` [INFO] running `"docker" "rm" "-f" "853316905ee487c78810c636bbc689477822319ac8bc98c5c7afc95892163260"` [INFO] [stdout] 853316905ee487c78810c636bbc689477822319ac8bc98c5c7afc95892163260