[INFO] updating cached repository lordarthas/undergarden [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lordarthas/undergarden [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lordarthas/undergarden" "work/ex/clippy-test-run/sources/stable/gh/lordarthas/undergarden"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lordarthas/undergarden'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lordarthas/undergarden" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lordarthas/undergarden"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lordarthas/undergarden'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afb935ee7ad31cd638bebae9593f0c757dca947f [INFO] sha for GitHub repo lordarthas/undergarden: afb935ee7ad31cd638bebae9593f0c757dca947f [INFO] validating manifest of lordarthas/undergarden on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lordarthas/undergarden on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lordarthas/undergarden [INFO] finished frobbing lordarthas/undergarden [INFO] frobbed toml for lordarthas/undergarden written to work/ex/clippy-test-run/sources/stable/gh/lordarthas/undergarden/Cargo.toml [INFO] started frobbing lordarthas/undergarden [INFO] finished frobbing lordarthas/undergarden [INFO] frobbed toml for lordarthas/undergarden written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lordarthas/undergarden/Cargo.toml [INFO] crate lordarthas/undergarden has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lordarthas/undergarden against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lordarthas/undergarden:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a45ffd4b311a12373f56c747af2fd5bfda67a1cefa7423f531361833cf99ce1d [INFO] running `"docker" "start" "-a" "a45ffd4b311a12373f56c747af2fd5bfda67a1cefa7423f531361833cf99ce1d"` [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking undergarden v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/unend/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / let current_section = match &self.sections[&self.current_section_tag] { [INFO] [stderr] 60 | | UnendSection::Basic(cs) => cs, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |______________^ help: try this: `let UnendSection::Basic(current_section) = &self.sections[&self.current_section_tag];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/unend/mod.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / let current_section = match &self.sections[&self.current_section_tag] { [INFO] [stderr] 161 | | UnendSection::Basic(cs) => cs, [INFO] [stderr] 162 | | }; [INFO] [stderr] | |__________^ help: try this: `let UnendSection::Basic(current_section) = &self.sections[&self.current_section_tag];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/unend/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / let current_section = match &self.sections[&self.current_section_tag] { [INFO] [stderr] 60 | | UnendSection::Basic(cs) => cs, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |______________^ help: try this: `let UnendSection::Basic(current_section) = &self.sections[&self.current_section_tag];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/unend/mod.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / let current_section = match &self.sections[&self.current_section_tag] { [INFO] [stderr] 161 | | UnendSection::Basic(cs) => cs, [INFO] [stderr] 162 | | }; [INFO] [stderr] | |__________^ help: try this: `let UnendSection::Basic(current_section) = &self.sections[&self.current_section_tag];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.98s [INFO] running `"docker" "inspect" "a45ffd4b311a12373f56c747af2fd5bfda67a1cefa7423f531361833cf99ce1d"` [INFO] running `"docker" "rm" "-f" "a45ffd4b311a12373f56c747af2fd5bfda67a1cefa7423f531361833cf99ce1d"` [INFO] [stdout] a45ffd4b311a12373f56c747af2fd5bfda67a1cefa7423f531361833cf99ce1d