[INFO] updating cached repository loopmachine/slack-archive [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/loopmachine/slack-archive [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/loopmachine/slack-archive" "work/ex/clippy-test-run/sources/stable/gh/loopmachine/slack-archive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/loopmachine/slack-archive'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/loopmachine/slack-archive" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loopmachine/slack-archive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loopmachine/slack-archive'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a388c614e3a6141d49a816dad6df469405ea28ca [INFO] sha for GitHub repo loopmachine/slack-archive: a388c614e3a6141d49a816dad6df469405ea28ca [INFO] validating manifest of loopmachine/slack-archive on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of loopmachine/slack-archive on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing loopmachine/slack-archive [INFO] finished frobbing loopmachine/slack-archive [INFO] frobbed toml for loopmachine/slack-archive written to work/ex/clippy-test-run/sources/stable/gh/loopmachine/slack-archive/Cargo.toml [INFO] started frobbing loopmachine/slack-archive [INFO] finished frobbing loopmachine/slack-archive [INFO] frobbed toml for loopmachine/slack-archive written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loopmachine/slack-archive/Cargo.toml [INFO] crate loopmachine/slack-archive has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting loopmachine/slack-archive against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/loopmachine/slack-archive:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b43480bc918614658cde8ffaf29e08558f15f4389a8c21c1d0b6922154cec7a2 [INFO] running `"docker" "start" "-a" "b43480bc918614658cde8ffaf29e08558f15f4389a8c21c1d0b6922154cec7a2"` [INFO] [stderr] Compiling libsqlite3-sys v0.9.1 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking slack_api v0.19.0 [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Checking slack_archive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/archive.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/archive.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/archive.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | if messages.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `messages.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `cmd @ _` pattern can be written as just `cmd` [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | cmd @ _ => Err(format_err!("invalid command: {}", cmd)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/archive.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | if messages.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `messages.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `cmd @ _` pattern can be written as just `cmd` [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | cmd @ _ => Err(format_err!("invalid command: {}", cmd)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.26s [INFO] running `"docker" "inspect" "b43480bc918614658cde8ffaf29e08558f15f4389a8c21c1d0b6922154cec7a2"` [INFO] running `"docker" "rm" "-f" "b43480bc918614658cde8ffaf29e08558f15f4389a8c21c1d0b6922154cec7a2"` [INFO] [stdout] b43480bc918614658cde8ffaf29e08558f15f4389a8c21c1d0b6922154cec7a2