[INFO] updating cached repository lolzballs/stunnel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lolzballs/stunnel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lolzballs/stunnel" "work/ex/clippy-test-run/sources/stable/gh/lolzballs/stunnel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lolzballs/stunnel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lolzballs/stunnel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lolzballs/stunnel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lolzballs/stunnel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 02d0a84642563a224cd1c0de53e6d7c84d7ca96a [INFO] sha for GitHub repo lolzballs/stunnel: 02d0a84642563a224cd1c0de53e6d7c84d7ca96a [INFO] validating manifest of lolzballs/stunnel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lolzballs/stunnel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lolzballs/stunnel [INFO] finished frobbing lolzballs/stunnel [INFO] frobbed toml for lolzballs/stunnel written to work/ex/clippy-test-run/sources/stable/gh/lolzballs/stunnel/Cargo.toml [INFO] started frobbing lolzballs/stunnel [INFO] finished frobbing lolzballs/stunnel [INFO] frobbed toml for lolzballs/stunnel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lolzballs/stunnel/Cargo.toml [INFO] crate lolzballs/stunnel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lolzballs/stunnel against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lolzballs/stunnel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf0b72e04e57914a3c8595d45736cbe692d3c751d3a431be26f07f7c9a2656b4 [INFO] running `"docker" "start" "-a" "bf0b72e04e57914a3c8595d45736cbe692d3c751d3a431be26f07f7c9a2656b4"` [INFO] [stderr] Compiling openssl v0.9.10 [INFO] [stderr] Compiling openssl-sys v0.9.10 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.27 [INFO] [stderr] Checking toml v0.4.1 [INFO] [stderr] Compiling syn v0.11.10 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking bytes v0.4.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking mio v0.6.6 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking tokio-core v0.1.6 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.8 [INFO] [stderr] Checking tokio-tls v0.1.2 [INFO] [stderr] Checking stunnel v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:84:40 [INFO] [stderr] | [INFO] [stderr] 84 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:84:40 [INFO] [stderr] | [INFO] [stderr] 84 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | local: local, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | sni_addr: sni_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sni_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | Server { tunnels: tunnels } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tunnels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | streams: streams, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `streams` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | local: local, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | sni_addr: sni_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sni_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | Server { tunnels: tunnels } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tunnels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | streams: streams, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `streams` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `native_tls::TlsConnector` [INFO] [stderr] --> src/tunnel.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use native_tls::TlsConnector; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `native_tls::TlsConnector` [INFO] [stderr] --> src/tunnel.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use native_tls::TlsConnector; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `done` [INFO] [stderr] --> src/server.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | let done = match try!(stream.poll()) { [INFO] [stderr] | ^^^^ help: consider using `_done` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `done` [INFO] [stderr] --> src/server.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let done = match try!(stream.poll()) { [INFO] [stderr] | ^^^^ help: consider using `_done` instead [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server.rs:103:41 [INFO] [stderr] | [INFO] [stderr] 103 | match Self::listen(&handle, local_addr.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*local_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:113:12 [INFO] [stderr] | [INFO] [stderr] 113 | if all.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `all.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tunnel.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | let local_addr = local_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tunnel.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | let local_addr = local_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused variable: `done` [INFO] [stderr] --> src/server.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | let done = match try!(stream.poll()) { [INFO] [stderr] | ^^^^ help: consider using `_done` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `done` [INFO] [stderr] --> src/server.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let done = match try!(stream.poll()) { [INFO] [stderr] | ^^^^ help: consider using `_done` instead [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server.rs:103:41 [INFO] [stderr] | [INFO] [stderr] 103 | match Self::listen(&handle, local_addr.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*local_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:113:12 [INFO] [stderr] | [INFO] [stderr] 113 | if all.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `all.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tunnel.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | let local_addr = local_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tunnel.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | let local_addr = local_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.62s [INFO] running `"docker" "inspect" "bf0b72e04e57914a3c8595d45736cbe692d3c751d3a431be26f07f7c9a2656b4"` [INFO] running `"docker" "rm" "-f" "bf0b72e04e57914a3c8595d45736cbe692d3c751d3a431be26f07f7c9a2656b4"` [INFO] [stdout] bf0b72e04e57914a3c8595d45736cbe692d3c751d3a431be26f07f7c9a2656b4