[INFO] updating cached repository loloof64/tic_tac_toe_rust_webview [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/loloof64/tic_tac_toe_rust_webview [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/loloof64/tic_tac_toe_rust_webview" "work/ex/clippy-test-run/sources/stable/gh/loloof64/tic_tac_toe_rust_webview"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/loloof64/tic_tac_toe_rust_webview'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/loloof64/tic_tac_toe_rust_webview" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loloof64/tic_tac_toe_rust_webview"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loloof64/tic_tac_toe_rust_webview'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f12cf45d832e53af70d264a3200d94e87c9bd5f [INFO] sha for GitHub repo loloof64/tic_tac_toe_rust_webview: 4f12cf45d832e53af70d264a3200d94e87c9bd5f [INFO] validating manifest of loloof64/tic_tac_toe_rust_webview on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of loloof64/tic_tac_toe_rust_webview on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing loloof64/tic_tac_toe_rust_webview [INFO] finished frobbing loloof64/tic_tac_toe_rust_webview [INFO] frobbed toml for loloof64/tic_tac_toe_rust_webview written to work/ex/clippy-test-run/sources/stable/gh/loloof64/tic_tac_toe_rust_webview/Cargo.toml [INFO] started frobbing loloof64/tic_tac_toe_rust_webview [INFO] finished frobbing loloof64/tic_tac_toe_rust_webview [INFO] frobbed toml for loloof64/tic_tac_toe_rust_webview written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loloof64/tic_tac_toe_rust_webview/Cargo.toml [INFO] crate loloof64/tic_tac_toe_rust_webview has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting loloof64/tic_tac_toe_rust_webview against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/loloof64/tic_tac_toe_rust_webview:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 699b196acbf1d6ef064225307d98914d067d3492e8e106ee080cf81281daf418 [INFO] running `"docker" "start" "-a" "699b196acbf1d6ef064225307d98914d067d3492e8e106ee080cf81281daf418"` [INFO] [stderr] Compiling webview-sys v0.1.0 [INFO] [stderr] Checking web-view v0.2.1 [INFO] [stderr] Checking tictactoe_webview v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | return self.elements[(cell_y * 3) + cell_x] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elements[(cell_y * 3) + cell_x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | return Some(Side::None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Side::None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | return self.elements[(cell_y * 3) + cell_x] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elements[(cell_y * 3) + cell_x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | return Some(Side::None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Side::None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:62 [INFO] [stderr] | [INFO] [stderr] 116 | fn consume_piece<'a, T>(webview: &mut WebView<'a, T>, piece: &Side, cell_x: &usize, cell_y: &usize) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Side` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:77 [INFO] [stderr] | [INFO] [stderr] 116 | fn consume_piece<'a, T>(webview: &mut WebView<'a, T>, piece: &Side, cell_x: &usize, cell_y: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:93 [INFO] [stderr] | [INFO] [stderr] 116 | fn consume_piece<'a, T>(webview: &mut WebView<'a, T>, piece: &Side, cell_x: &usize, cell_y: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:125:60 [INFO] [stderr] | [INFO] [stderr] 125 | fn consume_turn<'a, T>(webview: &mut WebView<'a, T>, turn: &Side) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Side` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:62 [INFO] [stderr] | [INFO] [stderr] 116 | fn consume_piece<'a, T>(webview: &mut WebView<'a, T>, piece: &Side, cell_x: &usize, cell_y: &usize) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Side` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:77 [INFO] [stderr] | [INFO] [stderr] 116 | fn consume_piece<'a, T>(webview: &mut WebView<'a, T>, piece: &Side, cell_x: &usize, cell_y: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:93 [INFO] [stderr] | [INFO] [stderr] 116 | fn consume_piece<'a, T>(webview: &mut WebView<'a, T>, piece: &Side, cell_x: &usize, cell_y: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:125:60 [INFO] [stderr] | [INFO] [stderr] 125 | fn consume_turn<'a, T>(webview: &mut WebView<'a, T>, turn: &Side) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Side` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.19s [INFO] running `"docker" "inspect" "699b196acbf1d6ef064225307d98914d067d3492e8e106ee080cf81281daf418"` [INFO] running `"docker" "rm" "-f" "699b196acbf1d6ef064225307d98914d067d3492e8e106ee080cf81281daf418"` [INFO] [stdout] 699b196acbf1d6ef064225307d98914d067d3492e8e106ee080cf81281daf418