[INFO] updating cached repository loginn/RustSH [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/loginn/RustSH [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/loginn/RustSH" "work/ex/clippy-test-run/sources/stable/gh/loginn/RustSH"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/loginn/RustSH'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/loginn/RustSH" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loginn/RustSH"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loginn/RustSH'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89f98aca2b9b7fb03fa0d15681c9c7fcb96c7134 [INFO] sha for GitHub repo loginn/RustSH: 89f98aca2b9b7fb03fa0d15681c9c7fcb96c7134 [INFO] validating manifest of loginn/RustSH on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of loginn/RustSH on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing loginn/RustSH [INFO] finished frobbing loginn/RustSH [INFO] frobbed toml for loginn/RustSH written to work/ex/clippy-test-run/sources/stable/gh/loginn/RustSH/Cargo.toml [INFO] started frobbing loginn/RustSH [INFO] finished frobbing loginn/RustSH [INFO] frobbed toml for loginn/RustSH written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loginn/RustSH/Cargo.toml [INFO] crate loginn/RustSH has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting loginn/RustSH against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/loginn/RustSH:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b45df04ec28151b5410e280f829ca2aaa86b57c1666a5669af07ef5806abe7dc [INFO] running `"docker" "start" "-a" "b45df04ec28151b5410e280f829ca2aaa86b57c1666a5669af07ef5806abe7dc"` [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking sh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/env.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | print!("{}={}\n", x.0, x.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/env.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | print!("{}={}\n", x.0, x.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:7:63 [INFO] [stderr] | [INFO] [stderr] 7 | Err(err) => {println!("Error : {}, {:?}", err, path); return 1}, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | Ok(_) => {return 0} [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Some(desired_path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(desired_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | Some(n) => return CommandResult { child: None, status: change_directory(&n) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: change_directory(&n) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | None => return CommandResult { child: None, status: 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return CommandResult { child: None, status: 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return CommandResult { child: None, status: 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launch_bin.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Some(process) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(process)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launch_bin.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return create_process(command_vector) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `create_process(command_vector)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launch_bin.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return return_value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return CommandResult { child: None, status: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return CommandResult { child: None, status: 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return CommandResult { child: None, status: 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return CommandResult { child: None, status: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return CommandResult { child: None, status: 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/main.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | mod parser { pub mod parser; pub mod lexer; pub mod nodes; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return Err("Token kind does not match expected type") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Token kind does not match expected type")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self.current_token.kind == TokenOperator::SEMI || self.current_token.kind == TokenOperator::AND || self.current_token.kind == TokenOperator::OR; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.current_token.kind == TokenOperator::SEMI || self.current_token.kind == TokenOperator::AND || self.current_token.kind == TokenOperator::OR` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / return Lexer { [INFO] [stderr] 30 | | command, [INFO] [stderr] 31 | | pos: 0, [INFO] [stderr] 32 | | current_char: c [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Lexer { [INFO] [stderr] 30 | command, [INFO] [stderr] 31 | pos: 0, [INFO] [stderr] 32 | current_char: c [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return self.command.chars().nth(peek_pos) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.command.chars().nth(peek_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / return Token { [INFO] [stderr] 59 | | kind: TokenOperator:: CMD, [INFO] [stderr] 60 | | value: Some(result) [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Token { [INFO] [stderr] 59 | kind: TokenOperator:: CMD, [INFO] [stderr] 60 | value: Some(result) [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | Some(p) => return p == c, [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `p == c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return Token { kind: TokenOperator::EOF, value: None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token { kind: TokenOperator::EOF, value: None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return "Eof"; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `"Eof"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Command { token: tok.clone(), value: tok.value.unwrap() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Command { token: tok.clone(), value: tok.value.unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return "BinOp"; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `"BinOp"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return "Command"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Command"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return self.visit_binop(node.downcast::().ok().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.visit_binop(node.downcast::().ok().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return CommandResult { child: None, status: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return self.visit_command(node.downcast::().ok().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.visit_command(node.downcast::().ok().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | return self.visit(n.right); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.visit(n.right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/cd.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:7:63 [INFO] [stderr] | [INFO] [stderr] 7 | Err(err) => {println!("Error : {}, {:?}", err, path); return 1}, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | Ok(_) => {return 0} [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return Some(desired_path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(desired_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | Some(n) => return CommandResult { child: None, status: change_directory(&n) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: change_directory(&n) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | None => return CommandResult { child: None, status: 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return CommandResult { child: None, status: 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cd.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return CommandResult { child: None, status: 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launch_bin.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Some(process) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(process)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launch_bin.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return create_process(command_vector) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `create_process(command_vector)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launch_bin.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return return_value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return CommandResult { child: None, status: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return CommandResult { child: None, status: 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return CommandResult { child: None, status: 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return CommandResult { child: None, status: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/env.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return CommandResult { child: None, status: 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/main.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | mod parser { pub mod parser; pub mod lexer; pub mod nodes; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return Err("Token kind does not match expected type") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Token kind does not match expected type")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self.current_token.kind == TokenOperator::SEMI || self.current_token.kind == TokenOperator::AND || self.current_token.kind == TokenOperator::OR; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.current_token.kind == TokenOperator::SEMI || self.current_token.kind == TokenOperator::AND || self.current_token.kind == TokenOperator::OR` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / return Lexer { [INFO] [stderr] 30 | | command, [INFO] [stderr] 31 | | pos: 0, [INFO] [stderr] 32 | | current_char: c [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Lexer { [INFO] [stderr] 30 | command, [INFO] [stderr] 31 | pos: 0, [INFO] [stderr] 32 | current_char: c [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return self.command.chars().nth(peek_pos) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.command.chars().nth(peek_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / return Token { [INFO] [stderr] 59 | | kind: TokenOperator:: CMD, [INFO] [stderr] 60 | | value: Some(result) [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Token { [INFO] [stderr] 59 | kind: TokenOperator:: CMD, [INFO] [stderr] 60 | value: Some(result) [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | Some(p) => return p == c, [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `p == c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/lexer.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return Token { kind: TokenOperator::EOF, value: None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token { kind: TokenOperator::EOF, value: None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return "Eof"; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `"Eof"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Command { token: tok.clone(), value: tok.value.unwrap() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Command { token: tok.clone(), value: tok.value.unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return "BinOp"; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `"BinOp"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/nodes.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return "Command"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Command"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return self.visit_binop(node.downcast::().ok().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.visit_binop(node.downcast::().ok().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return CommandResult { child: None, status: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CommandResult { child: None, status: 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return self.visit_command(node.downcast::().ok().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.visit_command(node.downcast::().ok().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | return self.visit(n.right); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.visit(n.right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/cd.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PIPE` [INFO] [stderr] --> src/parser/lexer.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | PIPE, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RIGHT` [INFO] [stderr] --> src/parser/lexer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | RIGHT, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LEFT` [INFO] [stderr] --> src/parser/lexer.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | LEFT, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PIPE` [INFO] [stderr] --> src/parser/lexer.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | PIPE, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RIGHT` [INFO] [stderr] --> src/parser/lexer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | RIGHT, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LEFT` [INFO] [stderr] --> src/parser/lexer.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | LEFT, [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cd.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn cd (command_vector: &Vec ) -> CommandResult { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/launch_bin.rs:4:52 [INFO] [stderr] | [INFO] [stderr] 4 | fn add_args(process: &mut Command, command_vector: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cd.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn cd (command_vector: &Vec ) -> CommandResult { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/launch_bin.rs:4:52 [INFO] [stderr] | [INFO] [stderr] 4 | fn add_args(process: &mut Command, command_vector: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/env.rs:19:46 [INFO] [stderr] | [INFO] [stderr] 19 | let values = command_vector[1].split("=").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/env.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match writeln!(&mut io::stderr(), "Invalid pair") { [INFO] [stderr] 27 | | Err(e) => println!("{}", e), [INFO] [stderr] 28 | | _ => {} [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { println!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/env.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | / match writeln!(&mut io::stderr(), "No input var") { [INFO] [stderr] 41 | | Err(e) => println!("{}", e), [INFO] [stderr] 42 | | _ => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { println!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/env.rs:19:46 [INFO] [stderr] | [INFO] [stderr] 19 | let values = command_vector[1].split("=").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/env.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match writeln!(&mut io::stderr(), "Invalid pair") { [INFO] [stderr] 27 | | Err(e) => println!("{}", e), [INFO] [stderr] 28 | | _ => {} [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { println!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/env.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | / match writeln!(&mut io::stderr(), "No input var") { [INFO] [stderr] 41 | | Err(e) => println!("{}", e), [INFO] [stderr] 42 | | _ => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { println!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/interpreter.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | fn visit_command(&self, node: Box) -> CommandResult { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/interpreter.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | fn visit_binop(&self, node: Box) -> CommandResult { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/interpreter.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | fn visit_command(&self, node: Box) -> CommandResult { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/interpreter.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | fn visit_binop(&self, node: Box) -> CommandResult { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.22s [INFO] running `"docker" "inspect" "b45df04ec28151b5410e280f829ca2aaa86b57c1666a5669af07ef5806abe7dc"` [INFO] running `"docker" "rm" "-f" "b45df04ec28151b5410e280f829ca2aaa86b57c1666a5669af07ef5806abe7dc"` [INFO] [stdout] b45df04ec28151b5410e280f829ca2aaa86b57c1666a5669af07ef5806abe7dc