[INFO] updating cached repository logannc/valence
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/logannc/valence
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/logannc/valence" "work/ex/clippy-test-run/sources/stable/gh/logannc/valence"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/logannc/valence'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/logannc/valence" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/logannc/valence"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/logannc/valence'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 25508413302813b1624d80dff886ce3c0b257ab5
[INFO] sha for GitHub repo logannc/valence: 25508413302813b1624d80dff886ce3c0b257ab5
[INFO] validating manifest of logannc/valence on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of logannc/valence on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing logannc/valence
[INFO] finished frobbing logannc/valence
[INFO] frobbed toml for logannc/valence written to work/ex/clippy-test-run/sources/stable/gh/logannc/valence/Cargo.toml
[INFO] started frobbing logannc/valence
[INFO] finished frobbing logannc/valence
[INFO] frobbed toml for logannc/valence written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/logannc/valence/Cargo.toml
[INFO] crate logannc/valence has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting logannc/valence against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/logannc/valence:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d3df19cb6969ea44d312290f23ad8ddf93c6ba23b19cc3a6547322c2a57e7466
[INFO] running `"docker" "start" "-a" "d3df19cb6969ea44d312290f23ad8ddf93c6ba23b19cc3a6547322c2a57e7466"`
[INFO] [stderr]     Checking bincode v1.0.1
[INFO] [stderr]    Compiling syn v0.15.18
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]     Checking valence v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]   --> src/client.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             Ok(())
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/network.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 |             Ok(())
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]   --> src/client.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             Ok(())
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/network.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 |             Ok(())
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `v`
[INFO] [stderr]   --> src/network.rs:87:35
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     .filter(|(&k, v)| k != ID)
[INFO] [stderr]    |                                   ^ help: consider using `_v` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `name`
[INFO] [stderr]    --> src/network.rs:111:29
[INFO] [stderr]     |
[INFO] [stderr] 111 |         ClientMessage::Join(name) => Ok(()), // Ignore this misbehaving message.
[INFO] [stderr]     |                             ^^^^ help: consider using `_name` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]    --> src/network.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Err(err) => Err(Error::from(ErrorKind::InvalidData)),
[INFO] [stderr]     |             ^^^ help: consider using `_err` instead
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/client.rs:34:59
[INFO] [stderr]    |
[INFO] [stderr] 34 |             let join_msg = serialize(&ClientMessage::Join(nickname.into()))
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `nickname`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/client.rs:42:17
[INFO] [stderr]    |
[INFO] [stderr] 42 |                 std::io::stdin().read_line(&mut buf);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/network.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         peer.writer.start_send(serialized_msg.clone());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/network.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 |         peer.writer.poll_complete();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]   --> src/network.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 let ID = Uuid::new_v4();
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]   --> src/network.rs:77:46
[INFO] [stderr]    |
[INFO] [stderr] 77 | fn handle_client_message(msg: ClientMessage, ID: Uuid, peers: &mut Peers) -> Result<(), Error> {
[INFO] [stderr]    |                                              ^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]    --> src/network.rs:115:34
[INFO] [stderr]     |
[INFO] [stderr] 115 | fn handle_frame(frame: BytesMut, ID: Uuid, mut peers: Peers) -> Result<(), Error> {
[INFO] [stderr]     |                                  ^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/network.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         peer.writer.poll_complete();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]    --> src/network.rs:126:22
[INFO] [stderr]     |
[INFO] [stderr] 126 | fn handle_disconnect(ID: Uuid, mut peers: Peers) -> Result<(), Error> {
[INFO] [stderr]     |                      ^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/network.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |         peer.writer.poll_complete();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]    --> src/network.rs:137:10
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let (ID, framed_reader) = input;
[INFO] [stderr]     |          ^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]  --> src/server.rs:9:45
[INFO] [stderr]   |
[INFO] [stderr] 9 |     let listener = TcpListener::bind(&addr).expect(&format!("Could not bind to {}.", addr));
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not bind to {}.", addr))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `v`
[INFO] [stderr]   --> src/network.rs:87:35
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     .filter(|(&k, v)| k != ID)
[INFO] [stderr]    |                                   ^ help: consider using `_v` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `name`
[INFO] [stderr]    --> src/network.rs:111:29
[INFO] [stderr]     |
[INFO] [stderr] 111 |         ClientMessage::Join(name) => Ok(()), // Ignore this misbehaving message.
[INFO] [stderr]     |                             ^^^^ help: consider using `_name` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]    --> src/network.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Err(err) => Err(Error::from(ErrorKind::InvalidData)),
[INFO] [stderr]     |             ^^^ help: consider using `_err` instead
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/client.rs:34:59
[INFO] [stderr]    |
[INFO] [stderr] 34 |             let join_msg = serialize(&ClientMessage::Join(nickname.into()))
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `nickname`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/client.rs:42:17
[INFO] [stderr]    |
[INFO] [stderr] 42 |                 std::io::stdin().read_line(&mut buf);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/network.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         peer.writer.start_send(serialized_msg.clone());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/network.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 |         peer.writer.poll_complete();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]   --> src/network.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 let ID = Uuid::new_v4();
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]   --> src/network.rs:77:46
[INFO] [stderr]    |
[INFO] [stderr] 77 | fn handle_client_message(msg: ClientMessage, ID: Uuid, peers: &mut Peers) -> Result<(), Error> {
[INFO] [stderr]    |                                              ^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]    --> src/network.rs:115:34
[INFO] [stderr]     |
[INFO] [stderr] 115 | fn handle_frame(frame: BytesMut, ID: Uuid, mut peers: Peers) -> Result<(), Error> {
[INFO] [stderr]     |                                  ^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/network.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         peer.writer.poll_complete();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]    --> src/network.rs:126:22
[INFO] [stderr]     |
[INFO] [stderr] 126 | fn handle_disconnect(ID: Uuid, mut peers: Peers) -> Result<(), Error> {
[INFO] [stderr]     |                      ^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/network.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |         peer.writer.poll_complete();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable `ID` should have a snake case name such as `id`
[INFO] [stderr]    --> src/network.rs:137:10
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let (ID, framed_reader) = input;
[INFO] [stderr]     |          ^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]  --> src/server.rs:9:45
[INFO] [stderr]   |
[INFO] [stderr] 9 |     let listener = TcpListener::bind(&addr).expect(&format!("Could not bind to {}.", addr));
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not bind to {}.", addr))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.34s
[INFO] running `"docker" "inspect" "d3df19cb6969ea44d312290f23ad8ddf93c6ba23b19cc3a6547322c2a57e7466"`
[INFO] running `"docker" "rm" "-f" "d3df19cb6969ea44d312290f23ad8ddf93c6ba23b19cc3a6547322c2a57e7466"`
[INFO] [stdout] d3df19cb6969ea44d312290f23ad8ddf93c6ba23b19cc3a6547322c2a57e7466