[INFO] updating cached repository loganintech/one_time_pad [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/loganintech/one_time_pad [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/loganintech/one_time_pad" "work/ex/clippy-test-run/sources/stable/gh/loganintech/one_time_pad"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/loganintech/one_time_pad'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/loganintech/one_time_pad" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loganintech/one_time_pad"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loganintech/one_time_pad'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd98cb689d973b07be91b4bfe2fd838d39c6ebff [INFO] sha for GitHub repo loganintech/one_time_pad: cd98cb689d973b07be91b4bfe2fd838d39c6ebff [INFO] validating manifest of loganintech/one_time_pad on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of loganintech/one_time_pad on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing loganintech/one_time_pad [INFO] removed workspace from loganintech/one_time_pad [INFO] finished frobbing loganintech/one_time_pad [INFO] frobbed toml for loganintech/one_time_pad written to work/ex/clippy-test-run/sources/stable/gh/loganintech/one_time_pad/Cargo.toml [INFO] started frobbing loganintech/one_time_pad [INFO] removed workspace from loganintech/one_time_pad [INFO] finished frobbing loganintech/one_time_pad [INFO] frobbed toml for loganintech/one_time_pad written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/loganintech/one_time_pad/Cargo.toml [INFO] crate loganintech/one_time_pad has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting loganintech/one_time_pad against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/loganintech/one_time_pad:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b840074ecdbd6e4d533314bb890c4956029d932b887a30919b8b38a4fcba4824 [INFO] running `"docker" "start" "-a" "b840074ecdbd6e4d533314bb890c4956029d932b887a30919b8b38a4fcba4824"` [INFO] [stderr] Checking rand_isaac v0.1.0 [INFO] [stderr] Compiling rand v0.6.0 [INFO] [stderr] Checking one_time_pad v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> otp_lib/src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_dec_d/src/main.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | let _ = stream.write_all("|Incorrectly formatted string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Incorrectly formatted string."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_dec_d/src/main.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | let _ = stream.write_all("|Cannot encode with otp_dec_d.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Cannot encode with otp_dec_d."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_dec_d/src/main.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | let _ = stream.write_all("|Couldn't parse buffer as string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Couldn't parse buffer as string."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> otp_dec_d/src/main.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | let port = args() [INFO] [stderr] | ________________^ [INFO] [stderr] 49 | | .skip(1) [INFO] [stderr] 50 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_enc_d/src/main.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | let _ = stream.write_all("|Incorrectly formatted string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Incorrectly formatted string."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_enc_d/src/main.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | let _ = stream.write_all("|Cannot decode with otp_enc_d.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Cannot decode with otp_enc_d."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_enc_d/src/main.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | let _ = stream.write_all("|Couldn't parse buffer as string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Couldn't parse buffer as string."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> otp_enc_d/src/main.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | let port = args() [INFO] [stderr] | ________________^ [INFO] [stderr] 49 | | .skip(1) [INFO] [stderr] 50 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_dec_d/src/main.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | let _ = stream.write_all("|Incorrectly formatted string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Incorrectly formatted string."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_dec_d/src/main.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | let _ = stream.write_all("|Cannot encode with otp_dec_d.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Cannot encode with otp_dec_d."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_dec_d/src/main.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | let _ = stream.write_all("|Couldn't parse buffer as string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Couldn't parse buffer as string."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> otp_dec_d/src/main.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | let port = args() [INFO] [stderr] | ________________^ [INFO] [stderr] 49 | | .skip(1) [INFO] [stderr] 50 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_enc_d/src/main.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | let _ = stream.write_all("|Incorrectly formatted string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Incorrectly formatted string."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_enc_d/src/main.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | let _ = stream.write_all("|Cannot decode with otp_enc_d.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Cannot decode with otp_enc_d."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> otp_enc_d/src/main.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | let _ = stream.write_all("|Couldn't parse buffer as string.".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"|Couldn't parse buffer as string."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> otp_enc_d/src/main.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | let port = args() [INFO] [stderr] | ________________^ [INFO] [stderr] 49 | | .skip(1) [INFO] [stderr] 50 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> keygen/src/main.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | let length = args() [INFO] [stderr] | __________________^ [INFO] [stderr] 13 | | .skip(1) [INFO] [stderr] 14 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> keygen/src/main.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | let length = args() [INFO] [stderr] | __________________^ [INFO] [stderr] 13 | | .skip(1) [INFO] [stderr] 14 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.51s [INFO] running `"docker" "inspect" "b840074ecdbd6e4d533314bb890c4956029d932b887a30919b8b38a4fcba4824"` [INFO] running `"docker" "rm" "-f" "b840074ecdbd6e4d533314bb890c4956029d932b887a30919b8b38a4fcba4824"` [INFO] [stdout] b840074ecdbd6e4d533314bb890c4956029d932b887a30919b8b38a4fcba4824