[INFO] updating cached repository lofim/rusty-karel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lofim/rusty-karel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lofim/rusty-karel" "work/ex/clippy-test-run/sources/stable/gh/lofim/rusty-karel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lofim/rusty-karel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lofim/rusty-karel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lofim/rusty-karel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lofim/rusty-karel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d96fe76891155137d319243ee0b25abd36485464 [INFO] sha for GitHub repo lofim/rusty-karel: d96fe76891155137d319243ee0b25abd36485464 [INFO] validating manifest of lofim/rusty-karel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lofim/rusty-karel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lofim/rusty-karel [INFO] finished frobbing lofim/rusty-karel [INFO] frobbed toml for lofim/rusty-karel written to work/ex/clippy-test-run/sources/stable/gh/lofim/rusty-karel/Cargo.toml [INFO] started frobbing lofim/rusty-karel [INFO] finished frobbing lofim/rusty-karel [INFO] frobbed toml for lofim/rusty-karel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lofim/rusty-karel/Cargo.toml [INFO] crate lofim/rusty-karel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lofim/rusty-karel against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lofim/rusty-karel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a08cd6d9a63c9f8ac814a6104625b68c99cd6e6dd553324e4bcae86563313f74 [INFO] running `"docker" "start" "-a" "a08cd6d9a63c9f8ac814a6104625b68c99cd6e6dd553324e4bcae86563313f74"` [INFO] [stderr] Checking rusty-karel v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/helpers.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn extract(&self) -> (Size, Size) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/helpers.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn compute_index(position: &Position, width: Size) -> Size { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | fn render_tile(&self, tile: &Tile) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Tile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | fn render_orientation(&self, orientation: &Orientation) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/helpers.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn extract(&self) -> (Size, Size) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/helpers.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn compute_index(position: &Position, width: Size) -> Size { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | fn render_tile(&self, tile: &Tile) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Tile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | fn render_orientation(&self, orientation: &Orientation) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "a08cd6d9a63c9f8ac814a6104625b68c99cd6e6dd553324e4bcae86563313f74"` [INFO] running `"docker" "rm" "-f" "a08cd6d9a63c9f8ac814a6104625b68c99cd6e6dd553324e4bcae86563313f74"` [INFO] [stdout] a08cd6d9a63c9f8ac814a6104625b68c99cd6e6dd553324e4bcae86563313f74