[INFO] updating cached repository lofim/gotham-todo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lofim/gotham-todo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lofim/gotham-todo" "work/ex/clippy-test-run/sources/stable/gh/lofim/gotham-todo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lofim/gotham-todo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lofim/gotham-todo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lofim/gotham-todo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lofim/gotham-todo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1de092d3cd54c226d2f930f61307c5ff9ea6acd2 [INFO] sha for GitHub repo lofim/gotham-todo: 1de092d3cd54c226d2f930f61307c5ff9ea6acd2 [INFO] validating manifest of lofim/gotham-todo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lofim/gotham-todo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lofim/gotham-todo [INFO] finished frobbing lofim/gotham-todo [INFO] frobbed toml for lofim/gotham-todo written to work/ex/clippy-test-run/sources/stable/gh/lofim/gotham-todo/Cargo.toml [INFO] started frobbing lofim/gotham-todo [INFO] finished frobbing lofim/gotham-todo [INFO] frobbed toml for lofim/gotham-todo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lofim/gotham-todo/Cargo.toml [INFO] crate lofim/gotham-todo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lofim/gotham-todo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lofim/gotham-todo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7380e62a11291d720efe98d99c329e376d249b8c6e23dcad2951c186cbafaf18 [INFO] running `"docker" "start" "-a" "7380e62a11291d720efe98d99c329e376d249b8c6e23dcad2951c186cbafaf18"` [INFO] [stderr] Compiling serde v1.0.57 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Compiling serde_derive v1.0.57 [INFO] [stderr] Compiling gotham_derive v0.2.1 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.17 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking bincode v1.0.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Compiling cargo_metadata v0.5.4 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling borrow-bag v1.0.0 [INFO] [stderr] Checking gotham v0.2.1 [INFO] [stderr] Checking gotham-todo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/controller.rs:115:23 [INFO] [stderr] | [INFO] [stderr] 115 | Err(e) => return future::err((state, e.into_handler_error())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `future::err((state, e.into_handler_error()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/controller.rs:115:23 [INFO] [stderr] | [INFO] [stderr] 115 | Err(e) => return future::err((state, e.into_handler_error())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `future::err((state, e.into_handler_error()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.05s [INFO] running `"docker" "inspect" "7380e62a11291d720efe98d99c329e376d249b8c6e23dcad2951c186cbafaf18"` [INFO] running `"docker" "rm" "-f" "7380e62a11291d720efe98d99c329e376d249b8c6e23dcad2951c186cbafaf18"` [INFO] [stdout] 7380e62a11291d720efe98d99c329e376d249b8c6e23dcad2951c186cbafaf18