[INFO] updating cached repository lnenad/image-to-ascii
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lnenad/image-to-ascii
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lnenad/image-to-ascii" "work/ex/clippy-test-run/sources/stable/gh/lnenad/image-to-ascii"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lnenad/image-to-ascii'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lnenad/image-to-ascii" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lnenad/image-to-ascii"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lnenad/image-to-ascii'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3a6cfa6c1e70e7a6a5ed675ca8a61950c5a613b5
[INFO] sha for GitHub repo lnenad/image-to-ascii: 3a6cfa6c1e70e7a6a5ed675ca8a61950c5a613b5
[INFO] validating manifest of lnenad/image-to-ascii on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lnenad/image-to-ascii on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lnenad/image-to-ascii
[INFO] finished frobbing lnenad/image-to-ascii
[INFO] frobbed toml for lnenad/image-to-ascii written to work/ex/clippy-test-run/sources/stable/gh/lnenad/image-to-ascii/Cargo.toml
[INFO] started frobbing lnenad/image-to-ascii
[INFO] finished frobbing lnenad/image-to-ascii
[INFO] frobbed toml for lnenad/image-to-ascii written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lnenad/image-to-ascii/Cargo.toml
[INFO] crate lnenad/image-to-ascii has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lnenad/image-to-ascii against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lnenad/image-to-ascii:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8012d2983276b37e06b4d4d34a193af026528a6e3883877dad74c0cb53b99b51
[INFO] running `"docker" "start" "-a" "8012d2983276b37e06b4d4d34a193af026528a6e3883877dad74c0cb53b99b51"`
[INFO] [stderr]     Checking imagetoascii v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd::Parser`
[INFO] [stderr]   --> src/cmd.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Parser {
[INFO] [stderr] 26 | |         Parser {
[INFO] [stderr] 27 | |             prefixes: None
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd::Parser`
[INFO] [stderr]   --> src/cmd.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Parser {
[INFO] [stderr] 26 | |         Parser {
[INFO] [stderr] 27 | |             prefixes: None
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:29:51
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let end = (time::precise_time_ns() - start) / 1000000;
[INFO] [stderr]    |                                                   ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:29:51
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let end = (time::precise_time_ns() - start) / 1000000;
[INFO] [stderr]    |                                                   ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:16:45
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let image_path = arguments.get("image").or(arguments.get("i")).expect("No image argument provided");
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| arguments.get("i"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:20:42
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let output = arguments.get("output").or(arguments.get("o")).expect("No output argument provided");
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| arguments.get("o"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:22:56
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let resolution = match arguments.get("resolution").or(arguments.get("r")) {
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| arguments.get("r"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         generate_preview(&output.replace(".txt", ".html"), &contents);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:55:32
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let brightness:f64 = ((pixel_data[0] as u64 + pixel_data[1] as u64 + pixel_data[2] as u64) / 3) as f64;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel_data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:55:55
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let brightness:f64 = ((pixel_data[0] as u64 + pixel_data[1] as u64 + pixel_data[2] as u64) / 3) as f64;
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel_data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:55:78
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let brightness:f64 = ((pixel_data[0] as u64 + pixel_data[1] as u64 + pixel_data[2] as u64) / 3) as f64;
[INFO] [stderr]    |                                                                              ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel_data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     match write_to_file(output,&art) {
[INFO] [stderr] 61 | |         Ok(_) => (),
[INFO] [stderr] 62 | |         _ => ()
[INFO] [stderr] 63 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Ok(_) = write_to_file(output,&art) { () }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:68:45
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn write_to_file(file_name: &str, contents: &String) -> Result<String, Box<Error>> {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:79:48
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn generate_preview(file_name: &str, contents: &String) -> Result<String, Box<Error>> {
[INFO] [stderr]    |                                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     dst.write(new_data.as_bytes())?;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `imagetoascii`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:16:45
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let image_path = arguments.get("image").or(arguments.get("i")).expect("No image argument provided");
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| arguments.get("i"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:20:42
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let output = arguments.get("output").or(arguments.get("o")).expect("No output argument provided");
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| arguments.get("o"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:22:56
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let resolution = match arguments.get("resolution").or(arguments.get("r")) {
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| arguments.get("r"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         generate_preview(&output.replace(".txt", ".html"), &contents);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:55:32
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let brightness:f64 = ((pixel_data[0] as u64 + pixel_data[1] as u64 + pixel_data[2] as u64) / 3) as f64;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel_data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:55:55
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let brightness:f64 = ((pixel_data[0] as u64 + pixel_data[1] as u64 + pixel_data[2] as u64) / 3) as f64;
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel_data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:55:78
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let brightness:f64 = ((pixel_data[0] as u64 + pixel_data[1] as u64 + pixel_data[2] as u64) / 3) as f64;
[INFO] [stderr]    |                                                                              ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel_data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     match write_to_file(output,&art) {
[INFO] [stderr] 61 | |         Ok(_) => (),
[INFO] [stderr] 62 | |         _ => ()
[INFO] [stderr] 63 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Ok(_) = write_to_file(output,&art) { () }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:68:45
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn write_to_file(file_name: &str, contents: &String) -> Result<String, Box<Error>> {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:79:48
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn generate_preview(file_name: &str, contents: &String) -> Result<String, Box<Error>> {
[INFO] [stderr]    |                                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     dst.write(new_data.as_bytes())?;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `imagetoascii`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "8012d2983276b37e06b4d4d34a193af026528a6e3883877dad74c0cb53b99b51"`
[INFO] running `"docker" "rm" "-f" "8012d2983276b37e06b4d4d34a193af026528a6e3883877dad74c0cb53b99b51"`
[INFO] [stdout] 8012d2983276b37e06b4d4d34a193af026528a6e3883877dad74c0cb53b99b51