[INFO] updating cached repository lluchs/ocbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lluchs/ocbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lluchs/ocbot" "work/ex/clippy-test-run/sources/stable/gh/lluchs/ocbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lluchs/ocbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lluchs/ocbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lluchs/ocbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lluchs/ocbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37730c4d0a4508d4a39a3b90a9643db5a752b8fd [INFO] sha for GitHub repo lluchs/ocbot: 37730c4d0a4508d4a39a3b90a9643db5a752b8fd [INFO] validating manifest of lluchs/ocbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lluchs/ocbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lluchs/ocbot [INFO] finished frobbing lluchs/ocbot [INFO] frobbed toml for lluchs/ocbot written to work/ex/clippy-test-run/sources/stable/gh/lluchs/ocbot/Cargo.toml [INFO] started frobbing lluchs/ocbot [INFO] finished frobbing lluchs/ocbot [INFO] frobbed toml for lluchs/ocbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lluchs/ocbot/Cargo.toml [INFO] crate lluchs/ocbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lluchs/ocbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lluchs/ocbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8062c9061245c6968b06716ed41f4154f6ca7dbfb57df15f9770f66351382b16 [INFO] running `"docker" "start" "-a" "8062c9061245c6968b06716ed41f4154f6ca7dbfb57df15f9770f66351382b16"` [INFO] [stderr] Compiling backtrace-sys v0.1.6 [INFO] [stderr] Checking irc v0.11.6 [INFO] [stderr] Checking serde_urlencoded v0.4.2 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.8.1 [INFO] [stderr] Checking eventsource v0.2.0 [INFO] [stderr] Checking ocbot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/game_stream.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(game.id, 435272); [INFO] [stderr] | ^^^^^^ help: consider: `435_272` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/game_stream.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json` [INFO] [stderr] --> src/game_stream.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | use serde_json; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/game_stream.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | Delete(Game), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 54 | Delete(Box), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/game_stream.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | Delete(Game), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 54 | Delete(Box), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / let config = Config { [INFO] [stderr] 22 | | nickname: Some(format!("ocgames")), [INFO] [stderr] 23 | | server: Some(format!("irc.euirc.net")), [INFO] [stderr] 24 | | channels: Some(vec![format!("#clonkspot")]), [INFO] [stderr] 25 | | port: Some(6667), [INFO] [stderr] 26 | | .. Default::default() [INFO] [stderr] 27 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | nickname: Some(format!("ocgames")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"ocgames".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | server: Some(format!("irc.euirc.net")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"irc.euirc.net".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | channels: Some(vec![format!("#clonkspot")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#clonkspot".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match message.command { [INFO] [stderr] 34 | | Command::PRIVMSG(ref target, ref msg) => if msg.contains("pickles") { [INFO] [stderr] 35 | | server.send_privmsg(target, "Hi!").unwrap(); [INFO] [stderr] 36 | | }, [INFO] [stderr] 37 | | _ => (), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Command::PRIVMSG(ref target, ref msg) = message.command { if msg.contains("pickles") { [INFO] [stderr] 34 | server.send_privmsg(target, "Hi!").unwrap(); [INFO] [stderr] 35 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / let config = Config { [INFO] [stderr] 22 | | nickname: Some(format!("ocgames")), [INFO] [stderr] 23 | | server: Some(format!("irc.euirc.net")), [INFO] [stderr] 24 | | channels: Some(vec![format!("#clonkspot")]), [INFO] [stderr] 25 | | port: Some(6667), [INFO] [stderr] 26 | | .. Default::default() [INFO] [stderr] 27 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | nickname: Some(format!("ocgames")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"ocgames".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | server: Some(format!("irc.euirc.net")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"irc.euirc.net".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | channels: Some(vec![format!("#clonkspot")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#clonkspot".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match message.command { [INFO] [stderr] 34 | | Command::PRIVMSG(ref target, ref msg) => if msg.contains("pickles") { [INFO] [stderr] 35 | | server.send_privmsg(target, "Hi!").unwrap(); [INFO] [stderr] 36 | | }, [INFO] [stderr] 37 | | _ => (), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Command::PRIVMSG(ref target, ref msg) = message.command { if msg.contains("pickles") { [INFO] [stderr] 34 | server.send_privmsg(target, "Hi!").unwrap(); [INFO] [stderr] 35 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.66s [INFO] running `"docker" "inspect" "8062c9061245c6968b06716ed41f4154f6ca7dbfb57df15f9770f66351382b16"` [INFO] running `"docker" "rm" "-f" "8062c9061245c6968b06716ed41f4154f6ca7dbfb57df15f9770f66351382b16"` [INFO] [stdout] 8062c9061245c6968b06716ed41f4154f6ca7dbfb57df15f9770f66351382b16