[INFO] updating cached repository llogiq/lib_json [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/llogiq/lib_json [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/llogiq/lib_json" "work/ex/clippy-test-run/sources/stable/gh/llogiq/lib_json"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/llogiq/lib_json'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/llogiq/lib_json" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llogiq/lib_json"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llogiq/lib_json'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 336bd54e950fa19b0168eddc358073cf5918bb21 [INFO] sha for GitHub repo llogiq/lib_json: 336bd54e950fa19b0168eddc358073cf5918bb21 [INFO] validating manifest of llogiq/lib_json on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of llogiq/lib_json on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing llogiq/lib_json [INFO] finished frobbing llogiq/lib_json [INFO] frobbed toml for llogiq/lib_json written to work/ex/clippy-test-run/sources/stable/gh/llogiq/lib_json/Cargo.toml [INFO] started frobbing llogiq/lib_json [INFO] finished frobbing llogiq/lib_json [INFO] frobbed toml for llogiq/lib_json written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llogiq/lib_json/Cargo.toml [INFO] crate llogiq/lib_json has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting llogiq/lib_json against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/llogiq/lib_json:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 247ee2d02fe54e4955e06f23b4c40b988aed3df07c9a62151bdb0833b7b42bac [INFO] running `"docker" "start" "-a" "247ee2d02fe54e4955e06f23b4c40b988aed3df07c9a62151bdb0833b7b42bac"` [INFO] [stderr] Checking lib_json v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | _ => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/buffer_walk.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | unsafe{ self.buffer.slice_unchecked( start, end ) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buffer_walk.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new<'b>( s: &'b str ) -> CharIter<'b>{ [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | CharIter{ [INFO] [stderr] 22 | | previous: None, [INFO] [stderr] 23 | | buffer: s, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new<'b>( buffer: &'b str ) -> Option> { [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | let mut c = CharIter::new( buffer ); [INFO] [stderr] 22 | | let _ = c.skip_whitespace(); [INFO] [stderr] 23 | | read_field( &mut c ) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | &Json::Var(_) => true, [INFO] [stderr] 31 | | _ => false [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Json::Var(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | &Json::Obj(_) => true, [INFO] [stderr] 38 | | _ => false [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | Json::Obj(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 44 | | &Json::Vec(_) => true, [INFO] [stderr] 45 | | _ => false [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | Json::Vec(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 53 | | &Json::Var(x) => Some( x ), [INFO] [stderr] 54 | | _ => None [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *self { [INFO] [stderr] 53 | Json::Var(x) => Some( x ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 60 | | &Json::Vec( ref x) => Some(x), [INFO] [stderr] 61 | | _ => None [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Json::Vec( ref x) => Some(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 67 | | &Json::Obj( ref x ) => Some(x), [INFO] [stderr] 68 | | _ => None [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *self { [INFO] [stderr] 67 | Json::Obj( ref x ) => Some(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 76 | | &Json::Obj( ref x ) => x.get( key ), [INFO] [stderr] 77 | | _ => return None [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *self { [INFO] [stderr] 76 | Json::Obj( ref x ) => x.get( key ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | _ => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/buffer_walk.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | unsafe{ self.buffer.slice_unchecked( start, end ) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buffer_walk.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new<'b>( s: &'b str ) -> CharIter<'b>{ [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | CharIter{ [INFO] [stderr] 22 | | previous: None, [INFO] [stderr] 23 | | buffer: s, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new<'b>( buffer: &'b str ) -> Option> { [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | let mut c = CharIter::new( buffer ); [INFO] [stderr] 22 | | let _ = c.skip_whitespace(); [INFO] [stderr] 23 | | read_field( &mut c ) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | &Json::Var(_) => true, [INFO] [stderr] 31 | | _ => false [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Json::Var(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | &Json::Obj(_) => true, [INFO] [stderr] 38 | | _ => false [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | Json::Obj(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 44 | | &Json::Vec(_) => true, [INFO] [stderr] 45 | | _ => false [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | Json::Vec(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 53 | | &Json::Var(x) => Some( x ), [INFO] [stderr] 54 | | _ => None [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *self { [INFO] [stderr] 53 | Json::Var(x) => Some( x ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 60 | | &Json::Vec( ref x) => Some(x), [INFO] [stderr] 61 | | _ => None [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Json::Vec( ref x) => Some(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 67 | | &Json::Obj( ref x ) => Some(x), [INFO] [stderr] 68 | | _ => None [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *self { [INFO] [stderr] 67 | Json::Obj( ref x ) => Some(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 76 | | &Json::Obj( ref x ) => x.get( key ), [INFO] [stderr] 77 | | _ => return None [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *self { [INFO] [stderr] 76 | Json::Obj( ref x ) => x.get( key ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:356:2 [INFO] [stderr] | [INFO] [stderr] 356 | match &o[3] { [INFO] [stderr] | _____^ [INFO] [stderr] 357 | | &Json::Vec( ref x) => { [INFO] [stderr] 358 | | match x[0] { [INFO] [stderr] 359 | | Json::Var(y) => assert_eq!(y, "0"), [INFO] [stderr] ... | [INFO] [stderr] 367 | | _ => panic!("Type Mismatch") [INFO] [stderr] 368 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 356 | match o[3] { [INFO] [stderr] 357 | Json::Vec( ref x) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "247ee2d02fe54e4955e06f23b4c40b988aed3df07c9a62151bdb0833b7b42bac"` [INFO] running `"docker" "rm" "-f" "247ee2d02fe54e4955e06f23b4c40b988aed3df07c9a62151bdb0833b7b42bac"` [INFO] [stdout] 247ee2d02fe54e4955e06f23b4c40b988aed3df07c9a62151bdb0833b7b42bac