[INFO] updating cached repository llde/rCrawly [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/llde/rCrawly [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/llde/rCrawly" "work/ex/clippy-test-run/sources/stable/gh/llde/rCrawly"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/llde/rCrawly'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/llde/rCrawly" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llde/rCrawly"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llde/rCrawly'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 353edae7df658dcf1e52a62b1f4a5b70f975df22 [INFO] sha for GitHub repo llde/rCrawly: 353edae7df658dcf1e52a62b1f4a5b70f975df22 [INFO] validating manifest of llde/rCrawly on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of llde/rCrawly on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing llde/rCrawly [INFO] finished frobbing llde/rCrawly [INFO] frobbed toml for llde/rCrawly written to work/ex/clippy-test-run/sources/stable/gh/llde/rCrawly/Cargo.toml [INFO] started frobbing llde/rCrawly [INFO] finished frobbing llde/rCrawly [INFO] frobbed toml for llde/rCrawly written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llde/rCrawly/Cargo.toml [INFO] crate llde/rCrawly has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting llde/rCrawly against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/llde/rCrawly:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2dbaaa94cf15795053daa32413329161660cdcff4609666eece18d010a67eef8 [INFO] running `"docker" "start" "-a" "2dbaaa94cf15795053daa32413329161660cdcff4609666eece18d010a67eef8"` [INFO] [stderr] Compiling deque v0.3.2 [INFO] [stderr] Compiling num_cpus v1.5.0 [INFO] [stderr] Checking unicode-bidi v0.3.2 [INFO] [stderr] Checking mime v0.2.5 [INFO] [stderr] Compiling hyper v0.10.10 [INFO] [stderr] Compiling string_cache_codegen v0.3.1 [INFO] [stderr] Compiling html5ever v0.14.1 [INFO] [stderr] Checking tendril v0.2.4 [INFO] [stderr] Compiling rayon-core v1.0.0 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Compiling string_cache v0.4.0 [INFO] [stderr] Compiling html5ever-atoms v0.2.2 [INFO] [stderr] Compiling rayon v0.7.0 [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] Compiling ring v0.9.7 [INFO] [stderr] Checking webpki v0.12.1 [INFO] [stderr] Checking select v0.4.0 [INFO] [stderr] Checking webpki-roots v0.10.0 [INFO] [stderr] Checking rustls v0.8.0 [INFO] [stderr] Checking hyper-rustls v0.6.0 [INFO] [stderr] Checking rCrawly v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/loadResult.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | LoadResult{uri: uri, parsed : None, exception : Some(err)} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/loadResult.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | LoadResult{uri : uri, parsed : Some(content), exception : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/loadResult.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | LoadResult{uri : uri, parsed : None , exception : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/Parsing.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Parsed{links: links } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `links` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/CrawlerCore/mod.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | CrawlerResult{url : url, follow : true , links : Some(linkg), bad_links : Some(linkb), error : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/CrawlerCore/mod.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | CrawlerResult{url : url, follow : false, links : None, bad_links : None, error : Some(error)} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/CrawlerCore/mod.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | CrawlerResult{url : url, follow: false, links : None, bad_links : None, error : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/loadResult.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | LoadResult{uri: uri, parsed : None, exception : Some(err)} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/loadResult.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | LoadResult{uri : uri, parsed : Some(content), exception : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/loadResult.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | LoadResult{uri : uri, parsed : None , exception : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/LoaderCore/Parsing.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Parsed{links: links } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `links` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/CrawlerCore/mod.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | CrawlerResult{url : url, follow : true , links : Some(linkg), bad_links : Some(linkb), error : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/CrawlerCore/mod.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | CrawlerResult{url : url, follow : false, links : None, bad_links : None, error : Some(error)} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/CrawlerCore/mod.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | CrawlerResult{url : url, follow: false, links : None, bad_links : None, error : None} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/main.rs:6:11 [INFO] [stderr] | [INFO] [stderr] 6 | use std::{time,thread}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/GUI/mod.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | cr [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/GUI/mod.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | let cr = Crawly{name : "Crawly".to_string(), version : 1}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex`, `mpsc` [INFO] [stderr] --> src/API/future.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::sync::{Arc, Mutex,RwLock,mpsc}; [INFO] [stderr] | ^^^ ^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender` [INFO] [stderr] --> src/API/future.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/main.rs:6:11 [INFO] [stderr] | [INFO] [stderr] 6 | use std::{time,thread}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/GUI/mod.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | cr [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/GUI/mod.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | let cr = Crawly{name : "Crawly".to_string(), version : 1}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex`, `mpsc` [INFO] [stderr] --> src/API/future.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use std::sync::{Arc, Mutex,RwLock,mpsc}; [INFO] [stderr] | ^^^ ^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender` [INFO] [stderr] --> src/API/future.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `content` [INFO] [stderr] --> src/LoaderCore/loader.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | Ok(mut content) => { [INFO] [stderr] | ^^^^^^^ help: consider using `_content` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | for n in 0..(num+1){ [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cont` [INFO] [stderr] --> src/CrawlerCore/mod.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | let cont = self.loaded.lock().unwrap().contains(&url); [INFO] [stderr] | ^^^^ help: consider using `_cont` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `url` [INFO] [stderr] --> src/CrawlerCore/mod.rs:202:23 [INFO] [stderr] | [INFO] [stderr] 202 | fn get_uri(&self, url : Url) -> CrawlerResult{ [INFO] [stderr] | ^^^ help: consider using `_url` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/LoaderCore/loader.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | Ok(mut content) => { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SUSPENDED` [INFO] [stderr] --> src/CrawlerCore/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | SUSPENDED, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TERMINATED_UNEXPECTLY` [INFO] [stderr] --> src/CrawlerCore/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | TERMINATED_UNEXPECTLY, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CANCELLED` [INFO] [stderr] --> src/CrawlerCore/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | CANCELLED, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `url` [INFO] [stderr] --> src/CrawlerCore/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | url : Url, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `follow` [INFO] [stderr] --> src/CrawlerCore/mod.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | follow : bool, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `links` [INFO] [stderr] --> src/CrawlerCore/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | links : Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `bad_links` [INFO] [stderr] --> src/CrawlerCore/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | bad_links : Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `error` [INFO] [stderr] --> src/CrawlerCore/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | error : Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cancel` [INFO] [stderr] --> src/CrawlerCore/mod.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | fn cancel(&self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_uri` [INFO] [stderr] --> src/CrawlerCore/mod.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | fn get_uri(&self, url : Url) -> CrawlerResult{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_progressions` [INFO] [stderr] --> src/CrawlerCore/mod.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | fn get_progressions(&self) -> MutexGuard>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/GUI/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | name : String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/GUI/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | version : u8, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PAUSED` [INFO] [stderr] --> src/API/executors.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | PAUSED, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `task_count` [INFO] [stderr] --> src/API/executors.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | task_count : u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FAILED` [INFO] [stderr] --> src/API/future.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | FAILED, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `LoaderCore::loader::GondorLoader` [INFO] [stderr] --> src/LoaderCore/loader.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> GondorLoader{ [INFO] [stderr] 15 | | GondorLoader {client: Client::with_connector(HttpsConnector::new(TlsClient::new()))} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/LoaderCore/loader.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | content.read_to_string(&mut resp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | for n in 0..(num+1){ [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | self.workers.shutdown(now); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/CrawlerCore/mod.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | let ref status = self.status.as_ref().lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^---------------------------------------- help: try: `let status = &self.status.as_ref().lock().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/CrawlerCore/mod.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | / let fut; [INFO] [stderr] 98 | | if pred_arc.accept(url) { [INFO] [stderr] 99 | | fut = async_arc.loadAsync(url.clone()); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | else{ [INFO] [stderr] 102 | | fut = async_arc.checkAsync(url.clone()); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let fut = if pred_arc.accept(url) { async_arc.loadAsync(url.clone()) } else { async_arc.checkAsync(url.clone()) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:147:44 [INFO] [stderr] | [INFO] [stderr] 147 | if tl == true { continue; } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `tl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:149:44 [INFO] [stderr] | [INFO] [stderr] 149 | if ll == true { continue; } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `ll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:151:44 [INFO] [stderr] | [INFO] [stderr] 151 | if el == true { continue; } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `el` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:183:12 [INFO] [stderr] | [INFO] [stderr] 183 | if tl == true{return;} [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `tl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | if ll == true {return;} [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `ll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:187:12 [INFO] [stderr] | [INFO] [stderr] 187 | if el == true {return;} [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `el` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GUI::Crawly` [INFO] [stderr] --> src/GUI/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Crawly{ [INFO] [stderr] 9 | | let cr = Crawly{name : "Crawly".to_string(), version : 1}; [INFO] [stderr] 10 | | cr [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/API/executors.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | el.run(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/API/future.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let x = self.stat.read().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.stat.read().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / if other.domain() == self.dominio.domain(){ [INFO] [stderr] 30 | | true [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | else{false} [INFO] [stderr] | |___________________^ help: you can reduce it to: `other.domain() == self.dominio.domain()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: unused variable: `content` [INFO] [stderr] --> src/LoaderCore/loader.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | Ok(mut content) => { [INFO] [stderr] | ^^^^^^^ help: consider using `_content` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | for n in 0..(num+1){ [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cont` [INFO] [stderr] --> src/CrawlerCore/mod.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | let cont = self.loaded.lock().unwrap().contains(&url); [INFO] [stderr] | ^^^^ help: consider using `_cont` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `url` [INFO] [stderr] --> src/CrawlerCore/mod.rs:202:23 [INFO] [stderr] | [INFO] [stderr] 202 | fn get_uri(&self, url : Url) -> CrawlerResult{ [INFO] [stderr] | ^^^ help: consider using `_url` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/LoaderCore/loader.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | Ok(mut content) => { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SUSPENDED` [INFO] [stderr] --> src/CrawlerCore/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | SUSPENDED, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TERMINATED_UNEXPECTLY` [INFO] [stderr] --> src/CrawlerCore/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | TERMINATED_UNEXPECTLY, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CANCELLED` [INFO] [stderr] --> src/CrawlerCore/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | CANCELLED, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `url` [INFO] [stderr] --> src/CrawlerCore/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | url : Url, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `follow` [INFO] [stderr] --> src/CrawlerCore/mod.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | follow : bool, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `links` [INFO] [stderr] --> src/CrawlerCore/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | links : Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `bad_links` [INFO] [stderr] --> src/CrawlerCore/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | bad_links : Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `error` [INFO] [stderr] --> src/CrawlerCore/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | error : Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cancel` [INFO] [stderr] --> src/CrawlerCore/mod.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | fn cancel(&self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_uri` [INFO] [stderr] --> src/CrawlerCore/mod.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | fn get_uri(&self, url : Url) -> CrawlerResult{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_progressions` [INFO] [stderr] --> src/CrawlerCore/mod.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | fn get_progressions(&self) -> MutexGuard>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/GUI/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | name : String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/GUI/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | version : u8, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PAUSED` [INFO] [stderr] --> src/API/executors.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | PAUSED, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `task_count` [INFO] [stderr] --> src/API/executors.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | task_count : u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FAILED` [INFO] [stderr] --> src/API/future.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | FAILED, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `LoaderCore::loader::GondorLoader` [INFO] [stderr] --> src/LoaderCore/loader.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> GondorLoader{ [INFO] [stderr] 15 | | GondorLoader {client: Client::with_connector(HttpsConnector::new(TlsClient::new()))} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/LoaderCore/loader.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | content.read_to_string(&mut resp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | for n in 0..(num+1){ [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/AsyncLoaderCore/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | self.workers.shutdown(now); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/CrawlerCore/mod.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | let ref status = self.status.as_ref().lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^---------------------------------------- help: try: `let status = &self.status.as_ref().lock().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/CrawlerCore/mod.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | / let fut; [INFO] [stderr] 98 | | if pred_arc.accept(url) { [INFO] [stderr] 99 | | fut = async_arc.loadAsync(url.clone()); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | else{ [INFO] [stderr] 102 | | fut = async_arc.checkAsync(url.clone()); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let fut = if pred_arc.accept(url) { async_arc.loadAsync(url.clone()) } else { async_arc.checkAsync(url.clone()) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:147:44 [INFO] [stderr] | [INFO] [stderr] 147 | if tl == true { continue; } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `tl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:149:44 [INFO] [stderr] | [INFO] [stderr] 149 | if ll == true { continue; } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `ll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:151:44 [INFO] [stderr] | [INFO] [stderr] 151 | if el == true { continue; } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `el` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:183:12 [INFO] [stderr] | [INFO] [stderr] 183 | if tl == true{return;} [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `tl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | if ll == true {return;} [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `ll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/CrawlerCore/mod.rs:187:12 [INFO] [stderr] | [INFO] [stderr] 187 | if el == true {return;} [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `el` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GUI::Crawly` [INFO] [stderr] --> src/GUI/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Crawly{ [INFO] [stderr] 9 | | let cr = Crawly{name : "Crawly".to_string(), version : 1}; [INFO] [stderr] 10 | | cr [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/API/executors.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | el.run(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/API/future.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let x = self.stat.read().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.stat.read().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / if other.domain() == self.dominio.domain(){ [INFO] [stderr] 30 | | true [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | else{false} [INFO] [stderr] | |___________________^ help: you can reduce it to: `other.domain() == self.dominio.domain()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.65s [INFO] running `"docker" "inspect" "2dbaaa94cf15795053daa32413329161660cdcff4609666eece18d010a67eef8"` [INFO] running `"docker" "rm" "-f" "2dbaaa94cf15795053daa32413329161660cdcff4609666eece18d010a67eef8"` [INFO] [stdout] 2dbaaa94cf15795053daa32413329161660cdcff4609666eece18d010a67eef8