[INFO] updating cached repository llambda/nary [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/llambda/nary [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/llambda/nary" "work/ex/clippy-test-run/sources/stable/gh/llambda/nary"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/llambda/nary'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/llambda/nary" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llambda/nary"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llambda/nary'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ef2f5ca3233b4524cebe2003fe93566edf740f7 [INFO] sha for GitHub repo llambda/nary: 8ef2f5ca3233b4524cebe2003fe93566edf740f7 [INFO] validating manifest of llambda/nary on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of llambda/nary on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing llambda/nary [INFO] finished frobbing llambda/nary [INFO] frobbed toml for llambda/nary written to work/ex/clippy-test-run/sources/stable/gh/llambda/nary/Cargo.toml [INFO] started frobbing llambda/nary [INFO] finished frobbing llambda/nary [INFO] frobbed toml for llambda/nary written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/llambda/nary/Cargo.toml [INFO] crate llambda/nary has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting llambda/nary against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/llambda/nary:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87d84d16f7ca84e4859dc023735e1d4c60257d63c1768a45f659e6c8534c1449 [INFO] running `"docker" "start" "-a" "87d84d16f7ca84e4859dc023735e1d4c60257d63c1768a45f659e6c8534c1449"` [INFO] [stderr] Compiling cc v1.0.20 [INFO] [stderr] Compiling ryu v0.2.5 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking tar v0.4.16 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling cmake v0.1.33 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Compiling libz-sys v1.0.20 [INFO] [stderr] Compiling curl-sys v0.4.8 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling libssh2-sys v0.2.10 [INFO] [stderr] Compiling libgit2-sys v0.7.7 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.74 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking nary v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] extern crate serde_derive; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `failure::err_msg` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use failure::err_msg; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return install_helper(root_path, install_dev_dependencies, &installed_deps); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `install_helper(root_path, install_dev_dependencies, &installed_deps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] extern crate serde_derive; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `failure::err_msg` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use failure::err_msg; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return install_helper(root_path, install_dev_dependencies, &installed_deps); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `install_helper(root_path, install_dev_dependencies, &installed_deps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | let mut cache_dir = home_dir().ok_or(NeedHomeDir)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | let mut cache_dir = home_dir().ok_or(NeedHomeDir)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/main.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | let mut fail = err.cause(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/main.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | let mut fail = err.cause(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:145:32 [INFO] [stderr] | [INFO] [stderr] 145 | let mut path = root_path.clone().to_path_buf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 145 | let mut path = &(*root_path).clone().to_path_buf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 145 | let mut path = &std::path::Path::clone(root_path).to_path_buf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:150:40 [INFO] [stderr] | [INFO] [stderr] 150 | let (repo, hash) = version.clone().split_at(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 150 | let (repo, hash) = &(*version).clone().split_at(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 150 | let (repo, hash) = &str::clone(version).split_at(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | let mut hash = hash.clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 152 | let mut hash = &(*hash).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 152 | let mut hash = &str::clone(hash).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | / match installed_deps.get(key) { [INFO] [stderr] 167 | | Some(installed_version) => if required_version.matches(installed_version) { [INFO] [stderr] 168 | | println!( [INFO] [stderr] 169 | | "Already have {} @ {}; don't need to install {}", [INFO] [stderr] ... | [INFO] [stderr] 176 | | None => (), [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | if let Some(installed_version) = installed_deps.get(key) { if required_version.matches(installed_version) { [INFO] [stderr] 167 | println!( [INFO] [stderr] 168 | "Already have {} @ {}; don't need to install {}", [INFO] [stderr] 169 | key, [INFO] [stderr] 170 | installed_version, [INFO] [stderr] 171 | required_version [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:201:18 [INFO] [stderr] | [INFO] [stderr] 201 | .ok_or(format_err!("Versions was not a JSON object. {}", url))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Versions was not a JSON object. {}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:219:30 [INFO] [stderr] | [INFO] [stderr] 219 | .ok_or(format_err!("tarball URL didn't convert to string"))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("tarball URL didn't convert to string"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nary`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:145:32 [INFO] [stderr] | [INFO] [stderr] 145 | let mut path = root_path.clone().to_path_buf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 145 | let mut path = &(*root_path).clone().to_path_buf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 145 | let mut path = &std::path::Path::clone(root_path).to_path_buf(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:150:40 [INFO] [stderr] | [INFO] [stderr] 150 | let (repo, hash) = version.clone().split_at(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 150 | let (repo, hash) = &(*version).clone().split_at(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 150 | let (repo, hash) = &str::clone(version).split_at(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | let mut hash = hash.clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 152 | let mut hash = &(*hash).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 152 | let mut hash = &str::clone(hash).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | / match installed_deps.get(key) { [INFO] [stderr] 167 | | Some(installed_version) => if required_version.matches(installed_version) { [INFO] [stderr] 168 | | println!( [INFO] [stderr] 169 | | "Already have {} @ {}; don't need to install {}", [INFO] [stderr] ... | [INFO] [stderr] 176 | | None => (), [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | if let Some(installed_version) = installed_deps.get(key) { if required_version.matches(installed_version) { [INFO] [stderr] 167 | println!( [INFO] [stderr] 168 | "Already have {} @ {}; don't need to install {}", [INFO] [stderr] 169 | key, [INFO] [stderr] 170 | installed_version, [INFO] [stderr] 171 | required_version [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:201:18 [INFO] [stderr] | [INFO] [stderr] 201 | .ok_or(format_err!("Versions was not a JSON object. {}", url))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Versions was not a JSON object. {}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:219:30 [INFO] [stderr] | [INFO] [stderr] 219 | .ok_or(format_err!("tarball URL didn't convert to string"))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("tarball URL didn't convert to string"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nary`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "87d84d16f7ca84e4859dc023735e1d4c60257d63c1768a45f659e6c8534c1449"` [INFO] running `"docker" "rm" "-f" "87d84d16f7ca84e4859dc023735e1d4c60257d63c1768a45f659e6c8534c1449"` [INFO] [stdout] 87d84d16f7ca84e4859dc023735e1d4c60257d63c1768a45f659e6c8534c1449