[INFO] updating cached repository lj-ditrapani/game-of-life-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lj-ditrapani/game-of-life-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lj-ditrapani/game-of-life-rust" "work/ex/clippy-test-run/sources/stable/gh/lj-ditrapani/game-of-life-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lj-ditrapani/game-of-life-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lj-ditrapani/game-of-life-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lj-ditrapani/game-of-life-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lj-ditrapani/game-of-life-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe7647c8993d8f4a1c1ed264c11181f3c98da234 [INFO] sha for GitHub repo lj-ditrapani/game-of-life-rust: fe7647c8993d8f4a1c1ed264c11181f3c98da234 [INFO] validating manifest of lj-ditrapani/game-of-life-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lj-ditrapani/game-of-life-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lj-ditrapani/game-of-life-rust [INFO] finished frobbing lj-ditrapani/game-of-life-rust [INFO] frobbed toml for lj-ditrapani/game-of-life-rust written to work/ex/clippy-test-run/sources/stable/gh/lj-ditrapani/game-of-life-rust/Cargo.toml [INFO] started frobbing lj-ditrapani/game-of-life-rust [INFO] finished frobbing lj-ditrapani/game-of-life-rust [INFO] frobbed toml for lj-ditrapani/game-of-life-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lj-ditrapani/game-of-life-rust/Cargo.toml [INFO] crate lj-ditrapani/game-of-life-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lj-ditrapani/game-of-life-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lj-ditrapani/game-of-life-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12adcb9cae7841bddd6e724e686db3277144bb16f71c81f1d5b62d7b1e912689 [INFO] running `"docker" "start" "-a" "12adcb9cae7841bddd6e724e686db3277144bb16f71c81f1d5b62d7b1e912689"` [INFO] [stderr] Checking life v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | fn next_life_state(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / match self.live { [INFO] [stderr] 72 | | true => { [INFO] [stderr] 73 | | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 74 | | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if self.live { [INFO] [stderr] 72 | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 73 | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] 74 | match top { [INFO] [stderr] 75 | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 76 | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | / match top { [INFO] [stderr] 76 | | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 77 | | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "/o.o\\").unwrap() } else { write!(t, "\\---/").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / match top { [INFO] [stderr] 84 | | true => write!(t, "| ").unwrap(), [INFO] [stderr] 85 | | false => write!(t, "|____").unwrap(), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "| ").unwrap() } else { write!(t, "|____").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | fn new(points: &Vec<(usize, usize)>) -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | .filter(|&z| z == true) [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | fn next_life_state(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / match self.live { [INFO] [stderr] 72 | | true => { [INFO] [stderr] 73 | | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 74 | | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if self.live { [INFO] [stderr] 72 | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 73 | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] 74 | match top { [INFO] [stderr] 75 | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 76 | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | / match top { [INFO] [stderr] 76 | | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 77 | | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "/o.o\\").unwrap() } else { write!(t, "\\---/").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / match top { [INFO] [stderr] 84 | | true => write!(t, "| ").unwrap(), [INFO] [stderr] 85 | | false => write!(t, "|____").unwrap(), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "| ").unwrap() } else { write!(t, "|____").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | fn new(points: &Vec<(usize, usize)>) -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | .filter(|&z| z == true) [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `"docker" "inspect" "12adcb9cae7841bddd6e724e686db3277144bb16f71c81f1d5b62d7b1e912689"` [INFO] running `"docker" "rm" "-f" "12adcb9cae7841bddd6e724e686db3277144bb16f71c81f1d5b62d7b1e912689"` [INFO] [stdout] 12adcb9cae7841bddd6e724e686db3277144bb16f71c81f1d5b62d7b1e912689