[INFO] updating cached repository liyuntao/kong-init [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/liyuntao/kong-init [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/liyuntao/kong-init" "work/ex/clippy-test-run/sources/stable/gh/liyuntao/kong-init"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/liyuntao/kong-init'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/liyuntao/kong-init" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liyuntao/kong-init"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liyuntao/kong-init'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5572f1a6ccd9e93303e0d7f15fa109a3087ab425 [INFO] sha for GitHub repo liyuntao/kong-init: 5572f1a6ccd9e93303e0d7f15fa109a3087ab425 [INFO] validating manifest of liyuntao/kong-init on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liyuntao/kong-init on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liyuntao/kong-init [INFO] finished frobbing liyuntao/kong-init [INFO] frobbed toml for liyuntao/kong-init written to work/ex/clippy-test-run/sources/stable/gh/liyuntao/kong-init/Cargo.toml [INFO] started frobbing liyuntao/kong-init [INFO] finished frobbing liyuntao/kong-init [INFO] frobbed toml for liyuntao/kong-init written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liyuntao/kong-init/Cargo.toml [INFO] crate liyuntao/kong-init has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liyuntao/kong-init against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/liyuntao/kong-init:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdd1fe581d3833f01be389998b7e99308f4917353d5bc37ccdeb12c2b9082a1d [INFO] running `"docker" "start" "-a" "cdd1fe581d3833f01be389998b7e99308f4917353d5bc37ccdeb12c2b9082a1d"` [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking encoding_rs v0.8.8 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling openssl-sys v0.9.36 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling openssl v0.10.12 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking pretty_env_logger v0.2.4 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking kong-init v0.8.0-rc-3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:50:58 [INFO] [stderr] | [INFO] [stderr] 50 | return KongApiClient { base_url: kong_admin_url, client: client }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:50:58 [INFO] [stderr] | [INFO] [stderr] 50 | return KongApiClient { base_url: kong_admin_url, client: client }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return KongApiClient { base_url: kong_admin_url, client: client }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `KongApiClient { base_url: kong_admin_url, client: client }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return self.client.get(&format!("{}/", self.base_url)) [INFO] [stderr] 55 | | .send() [INFO] [stderr] 56 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | self.client.get(&format!("{}/", self.base_url)) [INFO] [stderr] 55 | .send() [INFO] [stderr] 56 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return self.client.get(&list_srv_url) [INFO] [stderr] 66 | | .send() [INFO] [stderr] 67 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | self.client.get(&list_srv_url) [INFO] [stderr] 66 | .send() [INFO] [stderr] 67 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / return match self.client.post(&format!("{}/services", self.base_url)) [INFO] [stderr] 107 | | .json(payload) [INFO] [stderr] 108 | | .send() { [INFO] [stderr] 109 | | Err(why) => { [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 106 | match self.client.post(&format!("{}/services", self.base_url)) [INFO] [stderr] 107 | .json(payload) [INFO] [stderr] 108 | .send() { [INFO] [stderr] 109 | Err(why) => { [INFO] [stderr] 110 | error!("add_service: {}", why); [INFO] [stderr] 111 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | / return self.client.get(&list_route_url) [INFO] [stderr] 134 | | .send() [INFO] [stderr] 135 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 133 | self.client.get(&list_route_url) [INFO] [stderr] 134 | .send() [INFO] [stderr] 135 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / return self.client.get(&list_plugins_url) [INFO] [stderr] 181 | | .send() [INFO] [stderr] 182 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | self.client.get(&list_plugins_url) [INFO] [stderr] 181 | .send() [INFO] [stderr] 182 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:236:21 [INFO] [stderr] | [INFO] [stderr] 236 | / return resp.json::() [INFO] [stderr] 237 | | .map(|obj| obj.id) [INFO] [stderr] 238 | | .ok(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | resp.json::() [INFO] [stderr] 237 | .map(|obj| obj.id) [INFO] [stderr] 238 | .ok() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:241:21 [INFO] [stderr] | [INFO] [stderr] 241 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / return self.client.get(&format!("{}/apis", self.base_url)) [INFO] [stderr] 249 | | .send() [INFO] [stderr] 250 | | .and_then(|mut res| res.json::()) [INFO] [stderr] 251 | | .map(|list_api_info| list_api_info.total); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 248 | self.client.get(&format!("{}/apis", self.base_url)) [INFO] [stderr] 249 | .send() [INFO] [stderr] 250 | .and_then(|mut res| res.json::()) [INFO] [stderr] 251 | .map(|list_api_info| list_api_info.total) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / return match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 294 | | .json(&payload) [INFO] [stderr] 295 | | .send() { [INFO] [stderr] 296 | | Err(why) => { [INFO] [stderr] ... | [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 293 | match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 294 | .json(&payload) [INFO] [stderr] 295 | .send() { [INFO] [stderr] 296 | Err(why) => { [INFO] [stderr] 297 | error!("upsert_consumer: {}", why); [INFO] [stderr] 298 | String::from("error_id") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:319:9 [INFO] [stderr] | [INFO] [stderr] 319 | / return match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 320 | | .json(&payload) [INFO] [stderr] 321 | | .send() { [INFO] [stderr] 322 | | Err(why) => { [INFO] [stderr] ... | [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 319 | match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 320 | .json(&payload) [INFO] [stderr] 321 | .send() { [INFO] [stderr] 322 | Err(why) => { [INFO] [stderr] 323 | error!("upsert_consumer: {}", why); [INFO] [stderr] 324 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / return ExecutionContext { [INFO] [stderr] 112 | | api_names: Vec::new(), [INFO] [stderr] 113 | | kong_cli: Box::new(kong_cli), [INFO] [stderr] 114 | | support_api: false, [INFO] [stderr] ... | [INFO] [stderr] 117 | | route_name_id_mapping: HashMap::new(), [INFO] [stderr] 118 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 111 | ExecutionContext { [INFO] [stderr] 112 | api_names: Vec::new(), [INFO] [stderr] 113 | kong_cli: Box::new(kong_cli), [INFO] [stderr] 114 | support_api: false, [INFO] [stderr] 115 | support_service_route: false, [INFO] [stderr] 116 | service_name_id_mapping: HashMap::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / return match cli.get_node_info() { [INFO] [stderr] 170 | | Err(why) => { [INFO] [stderr] 171 | | error!("Could not reach Kong on {}; reason: {}", cli.base_url, why); [INFO] [stderr] 172 | | false [INFO] [stderr] ... | [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 169 | match cli.get_node_info() { [INFO] [stderr] 170 | Err(why) => { [INFO] [stderr] 171 | error!("Could not reach Kong on {}; reason: {}", cli.base_url, why); [INFO] [stderr] 172 | false [INFO] [stderr] 173 | } [INFO] [stderr] 174 | Ok(kong_info) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | return after_d; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `after_d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return KongApiClient { base_url: kong_admin_url, client: client }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `KongApiClient { base_url: kong_admin_url, client: client }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return self.client.get(&format!("{}/", self.base_url)) [INFO] [stderr] 55 | | .send() [INFO] [stderr] 56 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | self.client.get(&format!("{}/", self.base_url)) [INFO] [stderr] 55 | .send() [INFO] [stderr] 56 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return self.client.get(&list_srv_url) [INFO] [stderr] 66 | | .send() [INFO] [stderr] 67 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | self.client.get(&list_srv_url) [INFO] [stderr] 66 | .send() [INFO] [stderr] 67 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / return match self.client.post(&format!("{}/services", self.base_url)) [INFO] [stderr] 107 | | .json(payload) [INFO] [stderr] 108 | | .send() { [INFO] [stderr] 109 | | Err(why) => { [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 106 | match self.client.post(&format!("{}/services", self.base_url)) [INFO] [stderr] 107 | .json(payload) [INFO] [stderr] 108 | .send() { [INFO] [stderr] 109 | Err(why) => { [INFO] [stderr] 110 | error!("add_service: {}", why); [INFO] [stderr] 111 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | / return self.client.get(&list_route_url) [INFO] [stderr] 134 | | .send() [INFO] [stderr] 135 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 133 | self.client.get(&list_route_url) [INFO] [stderr] 134 | .send() [INFO] [stderr] 135 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / return self.client.get(&list_plugins_url) [INFO] [stderr] 181 | | .send() [INFO] [stderr] 182 | | .and_then(|mut res| res.json::()); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | self.client.get(&list_plugins_url) [INFO] [stderr] 181 | .send() [INFO] [stderr] 182 | .and_then(|mut res| res.json::()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:236:21 [INFO] [stderr] | [INFO] [stderr] 236 | / return resp.json::() [INFO] [stderr] 237 | | .map(|obj| obj.id) [INFO] [stderr] 238 | | .ok(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | resp.json::() [INFO] [stderr] 237 | .map(|obj| obj.id) [INFO] [stderr] 238 | .ok() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:241:21 [INFO] [stderr] | [INFO] [stderr] 241 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / return self.client.get(&format!("{}/apis", self.base_url)) [INFO] [stderr] 249 | | .send() [INFO] [stderr] 250 | | .and_then(|mut res| res.json::()) [INFO] [stderr] 251 | | .map(|list_api_info| list_api_info.total); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 248 | self.client.get(&format!("{}/apis", self.base_url)) [INFO] [stderr] 249 | .send() [INFO] [stderr] 250 | .and_then(|mut res| res.json::()) [INFO] [stderr] 251 | .map(|list_api_info| list_api_info.total) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / return match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 294 | | .json(&payload) [INFO] [stderr] 295 | | .send() { [INFO] [stderr] 296 | | Err(why) => { [INFO] [stderr] ... | [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 293 | match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 294 | .json(&payload) [INFO] [stderr] 295 | .send() { [INFO] [stderr] 296 | Err(why) => { [INFO] [stderr] 297 | error!("upsert_consumer: {}", why); [INFO] [stderr] 298 | String::from("error_id") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:319:9 [INFO] [stderr] | [INFO] [stderr] 319 | / return match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 320 | | .json(&payload) [INFO] [stderr] 321 | | .send() { [INFO] [stderr] 322 | | Err(why) => { [INFO] [stderr] ... | [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 319 | match self.client.post(&format!("{}/consumers", self.base_url)) [INFO] [stderr] 320 | .json(&payload) [INFO] [stderr] 321 | .send() { [INFO] [stderr] 322 | Err(why) => { [INFO] [stderr] 323 | error!("upsert_consumer: {}", why); [INFO] [stderr] 324 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / return ExecutionContext { [INFO] [stderr] 112 | | api_names: Vec::new(), [INFO] [stderr] 113 | | kong_cli: Box::new(kong_cli), [INFO] [stderr] 114 | | support_api: false, [INFO] [stderr] ... | [INFO] [stderr] 117 | | route_name_id_mapping: HashMap::new(), [INFO] [stderr] 118 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 111 | ExecutionContext { [INFO] [stderr] 112 | api_names: Vec::new(), [INFO] [stderr] 113 | kong_cli: Box::new(kong_cli), [INFO] [stderr] 114 | support_api: false, [INFO] [stderr] 115 | support_service_route: false, [INFO] [stderr] 116 | service_name_id_mapping: HashMap::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / return match cli.get_node_info() { [INFO] [stderr] 170 | | Err(why) => { [INFO] [stderr] 171 | | error!("Could not reach Kong on {}; reason: {}", cli.base_url, why); [INFO] [stderr] 172 | | false [INFO] [stderr] ... | [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 169 | match cli.get_node_info() { [INFO] [stderr] 170 | Err(why) => { [INFO] [stderr] 171 | error!("Could not reach Kong on {}; reason: {}", cli.base_url, why); [INFO] [stderr] 172 | false [INFO] [stderr] 173 | } [INFO] [stderr] 174 | Ok(kong_info) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | return after_d; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `after_d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | if !raw_header.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client.rs:347:33 [INFO] [stderr] | [INFO] [stderr] 347 | json_payload.insert(format!("{}", k), v.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `k.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:191:44 [INFO] [stderr] | [INFO] [stderr] 191 | } else if "0.33" == ee_ver { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 192 | | "0.13.1" [INFO] [stderr] 193 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:189:44 [INFO] [stderr] | [INFO] [stderr] 189 | } else if "0.32" == ee_ver { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 190 | | "0.13.1" [INFO] [stderr] 191 | | } else if "0.33" == ee_ver { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:224:18 [INFO] [stderr] | [INFO] [stderr] 224 | .map_err(|io_err| Error::io(io_err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | .map(|lkc| ConfFileStyle::Legacy(lkc)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ConfFileStyle::Legacy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:234:26 [INFO] [stderr] | [INFO] [stderr] 234 | .map(|kc| ConfFileStyle::Suggested(kc)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ConfFileStyle::Suggested` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:261:48 [INFO] [stderr] | [INFO] [stderr] 261 | let vec: Vec<&str> = cap_str.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | if !raw_header.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:346:92 [INFO] [stderr] | [INFO] [stderr] 346 | others => (LegacyPluginAppliedType::SOME, Some(Vec::from_iter(others.split(",").map(String::from)))), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:380:26 [INFO] [stderr] | [INFO] [stderr] 380 | let service_id = context.service_name_id_mapping.get(&route_info.apply_to).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.service_name_id_mapping[&route_info.apply_to]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:404:46 [INFO] [stderr] | [INFO] [stderr] 404 | let tmp = Vec::from_iter(t.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | context.service_name_id_mapping.get(s_name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.service_name_id_mapping[s_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:414:46 [INFO] [stderr] | [INFO] [stderr] 414 | let tmp = Vec::from_iter(t.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | context.route_name_id_mapping.get(r_name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.route_name_id_mapping[r_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client.rs:347:33 [INFO] [stderr] | [INFO] [stderr] 347 | json_payload.insert(format!("{}", k), v.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `k.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Could not compile `kong-init`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:191:44 [INFO] [stderr] | [INFO] [stderr] 191 | } else if "0.33" == ee_ver { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 192 | | "0.13.1" [INFO] [stderr] 193 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:189:44 [INFO] [stderr] | [INFO] [stderr] 189 | } else if "0.32" == ee_ver { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 190 | | "0.13.1" [INFO] [stderr] 191 | | } else if "0.33" == ee_ver { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:224:18 [INFO] [stderr] | [INFO] [stderr] 224 | .map_err(|io_err| Error::io(io_err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | .map(|lkc| ConfFileStyle::Legacy(lkc)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ConfFileStyle::Legacy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:234:26 [INFO] [stderr] | [INFO] [stderr] 234 | .map(|kc| ConfFileStyle::Suggested(kc)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ConfFileStyle::Suggested` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:261:48 [INFO] [stderr] | [INFO] [stderr] 261 | let vec: Vec<&str> = cap_str.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:346:92 [INFO] [stderr] | [INFO] [stderr] 346 | others => (LegacyPluginAppliedType::SOME, Some(Vec::from_iter(others.split(",").map(String::from)))), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:380:26 [INFO] [stderr] | [INFO] [stderr] 380 | let service_id = context.service_name_id_mapping.get(&route_info.apply_to).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.service_name_id_mapping[&route_info.apply_to]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:404:46 [INFO] [stderr] | [INFO] [stderr] 404 | let tmp = Vec::from_iter(t.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | context.service_name_id_mapping.get(s_name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.service_name_id_mapping[s_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:414:46 [INFO] [stderr] | [INFO] [stderr] 414 | let tmp = Vec::from_iter(t.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | context.route_name_id_mapping.get(r_name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.route_name_id_mapping[r_name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kong-init`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cdd1fe581d3833f01be389998b7e99308f4917353d5bc37ccdeb12c2b9082a1d"` [INFO] running `"docker" "rm" "-f" "cdd1fe581d3833f01be389998b7e99308f4917353d5bc37ccdeb12c2b9082a1d"` [INFO] [stdout] cdd1fe581d3833f01be389998b7e99308f4917353d5bc37ccdeb12c2b9082a1d