[INFO] updating cached repository little-dude/aian-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/little-dude/aian-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/little-dude/aian-rust" "work/ex/clippy-test-run/sources/stable/gh/little-dude/aian-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/little-dude/aian-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/little-dude/aian-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/little-dude/aian-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/little-dude/aian-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a66798b9e457c6ad76c48f1a25ae8b1a7cd09e25 [INFO] sha for GitHub repo little-dude/aian-rust: a66798b9e457c6ad76c48f1a25ae8b1a7cd09e25 [INFO] validating manifest of little-dude/aian-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of little-dude/aian-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing little-dude/aian-rust [INFO] finished frobbing little-dude/aian-rust [INFO] frobbed toml for little-dude/aian-rust written to work/ex/clippy-test-run/sources/stable/gh/little-dude/aian-rust/Cargo.toml [INFO] started frobbing little-dude/aian-rust [INFO] finished frobbing little-dude/aian-rust [INFO] frobbed toml for little-dude/aian-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/little-dude/aian-rust/Cargo.toml [INFO] crate little-dude/aian-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting little-dude/aian-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/little-dude/aian-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b3a86736cf92e7af876df2ce0dff133b6bea0cb7afd9e76f84b33039809e1ea4 [INFO] running `"docker" "start" "-a" "b3a86736cf92e7af876df2ce0dff133b6bea0cb7afd9e76f84b33039809e1ea4"` [INFO] [stderr] Checking regex-syntax v0.3.7 [INFO] [stderr] Checking regex v0.1.77 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.3.1 [INFO] [stderr] Checking aian v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/sorting.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 68 | | if slice[0] > slice[2] { [INFO] [stderr] 69 | | // slice[1] >= slice[0] > slice[2] [INFO] [stderr] 70 | | 0 [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | } else if slice[0] > slice[2] { [INFO] [stderr] 68 | // slice[1] >= slice[0] > slice[2] [INFO] [stderr] 69 | 0 [INFO] [stderr] 70 | } else if slice[2] > slice[1] { [INFO] [stderr] 71 | // slice[2] > slice[1] >= slice[0] [INFO] [stderr] 72 | 1 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/sorting.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 68 | | if slice[0] > slice[2] { [INFO] [stderr] 69 | | // slice[1] >= slice[0] > slice[2] [INFO] [stderr] 70 | | 0 [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | } else if slice[0] > slice[2] { [INFO] [stderr] 68 | // slice[1] >= slice[0] > slice[2] [INFO] [stderr] 69 | 0 [INFO] [stderr] 70 | } else if slice[2] > slice[1] { [INFO] [stderr] 71 | // slice[2] > slice[1] >= slice[0] [INFO] [stderr] 72 | 1 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sorting.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | if slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sorting.rs:139:27 [INFO] [stderr] | [INFO] [stderr] 139 | qsort(&mut values[0..pivot+1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=pivot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sorting.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | if slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sorting.rs:139:27 [INFO] [stderr] | [INFO] [stderr] 139 | qsort(&mut values[0..pivot+1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=pivot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/sorting.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for in values.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/sorting.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | for i in 3..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 164 | for in values.iter().skip(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/sorting.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 175 | for in values.iter().take(5) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/sorting.rs:178:14 [INFO] [stderr] | [INFO] [stderr] 178 | for i in 5..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 178 | for in values.iter().skip(5) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.68s [INFO] running `"docker" "inspect" "b3a86736cf92e7af876df2ce0dff133b6bea0cb7afd9e76f84b33039809e1ea4"` [INFO] running `"docker" "rm" "-f" "b3a86736cf92e7af876df2ce0dff133b6bea0cb7afd9e76f84b33039809e1ea4"` [INFO] [stdout] b3a86736cf92e7af876df2ce0dff133b6bea0cb7afd9e76f84b33039809e1ea4