[INFO] updating cached repository lislis/piston-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lislis/piston-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lislis/piston-playground" "work/ex/clippy-test-run/sources/stable/gh/lislis/piston-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lislis/piston-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lislis/piston-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lislis/piston-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lislis/piston-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3241d5b5eb24f25da697e2a6841ebb90f0648113 [INFO] sha for GitHub repo lislis/piston-playground: 3241d5b5eb24f25da697e2a6841ebb90f0648113 [INFO] validating manifest of lislis/piston-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lislis/piston-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lislis/piston-playground [INFO] finished frobbing lislis/piston-playground [INFO] frobbed toml for lislis/piston-playground written to work/ex/clippy-test-run/sources/stable/gh/lislis/piston-playground/Cargo.toml [INFO] started frobbing lislis/piston-playground [INFO] finished frobbing lislis/piston-playground [INFO] frobbed toml for lislis/piston-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lislis/piston-playground/Cargo.toml [INFO] crate lislis/piston-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lislis/piston-playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lislis/piston-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2dc0f08c6a2bd50ad3e8579de8a2906312ed02a399684ce6f305ae0aa078ef01 [INFO] running `"docker" "start" "-a" "2dc0f08c6a2bd50ad3e8579de8a2906312ed02a399684ce6f305ae0aa078ef01"` [INFO] [stderr] Checking lazy_static v0.2.6 [INFO] [stderr] Checking gfx_core v0.6.0 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking arrayvec v0.3.22 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking x11-dl v2.12.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking gfx_device_gl v0.13.0 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking draw v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:166:82 [INFO] [stderr] | [INFO] [stderr] 166 | image(&apple_gone, c.transform.scale(0.5, 0.5).trans((0.0 + (i * 50) as f64), 0.0), g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:168:77 [INFO] [stderr] | [INFO] [stderr] 168 | image(&apple, c.transform.scale(0.5, 0.5).trans((0.0 + (i * 50) as f64), 0.0), g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/main.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | for (i, v) in (0..player.apples.total).enumerate() { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ci` [INFO] [stderr] --> src/main.rs:172:26 [INFO] [stderr] | [INFO] [stderr] 172 | for (ci, cv) in (0..player.rows).enumerate() { [INFO] [stderr] | ^^ help: consider using `_ci` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ri` [INFO] [stderr] --> src/main.rs:173:30 [INFO] [stderr] | [INFO] [stderr] 173 | for (ri, rv) in (0..player.columns).enumerate() { [INFO] [stderr] | ^^ help: consider using `_ri` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/player.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | for t in self.throwable.iter() { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_time` [INFO] [stderr] --> src/player.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_delta_time` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/throwable.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn update(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/player.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `moving` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | moving: bool, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ltr` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | ltr: bool, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `speed` [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | speed: f64 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn update(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `COLOR` should have a snake case name such as `color` [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let COLOR = [0.3, 0.5, 0.5, 1.0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref font = assets.join("Amatic-Bold.ttf"); [INFO] [stderr] | ----^^^^^^^^---------------------------------- help: try: `let font = &assets.join("Amatic-Bold.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:46 [INFO] [stderr] | [INFO] [stderr] 135 | let x = calc_dis_pos(player.x as f64, drawfactor); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(player.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:46 [INFO] [stderr] | [INFO] [stderr] 136 | let y = calc_dis_pos(player.y as f64, drawfactor); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(player.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:50 [INFO] [stderr] | [INFO] [stderr] 177 | calc_dis_pos(rv as f64, drawfactor), [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(rv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:178:50 [INFO] [stderr] | [INFO] [stderr] 178 | calc_dis_pos(cv as f64, drawfactor)), g); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:50 [INFO] [stderr] | [INFO] [stderr] 180 | calc_dis_pos(rv as f64, drawfactor), [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(rv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:50 [INFO] [stderr] | [INFO] [stderr] 181 | calc_dis_pos(cv as f64, drawfactor)).scale(0.9, 0.9), g); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:166:82 [INFO] [stderr] | [INFO] [stderr] 166 | image(&apple_gone, c.transform.scale(0.5, 0.5).trans((0.0 + (i * 50) as f64), 0.0), g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:168:77 [INFO] [stderr] | [INFO] [stderr] 168 | image(&apple, c.transform.scale(0.5, 0.5).trans((0.0 + (i * 50) as f64), 0.0), g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/main.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | for (i, v) in (0..player.apples.total).enumerate() { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ci` [INFO] [stderr] --> src/main.rs:172:26 [INFO] [stderr] | [INFO] [stderr] 172 | for (ci, cv) in (0..player.rows).enumerate() { [INFO] [stderr] | ^^ help: consider using `_ci` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ri` [INFO] [stderr] --> src/main.rs:173:30 [INFO] [stderr] | [INFO] [stderr] 173 | for (ri, rv) in (0..player.columns).enumerate() { [INFO] [stderr] | ^^ help: consider using `_ri` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/player.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | for t in self.throwable.iter() { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta_time` [INFO] [stderr] --> src/player.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_delta_time` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/throwable.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn update(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/player.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, delta_time: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `moving` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | moving: bool, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ltr` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | ltr: bool, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `speed` [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | speed: f64 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn update(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `COLOR` should have a snake case name such as `color` [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let COLOR = [0.3, 0.5, 0.5, 1.0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref font = assets.join("Amatic-Bold.ttf"); [INFO] [stderr] | ----^^^^^^^^---------------------------------- help: try: `let font = &assets.join("Amatic-Bold.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:46 [INFO] [stderr] | [INFO] [stderr] 135 | let x = calc_dis_pos(player.x as f64, drawfactor); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(player.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:46 [INFO] [stderr] | [INFO] [stderr] 136 | let y = calc_dis_pos(player.y as f64, drawfactor); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(player.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:50 [INFO] [stderr] | [INFO] [stderr] 177 | calc_dis_pos(rv as f64, drawfactor), [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(rv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:178:50 [INFO] [stderr] | [INFO] [stderr] 178 | calc_dis_pos(cv as f64, drawfactor)), g); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:50 [INFO] [stderr] | [INFO] [stderr] 180 | calc_dis_pos(rv as f64, drawfactor), [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(rv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:50 [INFO] [stderr] | [INFO] [stderr] 181 | calc_dis_pos(cv as f64, drawfactor)).scale(0.9, 0.9), g); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(cv)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.22s [INFO] running `"docker" "inspect" "2dc0f08c6a2bd50ad3e8579de8a2906312ed02a399684ce6f305ae0aa078ef01"` [INFO] running `"docker" "rm" "-f" "2dc0f08c6a2bd50ad3e8579de8a2906312ed02a399684ce6f305ae0aa078ef01"` [INFO] [stdout] 2dc0f08c6a2bd50ad3e8579de8a2906312ed02a399684ce6f305ae0aa078ef01