[INFO] updating cached repository lima9/RustTest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lima9/RustTest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lima9/RustTest" "work/ex/clippy-test-run/sources/stable/gh/lima9/RustTest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lima9/RustTest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lima9/RustTest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lima9/RustTest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lima9/RustTest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 17e1b4d5786b52c1cfa810b1dbd183f7109aa8b6 [INFO] sha for GitHub repo lima9/RustTest: 17e1b4d5786b52c1cfa810b1dbd183f7109aa8b6 [INFO] validating manifest of lima9/RustTest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lima9/RustTest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lima9/RustTest [INFO] finished frobbing lima9/RustTest [INFO] frobbed toml for lima9/RustTest written to work/ex/clippy-test-run/sources/stable/gh/lima9/RustTest/Cargo.toml [INFO] started frobbing lima9/RustTest [INFO] finished frobbing lima9/RustTest [INFO] frobbed toml for lima9/RustTest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lima9/RustTest/Cargo.toml [INFO] crate lima9/RustTest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lima9/RustTest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lima9/RustTest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7b97a13183d6d995b56c8e3eacfac3e83544d6fbf70b7434f6b60bcaa290bf7 [INFO] running `"docker" "start" "-a" "b7b97a13183d6d995b56c8e3eacfac3e83544d6fbf70b7434f6b60bcaa290bf7"` [INFO] [stderr] Checking unicode-normalization v0.1.2 [INFO] [stderr] Checking traitobject v0.0.3 [INFO] [stderr] Checking httparse v1.2.0 [INFO] [stderr] Checking unicode-bidi v0.2.3 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking unsafe-any v0.4.1 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking plugin v0.2.6 [INFO] [stderr] Checking idna v0.1.0 [INFO] [stderr] Checking url v1.2.3 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking hyper v0.9.12 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking logger v0.2.0 [INFO] [stderr] Checking router v0.4.0 [INFO] [stderr] Checking iron-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | date_time: date_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | FeedHandler { database: database } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | MakePostHandler { database: database } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | PostHandler { database: database } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | date_time: date_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | FeedHandler { database: database } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | MakePostHandler { database: database } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | PostHandler { database: database } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/handlers.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/handlers.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/handlers.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/handlers.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handlers.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | iterator.find(|post| post.uuid() == id).map(|post| post.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterator.find(|post| post.uuid() == id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handlers.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let ref post_id = get_http_param!(req, "id"); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | let post_id = &(match $r.extensions.get::() { [INFO] [stderr] 131 | Some(router) => { [INFO] [stderr] 132 | match router.find($e) { [INFO] [stderr] 133 | Some(val) => val, [INFO] [stderr] 134 | None => return Ok(Response::with(status::BadRequest)), [INFO] [stderr] 135 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handlers.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | iterator.find(|post| post.uuid() == id).map(|post| post.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterator.find(|post| post.uuid() == id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handlers.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let ref post_id = get_http_param!(req, "id"); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | let post_id = &(match $r.extensions.get::() { [INFO] [stderr] 131 | Some(router) => { [INFO] [stderr] 132 | match router.find($e) { [INFO] [stderr] 133 | Some(val) => val, [INFO] [stderr] 134 | None => return Ok(Response::with(status::BadRequest)), [INFO] [stderr] 135 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.88s [INFO] running `"docker" "inspect" "b7b97a13183d6d995b56c8e3eacfac3e83544d6fbf70b7434f6b60bcaa290bf7"` [INFO] running `"docker" "rm" "-f" "b7b97a13183d6d995b56c8e3eacfac3e83544d6fbf70b7434f6b60bcaa290bf7"` [INFO] [stdout] b7b97a13183d6d995b56c8e3eacfac3e83544d6fbf70b7434f6b60bcaa290bf7