[INFO] updating cached repository lilserf/advent2015 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lilserf/advent2015 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lilserf/advent2015" "work/ex/clippy-test-run/sources/stable/gh/lilserf/advent2015"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lilserf/advent2015'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lilserf/advent2015" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilserf/advent2015"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilserf/advent2015'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8800adfd1e872dea949dbfe398c36c1abee404d7 [INFO] sha for GitHub repo lilserf/advent2015: 8800adfd1e872dea949dbfe398c36c1abee404d7 [INFO] validating manifest of lilserf/advent2015 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lilserf/advent2015 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lilserf/advent2015 [INFO] finished frobbing lilserf/advent2015 [INFO] frobbed toml for lilserf/advent2015 written to work/ex/clippy-test-run/sources/stable/gh/lilserf/advent2015/Cargo.toml [INFO] started frobbing lilserf/advent2015 [INFO] finished frobbing lilserf/advent2015 [INFO] frobbed toml for lilserf/advent2015 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilserf/advent2015/Cargo.toml [INFO] crate lilserf/advent2015 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lilserf/advent2015 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lilserf/advent2015:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c59ebc035e1f565cadce03b38961a38a254983e0d7adf8d1c9b61132ed5460ee [INFO] running `"docker" "start" "-a" "c59ebc035e1f565cadce03b38961a38a254983e0d7adf8d1c9b61132ed5460ee"` [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking advent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:228:2 [INFO] [stderr] | [INFO] [stderr] 228 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:284:2 [INFO] [stderr] | [INFO] [stderr] 284 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | if i < value.len()-2 [INFO] [stderr] | _________^ [INFO] [stderr] 245 | | { [INFO] [stderr] 246 | | if value[i] == value[i+2] [INFO] [stderr] 247 | | { [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 244 | if i < value.len()-2 && value[i] == value[i+2] { [INFO] [stderr] 245 | triad = true; [INFO] [stderr] 246 | triad_str = String::from_utf8(value[i..i+3].to_vec()).unwrap(); [INFO] [stderr] 247 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:498:5 [INFO] [stderr] | [INFO] [stderr] 498 | return Err("Src var not resolved."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Src var not resolved.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:507:5 [INFO] [stderr] | [INFO] [stderr] 507 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:511:5 [INFO] [stderr] | [INFO] [stderr] 511 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:521:5 [INFO] [stderr] | [INFO] [stderr] 521 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:525:5 [INFO] [stderr] | [INFO] [stderr] 525 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:535:5 [INFO] [stderr] | [INFO] [stderr] 535 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:548:5 [INFO] [stderr] | [INFO] [stderr] 548 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:552:5 [INFO] [stderr] | [INFO] [stderr] 552 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:561:5 [INFO] [stderr] | [INFO] [stderr] 561 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:565:5 [INFO] [stderr] | [INFO] [stderr] 565 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:574:5 [INFO] [stderr] | [INFO] [stderr] 574 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:578:5 [INFO] [stderr] | [INFO] [stderr] 578 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:613:3 [INFO] [stderr] | [INFO] [stderr] 613 | { [INFO] [stderr] | _________^ [INFO] [stderr] 614 | | if symbols[1] == "AND" [INFO] [stderr] 615 | | { [INFO] [stderr] 616 | | // Cheating: my dataset contains cases of "1 AND x" but no other ones with number literals [INFO] [stderr] ... | [INFO] [stderr] 644 | | } [INFO] [stderr] 645 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 613 | if symbols[1] == "AND" [INFO] [stderr] 614 | { [INFO] [stderr] 615 | // Cheating: my dataset contains cases of "1 AND x" but no other ones with number literals [INFO] [stderr] 616 | match symbols[0].parse() [INFO] [stderr] 617 | { [INFO] [stderr] 618 | // Parsed a number, add a NumAnd op [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:729:2 [INFO] [stderr] | [INFO] [stderr] 729 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:228:2 [INFO] [stderr] | [INFO] [stderr] 228 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:284:2 [INFO] [stderr] | [INFO] [stderr] 284 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | if i < value.len()-2 [INFO] [stderr] | _________^ [INFO] [stderr] 245 | | { [INFO] [stderr] 246 | | if value[i] == value[i+2] [INFO] [stderr] 247 | | { [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 244 | if i < value.len()-2 && value[i] == value[i+2] { [INFO] [stderr] 245 | triad = true; [INFO] [stderr] 246 | triad_str = String::from_utf8(value[i..i+3].to_vec()).unwrap(); [INFO] [stderr] 247 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:498:5 [INFO] [stderr] | [INFO] [stderr] 498 | return Err("Src var not resolved."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Src var not resolved.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:507:5 [INFO] [stderr] | [INFO] [stderr] 507 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:511:5 [INFO] [stderr] | [INFO] [stderr] 511 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:521:5 [INFO] [stderr] | [INFO] [stderr] 521 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:525:5 [INFO] [stderr] | [INFO] [stderr] 525 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:535:5 [INFO] [stderr] | [INFO] [stderr] 535 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:548:5 [INFO] [stderr] | [INFO] [stderr] 548 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:552:5 [INFO] [stderr] | [INFO] [stderr] 552 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:561:5 [INFO] [stderr] | [INFO] [stderr] 561 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:565:5 [INFO] [stderr] | [INFO] [stderr] 565 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:574:5 [INFO] [stderr] | [INFO] [stderr] 574 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:578:5 [INFO] [stderr] | [INFO] [stderr] 578 | return Err("One or more src vars not resolved"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("One or more src vars not resolved")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:613:3 [INFO] [stderr] | [INFO] [stderr] 613 | { [INFO] [stderr] | _________^ [INFO] [stderr] 614 | | if symbols[1] == "AND" [INFO] [stderr] 615 | | { [INFO] [stderr] 616 | | // Cheating: my dataset contains cases of "1 AND x" but no other ones with number literals [INFO] [stderr] ... | [INFO] [stderr] 644 | | } [INFO] [stderr] 645 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 613 | if symbols[1] == "AND" [INFO] [stderr] 614 | { [INFO] [stderr] 615 | // Cheating: my dataset contains cases of "1 AND x" but no other ones with number literals [INFO] [stderr] 616 | match symbols[0].parse() [INFO] [stderr] 617 | { [INFO] [stderr] 618 | // Parsed a number, add a NumAnd op [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:729:2 [INFO] [stderr] | [INFO] [stderr] 729 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | let v:Vec<&str> = s.split("x").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | let key = "bgvyzdsv".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bgvyzdsv"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | let first_x = output[0] as i32 + output[1] as i32 + output[2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:36 [INFO] [stderr] | [INFO] [stderr] 177 | let first_x = output[0] as i32 + output[1] as i32 + output[2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:55 [INFO] [stderr] | [INFO] [stderr] 177 | let first_x = output[0] as i32 + output[1] as i32 + output[2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | let index = h.get(&s).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&h[&s]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | if h.contains_key(&s) && i > h.get(&s).unwrap() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&h[&s]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:267:4 [INFO] [stderr] | [INFO] [stderr] 267 | if !h.contains_key(&s) [INFO] [stderr] | _____________^ [INFO] [stderr] 268 | | { [INFO] [stderr] 269 | | h.insert(s, i); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____________^ help: consider using: `h.entry(s).or_insert(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 331 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:333:14 [INFO] [stderr] | [INFO] [stderr] 333 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 348 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:350:14 [INFO] [stderr] | [INFO] [stderr] 350 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 365 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:367:14 [INFO] [stderr] | [INFO] [stderr] 367 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | count += col as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 410 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 427 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:429:14 [INFO] [stderr] | [INFO] [stderr] 429 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 448 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:450:14 [INFO] [stderr] | [INFO] [stderr] 450 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | count += col as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:487:2 [INFO] [stderr] | [INFO] [stderr] 487 | match op [INFO] [stderr] | _____^ [INFO] [stderr] 488 | | { [INFO] [stderr] 489 | | &Operation::AssignVar(src) => [INFO] [stderr] 490 | | { [INFO] [stderr] ... | [INFO] [stderr] 580 | | } [INFO] [stderr] 581 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 487 | match *op [INFO] [stderr] 488 | { [INFO] [stderr] 489 | Operation::AssignVar(src) => [INFO] [stderr] 490 | { [INFO] [stderr] 491 | if h.contains_key(src) [INFO] [stderr] 492 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:648:8 [INFO] [stderr] | [INFO] [stderr] 648 | while wires.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!wires.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | let v:Vec<&str> = s.split("x").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | let key = "bgvyzdsv".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bgvyzdsv"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | let first_x = output[0] as i32 + output[1] as i32 + output[2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:36 [INFO] [stderr] | [INFO] [stderr] 177 | let first_x = output[0] as i32 + output[1] as i32 + output[2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:55 [INFO] [stderr] | [INFO] [stderr] 177 | let first_x = output[0] as i32 + output[1] as i32 + output[2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | let index = h.get(&s).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&h[&s]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | if h.contains_key(&s) && i > h.get(&s).unwrap() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&h[&s]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:267:4 [INFO] [stderr] | [INFO] [stderr] 267 | if !h.contains_key(&s) [INFO] [stderr] | _____________^ [INFO] [stderr] 268 | | { [INFO] [stderr] 269 | | h.insert(s, i); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____________^ help: consider using: `h.entry(s).or_insert(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 331 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:333:14 [INFO] [stderr] | [INFO] [stderr] 333 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 348 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:350:14 [INFO] [stderr] | [INFO] [stderr] 350 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 365 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:367:14 [INFO] [stderr] | [INFO] [stderr] 367 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | count += col as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 410 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 427 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:429:14 [INFO] [stderr] | [INFO] [stderr] 429 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 448 | for in grid.iter_mut().take(b[0]+1).skip(a[0]) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | for x in a[0]..b[0]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[0]..=b[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:450:14 [INFO] [stderr] | [INFO] [stderr] 450 | for y in a[1]..b[1]+1 [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `a[1]..=b[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | count += col as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:487:2 [INFO] [stderr] | [INFO] [stderr] 487 | match op [INFO] [stderr] | _____^ [INFO] [stderr] 488 | | { [INFO] [stderr] 489 | | &Operation::AssignVar(src) => [INFO] [stderr] 490 | | { [INFO] [stderr] ... | [INFO] [stderr] 580 | | } [INFO] [stderr] 581 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 487 | match *op [INFO] [stderr] 488 | { [INFO] [stderr] 489 | Operation::AssignVar(src) => [INFO] [stderr] 490 | { [INFO] [stderr] 491 | if h.contains_key(src) [INFO] [stderr] 492 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:648:8 [INFO] [stderr] | [INFO] [stderr] 648 | while wires.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!wires.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.30s [INFO] running `"docker" "inspect" "c59ebc035e1f565cadce03b38961a38a254983e0d7adf8d1c9b61132ed5460ee"` [INFO] running `"docker" "rm" "-f" "c59ebc035e1f565cadce03b38961a38a254983e0d7adf8d1c9b61132ed5460ee"` [INFO] [stdout] c59ebc035e1f565cadce03b38961a38a254983e0d7adf8d1c9b61132ed5460ee