[INFO] updating cached repository lifthrasiir/unison [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lifthrasiir/unison [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lifthrasiir/unison" "work/ex/clippy-test-run/sources/stable/gh/lifthrasiir/unison"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lifthrasiir/unison'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lifthrasiir/unison" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lifthrasiir/unison"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lifthrasiir/unison'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 979064f4162e7d220d6a942853aca41d550a03fd [INFO] sha for GitHub repo lifthrasiir/unison: 979064f4162e7d220d6a942853aca41d550a03fd [INFO] validating manifest of lifthrasiir/unison on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lifthrasiir/unison on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lifthrasiir/unison [INFO] finished frobbing lifthrasiir/unison [INFO] frobbed toml for lifthrasiir/unison written to work/ex/clippy-test-run/sources/stable/gh/lifthrasiir/unison/Cargo.toml [INFO] started frobbing lifthrasiir/unison [INFO] finished frobbing lifthrasiir/unison [INFO] frobbed toml for lifthrasiir/unison written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lifthrasiir/unison/Cargo.toml [INFO] crate lifthrasiir/unison has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lifthrasiir/unison against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/lifthrasiir/unison:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08473130499b12a407095e627cfbe2aab72a8b9f7574aa2f23fb21e1e11a33b7 [INFO] running `"docker" "start" "-a" "08473130499b12a407095e627cfbe2aab72a8b9f7574aa2f23fb21e1e11a33b7"` [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Compiling cc v1.0.15 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Compiling adler32 v1.0.2 [INFO] [stderr] Compiling libc v0.2.41 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking cfg-if v0.1.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking stable_deref_trait v1.0.0 [INFO] [stderr] Checking smallvec v0.6.1 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling byteorder v1.2.3 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Compiling podio v0.1.6 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Compiling serde v1.0.59 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling fpa v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking itoa v0.4.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking errln v0.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Checking md5 v0.3.7 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling proc-macro2 v0.4.3 [INFO] [stderr] Compiling miniz_oxide v0.1.2 [INFO] [stderr] Compiling time v0.1.40 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Compiling xml-rs v0.6.1 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Compiling msdos_time v0.1.6 [INFO] [stderr] Compiling quote v0.6.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling rmp v0.8.7 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Compiling flate2 v1.0.1 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking console v0.4.2 [INFO] [stderr] Checking indicatif v0.6.0 [INFO] [stderr] Compiling zip v0.2.8 [INFO] [stderr] Compiling unison v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Compiling serde_derive v1.0.59 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/external_data.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | let row = Row { name: name }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/external_data.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | UnicodeData { chars: chars, char_ranges: char_ranges } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/external_data.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | UnicodeData { chars: chars, char_ranges: char_ranges } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/external_data.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | let row = Row { name: name }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/external_data.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | UnicodeData { chars: chars, char_ranges: char_ranges } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/external_data.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | UnicodeData { chars: chars, char_ranges: char_ranges } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | SlowerTick { shift: shift, last_value: AtomicUsize::new(0) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shift` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/sample.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | write!(f, "P5 {} {} 255\n", imwidth, imheight)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | SlowerTick { shift: shift, last_value: AtomicUsize::new(0) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shift` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | style = "\ [INFO] [stderr] | _________________^ [INFO] [stderr] 329 | | body{background:black;color:white;line-height:1}div{color:gray}#sampleglyphs{display:none}body.sample #sampleglyphs{display:block}body.sample #glyphs{display:none}.scaled{font-size:500%}\n\ [INFO] [stderr] 330 | | img{background:#222;vertical-align:top;opacity:0.5}img:hover,body.sample img{background:#111;opacity:1}.glyphs>:nth-child(even) img{background:#444}.glyphs>:nth-child(even) img:hover,body.sample .glyphs>:nth-child(even) img{background:#222} [INFO] [stderr] 331 | | svg{background:#111;fill:white;vertical-align:top}.glyphs>:nth-child(even) svg{background:#222}:target svg{background:#333}svg:hover>path,body.sample svg>path{fill:white}a svg>path{fill:gray} [INFO] [stderr] 332 | | ", [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] | |_^ [INFO] [stderr] --> src/sample.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | write!(f, "P5 {} {} 255\n", imwidth, imheight)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:398:18 [INFO] [stderr] | [INFO] [stderr] 398 | script = "\ [INFO] [stderr] | __________________^ [INFO] [stderr] 399 | | prevt=0; [INFO] [stderr] 400 | | function $(x){return document.getElementById(x)} [INFO] [stderr] 401 | | function f(t,h){if(t.normalize)t=t.normalize();if(prevt===t)return;prevt=t;if(!h)location.hash=t?'#!'+encodeURIComponent(t):'';$('sample').value=t;document.body.className=t?'sample':'';var sm='',bg='';for(var i=0;i'+bg+''} [INFO] [stderr] ... | [INFO] [stderr] 404 | | $('reset').onclick=function(){$('sample').value='';f('')} [INFO] [stderr] 405 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:436:17 [INFO] [stderr] | [INFO] [stderr] 436 | style = "\ [INFO] [stderr] | _________________^ [INFO] [stderr] 437 | | pre{font-family:Unison,monospace;font-size:200%;line-height:1;margin:0;white-space:pre-wrap}pre span{background:#eee}.hide{display:none} [INFO] [stderr] 438 | | ", [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:439:18 [INFO] [stderr] | [INFO] [stderr] 439 | script = "\ [INFO] [stderr] | __________________^ [INFO] [stderr] 440 | | window.onload=function(){var e=document.getElementById('edit');e.contentEditable='true';for(var x=document.querySelectorAll('a[href^=\"#\"]'),i=0;x[i];++i)x[i].onclick=function(){e.innerHTML=document.getElementById(this.getAttribute('href').substring(1)).innerHTML;return false}} [INFO] [stderr] 441 | | ", [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | style = "\ [INFO] [stderr] | _________________^ [INFO] [stderr] 329 | | body{background:black;color:white;line-height:1}div{color:gray}#sampleglyphs{display:none}body.sample #sampleglyphs{display:block}body.sample #glyphs{display:none}.scaled{font-size:500%}\n\ [INFO] [stderr] 330 | | img{background:#222;vertical-align:top;opacity:0.5}img:hover,body.sample img{background:#111;opacity:1}.glyphs>:nth-child(even) img{background:#444}.glyphs>:nth-child(even) img:hover,body.sample .glyphs>:nth-child(even) img{background:#222} [INFO] [stderr] 331 | | svg{background:#111;fill:white;vertical-align:top}.glyphs>:nth-child(even) svg{background:#222}:target svg{background:#333}svg:hover>path,body.sample svg>path{fill:white}a svg>path{fill:gray} [INFO] [stderr] 332 | | ", [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:442:16 [INFO] [stderr] | [INFO] [stderr] 442 | logo = r#" [INFO] [stderr] | ________________^ [INFO] [stderr] 443 | | 888 888 d8b [INFO] [stderr] 444 | | 888 888 Y8P [INFO] [stderr] 445 | | 888 888 [INFO] [stderr] ... | [INFO] [stderr] 450 | | "Y88888P" 888 888 888 88888P' "Y88P" 888 888 [INFO] [stderr] 451 | | "#, [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:398:18 [INFO] [stderr] | [INFO] [stderr] 398 | script = "\ [INFO] [stderr] | __________________^ [INFO] [stderr] 399 | | prevt=0; [INFO] [stderr] 400 | | function $(x){return document.getElementById(x)} [INFO] [stderr] 401 | | function f(t,h){if(t.normalize)t=t.normalize();if(prevt===t)return;prevt=t;if(!h)location.hash=t?'#!'+encodeURIComponent(t):'';$('sample').value=t;document.body.className=t?'sample':'';var sm='',bg='';for(var i=0;i'+bg+''} [INFO] [stderr] ... | [INFO] [stderr] 404 | | $('reset').onclick=function(){$('sample').value='';f('')} [INFO] [stderr] 405 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:436:17 [INFO] [stderr] | [INFO] [stderr] 436 | style = "\ [INFO] [stderr] | _________________^ [INFO] [stderr] 437 | | pre{font-family:Unison,monospace;font-size:200%;line-height:1;margin:0;white-space:pre-wrap}pre span{background:#eee}.hide{display:none} [INFO] [stderr] 438 | | ", [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:439:18 [INFO] [stderr] | [INFO] [stderr] 439 | script = "\ [INFO] [stderr] | __________________^ [INFO] [stderr] 440 | | window.onload=function(){var e=document.getElementById('edit');e.contentEditable='true';for(var x=document.querySelectorAll('a[href^=\"#\"]'),i=0;x[i];++i)x[i].onclick=function(){e.innerHTML=document.getElementById(this.getAttribute('href').substring(1)).innerHTML;return false}} [INFO] [stderr] 441 | | ", [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/sample.rs:442:16 [INFO] [stderr] | [INFO] [stderr] 442 | logo = r#" [INFO] [stderr] | ________________^ [INFO] [stderr] 443 | | 888 888 d8b [INFO] [stderr] 444 | | 888 888 Y8P [INFO] [stderr] 445 | | 888 888 [INFO] [stderr] ... | [INFO] [stderr] 450 | | "Y88888P" 888 888 888 88888P' "Y88P" 888 888 [INFO] [stderr] 451 | | "#, [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/external_data.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | let lastcp = (cp & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | /*PX_EMPTY*/ (0b00000000, &[]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | /*PX_HALF1*/ (0b00001111, &[(0, 0, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | /*PX_HALF3*/ (0b11000011, &[(0, 2, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | /*PX_QUAD1*/ (0b00000011, &[(0, 0, 1, 1), (1, 1, 0, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | /*PX_QUAD2*/ (0b11000000, &[(0, 0, 1, 1), (1, 1, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | /*PX_QUAD3*/ (0b00110000, &[(2, 0, 1, 1), (1, 1, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | /*PX_QUAD4*/ (0b00001100, &[(0, 2, 1, 1), (1, 1, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | /*PX_SLANT1H*/ (0b00000111, &[(0, 0, 1, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | /*PX_SLANT2H*/ (0b01110000, &[(1, 0, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | /*PX_SLANT3H*/ (0b10000011, &[(0, 2, 1, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | /*PX_SLANT4H*/ (0b00111000, &[(1, 2, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | /*PX_SLANT1V*/ (0b00001110, &[(0, 1, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | /*PX_SLANT2V*/ (0b11100000, &[(0, 0, 2, 1)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | /*PX_SLANT3V*/ (0b11000001, &[(0, 1, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | /*PX_SLANT4V*/ (0b00011100, &[(0, 2, 2, 1)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | /*PX_DOT*/ (0b00000000, &[(0, 1, 1, 0), (1, 0, 2, 1), (2, 1, 1, 2), (1, 2, 0, 1)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | (px ^ 0x1f, 0b11111111) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/contour.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | const EMPTY_SEGS: &'static [(u8, u8, u8, u8)] = &[]; [INFO] [stderr] | -^^^^^^^------------------- help: consider removing `'static`: `&[(u8, u8, u8, u8)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | (0b11111111, EMPTY_SEGS) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | (0b00000000, EMPTY_SEGS) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/contour.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 89 | | if yy <= y && ccw(xx0, yy0, xx, yy, x, y) < 0 { wn -= 1; } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try: `if yy <= y && ccw(xx0, yy0, xx, yy, x, y) < 0 { wn -= 1; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:131:58 [INFO] [stderr] | [INFO] [stderr] 131 | let connected = (pixel & (top << 5) & 0b10000000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:132:58 [INFO] [stderr] | [INFO] [stderr] 132 | (pixel & (top << 3) & 0b01000000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:133:58 [INFO] [stderr] | [INFO] [stderr] 133 | (pixel & (right << 5) & 0b00100000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | (pixel & (right << 3) & 0b00010000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:135:58 [INFO] [stderr] | [INFO] [stderr] 135 | (pixel & (bottom >> 3) & 0b00001000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | (pixel & (bottom >> 5) & 0b00000100) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:137:58 [INFO] [stderr] | [INFO] [stderr] 137 | (pixel & (left >> 3) & 0b00000010) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:138:58 [INFO] [stderr] | [INFO] [stderr] 138 | (pixel & (left >> 5) & 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:140:33 [INFO] [stderr] | [INFO] [stderr] 140 | if (connected & 0b11000000) != 0 && !visited.contains(&(i-stride)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:143:33 [INFO] [stderr] | [INFO] [stderr] 143 | if (connected & 0b00110000) != 0 && !visited.contains(&(i+1)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | if (connected & 0b00001100) != 0 && !visited.contains(&(i+stride)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | if (connected & 0b00000011) != 0 && !visited.contains(&(i-1)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:157:48 [INFO] [stderr] | [INFO] [stderr] 157 | let disconnected = connected ^ 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:160:36 [INFO] [stderr] | [INFO] [stderr] 160 | if (linesegs & 0b11000000) == 0b11000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:160:51 [INFO] [stderr] | [INFO] [stderr] 160 | if (linesegs & 0b11000000) == 0b11000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | if linesegs & 0b10000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:166:39 [INFO] [stderr] | [INFO] [stderr] 166 | if linesegs & 0b01000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:170:36 [INFO] [stderr] | [INFO] [stderr] 170 | if (linesegs & 0b00110000) == 0b00110000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:170:51 [INFO] [stderr] | [INFO] [stderr] 170 | if (linesegs & 0b00110000) == 0b00110000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:173:39 [INFO] [stderr] | [INFO] [stderr] 173 | if linesegs & 0b00100000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:176:39 [INFO] [stderr] | [INFO] [stderr] 176 | if linesegs & 0b00010000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | if (linesegs & 0b00001100) == 0b00001100 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:180:51 [INFO] [stderr] | [INFO] [stderr] 180 | if (linesegs & 0b00001100) == 0b00001100 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:183:39 [INFO] [stderr] | [INFO] [stderr] 183 | if linesegs & 0b00001000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:186:39 [INFO] [stderr] | [INFO] [stderr] 186 | if linesegs & 0b00000100 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | if (linesegs & 0b00000011) == 0b00000011 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:190:51 [INFO] [stderr] | [INFO] [stderr] 190 | if (linesegs & 0b00000011) == 0b00000011 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:193:39 [INFO] [stderr] | [INFO] [stderr] 193 | if linesegs & 0b00000010 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:196:39 [INFO] [stderr] | [INFO] [stderr] 196 | if linesegs & 0b00000001 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sample.rs:309:44 [INFO] [stderr] | [INFO] [stderr] 309 | let color = (hash(&path) & 0x7f7f7f) + 0x808080; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_7f7f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sample.rs:309:56 [INFO] [stderr] | [INFO] [stderr] 309 | let color = (hash(&path) & 0x7f7f7f) + 0x808080; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/external_data.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | let lastcp = (cp & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | /*PX_EMPTY*/ (0b00000000, &[]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | /*PX_HALF1*/ (0b00001111, &[(0, 0, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | /*PX_HALF3*/ (0b11000011, &[(0, 2, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | /*PX_QUAD1*/ (0b00000011, &[(0, 0, 1, 1), (1, 1, 0, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | /*PX_QUAD2*/ (0b11000000, &[(0, 0, 1, 1), (1, 1, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | /*PX_QUAD3*/ (0b00110000, &[(2, 0, 1, 1), (1, 1, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | /*PX_QUAD4*/ (0b00001100, &[(0, 2, 1, 1), (1, 1, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | /*PX_SLANT1H*/ (0b00000111, &[(0, 0, 1, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | /*PX_SLANT2H*/ (0b01110000, &[(1, 0, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | /*PX_SLANT3H*/ (0b10000011, &[(0, 2, 1, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | /*PX_SLANT4H*/ (0b00111000, &[(1, 2, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | /*PX_SLANT1V*/ (0b00001110, &[(0, 1, 2, 2)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | /*PX_SLANT2V*/ (0b11100000, &[(0, 0, 2, 1)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | /*PX_SLANT3V*/ (0b11000001, &[(0, 1, 2, 0)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | /*PX_SLANT4V*/ (0b00011100, &[(0, 2, 2, 1)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | /*PX_DOT*/ (0b00000000, &[(0, 1, 1, 0), (1, 0, 2, 1), (2, 1, 1, 2), (1, 2, 0, 1)]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | (px ^ 0x1f, 0b11111111) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/contour.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | const EMPTY_SEGS: &'static [(u8, u8, u8, u8)] = &[]; [INFO] [stderr] | -^^^^^^^------------------- help: consider removing `'static`: `&[(u8, u8, u8, u8)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | (0b11111111, EMPTY_SEGS) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | (0b00000000, EMPTY_SEGS) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/contour.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 89 | | if yy <= y && ccw(xx0, yy0, xx, yy, x, y) < 0 { wn -= 1; } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try: `if yy <= y && ccw(xx0, yy0, xx, yy, x, y) < 0 { wn -= 1; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:131:58 [INFO] [stderr] | [INFO] [stderr] 131 | let connected = (pixel & (top << 5) & 0b10000000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:132:58 [INFO] [stderr] | [INFO] [stderr] 132 | (pixel & (top << 3) & 0b01000000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:133:58 [INFO] [stderr] | [INFO] [stderr] 133 | (pixel & (right << 5) & 0b00100000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | (pixel & (right << 3) & 0b00010000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:135:58 [INFO] [stderr] | [INFO] [stderr] 135 | (pixel & (bottom >> 3) & 0b00001000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | (pixel & (bottom >> 5) & 0b00000100) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:137:58 [INFO] [stderr] | [INFO] [stderr] 137 | (pixel & (left >> 3) & 0b00000010) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:138:58 [INFO] [stderr] | [INFO] [stderr] 138 | (pixel & (left >> 5) & 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:140:33 [INFO] [stderr] | [INFO] [stderr] 140 | if (connected & 0b11000000) != 0 && !visited.contains(&(i-stride)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:143:33 [INFO] [stderr] | [INFO] [stderr] 143 | if (connected & 0b00110000) != 0 && !visited.contains(&(i+1)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | if (connected & 0b00001100) != 0 && !visited.contains(&(i+stride)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | if (connected & 0b00000011) != 0 && !visited.contains(&(i-1)) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:157:48 [INFO] [stderr] | [INFO] [stderr] 157 | let disconnected = connected ^ 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:160:36 [INFO] [stderr] | [INFO] [stderr] 160 | if (linesegs & 0b11000000) == 0b11000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:160:51 [INFO] [stderr] | [INFO] [stderr] 160 | if (linesegs & 0b11000000) == 0b11000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | if linesegs & 0b10000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:166:39 [INFO] [stderr] | [INFO] [stderr] 166 | if linesegs & 0b01000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:170:36 [INFO] [stderr] | [INFO] [stderr] 170 | if (linesegs & 0b00110000) == 0b00110000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:170:51 [INFO] [stderr] | [INFO] [stderr] 170 | if (linesegs & 0b00110000) == 0b00110000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:173:39 [INFO] [stderr] | [INFO] [stderr] 173 | if linesegs & 0b00100000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:176:39 [INFO] [stderr] | [INFO] [stderr] 176 | if linesegs & 0b00010000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | if (linesegs & 0b00001100) == 0b00001100 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:180:51 [INFO] [stderr] | [INFO] [stderr] 180 | if (linesegs & 0b00001100) == 0b00001100 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:183:39 [INFO] [stderr] | [INFO] [stderr] 183 | if linesegs & 0b00001000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:186:39 [INFO] [stderr] | [INFO] [stderr] 186 | if linesegs & 0b00000100 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | if (linesegs & 0b00000011) == 0b00000011 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:190:51 [INFO] [stderr] | [INFO] [stderr] 190 | if (linesegs & 0b00000011) == 0b00000011 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:193:39 [INFO] [stderr] | [INFO] [stderr] 193 | if linesegs & 0b00000010 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/contour.rs:196:39 [INFO] [stderr] | [INFO] [stderr] 196 | if linesegs & 0b00000001 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sample.rs:309:44 [INFO] [stderr] | [INFO] [stderr] 309 | let color = (hash(&path) & 0x7f7f7f) + 0x808080; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_7f7f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sample.rs:309:56 [INFO] [stderr] | [INFO] [stderr] 309 | let color = (hash(&path) & 0x7f7f7f) + 0x808080; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/external_data.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | if row.name.starts_with("\x01") { // NR1: hangul syllable [INFO] [stderr] | ^^^^^^ help: try using a char instead: `'\x01'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/external_data.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | } else if row.name.starts_with("\x02") { // NR2: ideograph [INFO] [stderr] | ^^^^^^ help: try using a char instead: `'\x02'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `M` [INFO] [stderr] --> src/font.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PX_ALMOSTFULL: u8 = 0^M; // @ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/contour.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / fn track_contour(height: u32, width: u32, stride: usize, data: &[u8], [INFO] [stderr] 98 | | adjacency: fn(u8) -> Adjacency, shift: usize) -> Vec> { [INFO] [stderr] 99 | | assert!(shift >= 1, "shift should be nonzero due to the presence of half-integer coordinates"); [INFO] [stderr] 100 | | [INFO] [stderr] ... | [INFO] [stderr] 338 | | paths [INFO] [stderr] 339 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:204:38 [INFO] [stderr] | [INFO] [stderr] 204 | x + ((x1 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:205:38 [INFO] [stderr] | [INFO] [stderr] 205 | y + ((y1 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(y1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:206:38 [INFO] [stderr] | [INFO] [stderr] 206 | x + ((x2 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | y + ((y2 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(y2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/contour.rs:216:42 [INFO] [stderr] | [INFO] [stderr] 216 | pxtosegs.entry((x1, y1)).or_insert(Vec::new()).push((x2, y2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/contour.rs:217:42 [INFO] [stderr] | [INFO] [stderr] 217 | pxtosegs.entry((x2, y2)).or_insert(Vec::new()).push((x1, y1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | fn inc(&self, delta: u64, bar: &ProgressBar) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | fn finish(self, bar: &ProgressBar) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(h[0])` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/external_data.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | if row.name.starts_with("\x01") { // NR1: hangul syllable [INFO] [stderr] | ^^^^^^ help: try using a char instead: `'\x01'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:27 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(h[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:49 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(h[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:70 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(h[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/external_data.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | } else if row.name.starts_with("\x02") { // NR2: ideograph [INFO] [stderr] | ^^^^^^ help: try using a char instead: `'\x02'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn write_pgm(f: &mut Write, font: &Font, bar: &ProgressBar) -> io::Result<()> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is only used to index `current`. [INFO] [stderr] --> src/sample.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | for r in 0..(height as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for in current.iter_mut().take((height as usize)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | f.write(&imline)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:188:26 [INFO] [stderr] | [INFO] [stderr] 188 | let &(r, left) = positions.get(&ch).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&positions[&ch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | f.write(line)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | f.write(&imline)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sample.rs:200:23 [INFO] [stderr] | [INFO] [stderr] 200 | current = (0..(MAX_HEIGHT + 1)).map(|_| imline.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=MAX_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:216:64 [INFO] [stderr] | [INFO] [stderr] 216 | render_glyphs(&mut current, 8*8 + 1 + 1 + left as i32, glyphs.get(name).unwrap(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&glyphs[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | f.write(line)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `M` [INFO] [stderr] --> src/font.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PX_ALMOSTFULL: u8 = 0^M; // @ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:227:47 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn write_html(f: &mut Write, font: &Font, bar: &ProgressBar) -> io::Result<()> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:263:18 [INFO] [stderr] | [INFO] [stderr] 263 | let gg = font.glyphs.get(name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.glyphs[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:297:18 [INFO] [stderr] | [INFO] [stderr] 297 | let gg = font.glyphs.get(name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.glyphs[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:343:17 [INFO] [stderr] | [INFO] [stderr] 343 | f.write(&s)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:365:39 [INFO] [stderr] | [INFO] [stderr] 365 | let _ = print_svg(&mut s, font.cmap.get(&ch).unwrap(), font, 1, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.cmap[&ch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:367:51 [INFO] [stderr] | [INFO] [stderr] 367 | let _ = print_fullpixel_image(&mut s, font.cmap.get(&ch).unwrap(), font); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.cmap[&ch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:388:35 [INFO] [stderr] | [INFO] [stderr] 388 | let _ = print_svg(&mut s, font.cmap.get(&ch).unwrap(), font, 5, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.cmap[&ch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:411:52 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn write_live_html(f: &mut Write, font: &Font, bar: &ProgressBar) -> io::Result<()> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | fn set_style(bar: ProgressBar) -> ProgressBar { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `unison`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/contour.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / fn track_contour(height: u32, width: u32, stride: usize, data: &[u8], [INFO] [stderr] 98 | | adjacency: fn(u8) -> Adjacency, shift: usize) -> Vec> { [INFO] [stderr] 99 | | assert!(shift >= 1, "shift should be nonzero due to the presence of half-integer coordinates"); [INFO] [stderr] 100 | | [INFO] [stderr] ... | [INFO] [stderr] 338 | | paths [INFO] [stderr] 339 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:204:38 [INFO] [stderr] | [INFO] [stderr] 204 | x + ((x1 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(x1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:205:38 [INFO] [stderr] | [INFO] [stderr] 205 | y + ((y1 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(y1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:206:38 [INFO] [stderr] | [INFO] [stderr] 206 | x + ((x2 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(x2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/contour.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | y + ((y2 as i32) << (shift-1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(y2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/contour.rs:216:42 [INFO] [stderr] | [INFO] [stderr] 216 | pxtosegs.entry((x1, y1)).or_insert(Vec::new()).push((x2, y2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/contour.rs:217:42 [INFO] [stderr] | [INFO] [stderr] 217 | pxtosegs.entry((x2, y2)).or_insert(Vec::new()).push((x1, y1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | fn inc(&self, delta: u64, bar: &ProgressBar) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | fn finish(self, bar: &ProgressBar) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(h[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:27 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(h[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:49 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(h[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:83:70 [INFO] [stderr] | [INFO] [stderr] 83 | (h[0] as u32) << 24 | (h[1] as u32) << 16 | (h[2] as u32) << 8 | h[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(h[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn write_pgm(f: &mut Write, font: &Font, bar: &ProgressBar) -> io::Result<()> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is only used to index `current`. [INFO] [stderr] --> src/sample.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | for r in 0..(height as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for in current.iter_mut().take((height as usize)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | f.write(&imline)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:188:26 [INFO] [stderr] | [INFO] [stderr] 188 | let &(r, left) = positions.get(&ch).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&positions[&ch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | f.write(line)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | f.write(&imline)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sample.rs:200:23 [INFO] [stderr] | [INFO] [stderr] 200 | current = (0..(MAX_HEIGHT + 1)).map(|_| imline.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=MAX_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:216:64 [INFO] [stderr] | [INFO] [stderr] 216 | render_glyphs(&mut current, 8*8 + 1 + 1 + left as i32, glyphs.get(name).unwrap(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&glyphs[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | f.write(line)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:227:47 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn write_html(f: &mut Write, font: &Font, bar: &ProgressBar) -> io::Result<()> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:263:18 [INFO] [stderr] | [INFO] [stderr] 263 | let gg = font.glyphs.get(name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.glyphs[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:297:18 [INFO] [stderr] | [INFO] [stderr] 297 | let gg = font.glyphs.get(name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.glyphs[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/sample.rs:343:17 [INFO] [stderr] | [INFO] [stderr] 343 | f.write(&s)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:365:39 [INFO] [stderr] | [INFO] [stderr] 365 | let _ = print_svg(&mut s, font.cmap.get(&ch).unwrap(), font, 1, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.cmap[&ch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:367:51 [INFO] [stderr] | [INFO] [stderr] 367 | let _ = print_fullpixel_image(&mut s, font.cmap.get(&ch).unwrap(), font); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.cmap[&ch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/sample.rs:388:35 [INFO] [stderr] | [INFO] [stderr] 388 | let _ = print_svg(&mut s, font.cmap.get(&ch).unwrap(), font, 5, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&font.cmap[&ch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/sample.rs:411:52 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn write_live_html(f: &mut Write, font: &Font, bar: &ProgressBar) -> io::Result<()> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | fn set_style(bar: ProgressBar) -> ProgressBar { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `unison`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "08473130499b12a407095e627cfbe2aab72a8b9f7574aa2f23fb21e1e11a33b7"` [INFO] running `"docker" "rm" "-f" "08473130499b12a407095e627cfbe2aab72a8b9f7574aa2f23fb21e1e11a33b7"` [INFO] [stdout] 08473130499b12a407095e627cfbe2aab72a8b9f7574aa2f23fb21e1e11a33b7