[INFO] updating cached repository liamwhite/cookie_check [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/liamwhite/cookie_check [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/liamwhite/cookie_check" "work/ex/clippy-test-run/sources/stable/gh/liamwhite/cookie_check"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/liamwhite/cookie_check'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/liamwhite/cookie_check" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamwhite/cookie_check"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamwhite/cookie_check'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afca3dcb41b04be1feab8b050b1667f87eb5c3b4 [INFO] sha for GitHub repo liamwhite/cookie_check: afca3dcb41b04be1feab8b050b1667f87eb5c3b4 [INFO] validating manifest of liamwhite/cookie_check on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liamwhite/cookie_check on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liamwhite/cookie_check [INFO] finished frobbing liamwhite/cookie_check [INFO] frobbed toml for liamwhite/cookie_check written to work/ex/clippy-test-run/sources/stable/gh/liamwhite/cookie_check/Cargo.toml [INFO] started frobbing liamwhite/cookie_check [INFO] finished frobbing liamwhite/cookie_check [INFO] frobbed toml for liamwhite/cookie_check written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamwhite/cookie_check/Cargo.toml [INFO] crate liamwhite/cookie_check has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liamwhite/cookie_check against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/liamwhite/cookie_check:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42961c6bdf16679c79904f104f83c9c812b8e88bb12d072f4b3071b5d66a6676 [INFO] running `"docker" "start" "-a" "42961c6bdf16679c79904f104f83c9c812b8e88bb12d072f4b3071b5d66a6676"` [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking libc v0.2.44 [INFO] [stderr] Checking serde v1.0.80 [INFO] [stderr] Checking ryu v0.2.7 [INFO] [stderr] Checking cookie_check v0.1.1 (/opt/crater/workdir) [INFO] [stderr] Checking base64 v0.10.0 [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | fn validate_hmac<'a>(key: &KeyData<'a>, parts: &Vec<&str>) -> Result> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | fn decrypt_session(key: &[u8], data: &Vec, iv: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | fn decrypt_session(key: &[u8], data: &Vec, iv: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Checking openssl-sys v0.9.39 [INFO] [stderr] Checking openssl v0.10.15 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | fn validate_hmac<'a>(key: &KeyData<'a>, parts: &Vec<&str>) -> Result> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | fn decrypt_session(key: &[u8], data: &Vec, iv: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | fn decrypt_session(key: &[u8], data: &Vec, iv: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.77s [INFO] running `"docker" "inspect" "42961c6bdf16679c79904f104f83c9c812b8e88bb12d072f4b3071b5d66a6676"` [INFO] running `"docker" "rm" "-f" "42961c6bdf16679c79904f104f83c9c812b8e88bb12d072f4b3071b5d66a6676"` [INFO] [stdout] 42961c6bdf16679c79904f104f83c9c812b8e88bb12d072f4b3071b5d66a6676