[INFO] updating cached repository liamross/rust_guessing_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/liamross/rust_guessing_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/liamross/rust_guessing_game" "work/ex/clippy-test-run/sources/stable/gh/liamross/rust_guessing_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/liamross/rust_guessing_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/liamross/rust_guessing_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamross/rust_guessing_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamross/rust_guessing_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f97fd5ea8300b684ef10eb3982353c2f051a464 [INFO] sha for GitHub repo liamross/rust_guessing_game: 2f97fd5ea8300b684ef10eb3982353c2f051a464 [INFO] validating manifest of liamross/rust_guessing_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liamross/rust_guessing_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liamross/rust_guessing_game [INFO] finished frobbing liamross/rust_guessing_game [INFO] frobbed toml for liamross/rust_guessing_game written to work/ex/clippy-test-run/sources/stable/gh/liamross/rust_guessing_game/Cargo.toml [INFO] started frobbing liamross/rust_guessing_game [INFO] finished frobbing liamross/rust_guessing_game [INFO] frobbed toml for liamross/rust_guessing_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamross/rust_guessing_game/Cargo.toml [INFO] crate liamross/rust_guessing_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liamross/rust_guessing_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/liamross/rust_guessing_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df279e5fbf02bcb0d12aca1a571453558a91ae801b8c37dbdef098f7fe51d371 [INFO] running `"docker" "start" "-a" "df279e5fbf02bcb0d12aca1a571453558a91ae801b8c37dbdef098f7fe51d371"` [INFO] [stderr] Checking guessing_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / return match input.trim().parse() { [INFO] [stderr] 158 | | Ok(num) => Ok(num), [INFO] [stderr] 159 | | Err(_) => { [INFO] [stderr] 160 | | if input.trim() == "quit" { [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 157 | match input.trim().parse() { [INFO] [stderr] 158 | Ok(num) => Ok(num), [INFO] [stderr] 159 | Err(_) => { [INFO] [stderr] 160 | if input.trim() == "quit" { [INFO] [stderr] 161 | return Err(true); [INFO] [stderr] 162 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / return match input.trim().parse() { [INFO] [stderr] 158 | | Ok(num) => Ok(num), [INFO] [stderr] 159 | | Err(_) => { [INFO] [stderr] 160 | | if input.trim() == "quit" { [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 157 | match input.trim().parse() { [INFO] [stderr] 158 | Ok(num) => Ok(num), [INFO] [stderr] 159 | Err(_) => { [INFO] [stderr] 160 | if input.trim() == "quit" { [INFO] [stderr] 161 | return Err(true); [INFO] [stderr] 162 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "df279e5fbf02bcb0d12aca1a571453558a91ae801b8c37dbdef098f7fe51d371"` [INFO] running `"docker" "rm" "-f" "df279e5fbf02bcb0d12aca1a571453558a91ae801b8c37dbdef098f7fe51d371"` [INFO] [stdout] df279e5fbf02bcb0d12aca1a571453558a91ae801b8c37dbdef098f7fe51d371