[INFO] updating cached repository liamnaddell/rusttorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/liamnaddell/rusttorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/liamnaddell/rusttorial" "work/ex/clippy-test-run/sources/stable/gh/liamnaddell/rusttorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/liamnaddell/rusttorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/liamnaddell/rusttorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamnaddell/rusttorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamnaddell/rusttorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9eb943a1ffa4c7b05c2702aa64ce37eedab95b91 [INFO] sha for GitHub repo liamnaddell/rusttorial: 9eb943a1ffa4c7b05c2702aa64ce37eedab95b91 [INFO] validating manifest of liamnaddell/rusttorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liamnaddell/rusttorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liamnaddell/rusttorial [INFO] finished frobbing liamnaddell/rusttorial [INFO] frobbed toml for liamnaddell/rusttorial written to work/ex/clippy-test-run/sources/stable/gh/liamnaddell/rusttorial/Cargo.toml [INFO] started frobbing liamnaddell/rusttorial [INFO] finished frobbing liamnaddell/rusttorial [INFO] frobbed toml for liamnaddell/rusttorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamnaddell/rusttorial/Cargo.toml [INFO] crate liamnaddell/rusttorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liamnaddell/rusttorial against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/liamnaddell/rusttorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 523b3d960ce3b27bbd83ed858f938be0f8d5fd2b8d3d570e5a4ec3ebfe06d50c [INFO] running `"docker" "start" "-a" "523b3d960ce3b27bbd83ed858f938be0f8d5fd2b8d3d570e5a4ec3ebfe06d50c"` [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking rusttorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | (stop+1 .. num + 1).into_par_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(stop+1..=num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | (0 .. num+1).into_par_iter() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | (stop+1 .. num + 1).into_par_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(stop+1..=num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | (0 .. num+1).into_par_iter() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | fn t(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | fn t(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.76s [INFO] running `"docker" "inspect" "523b3d960ce3b27bbd83ed858f938be0f8d5fd2b8d3d570e5a4ec3ebfe06d50c"` [INFO] running `"docker" "rm" "-f" "523b3d960ce3b27bbd83ed858f938be0f8d5fd2b8d3d570e5a4ec3ebfe06d50c"` [INFO] [stdout] 523b3d960ce3b27bbd83ed858f938be0f8d5fd2b8d3d570e5a4ec3ebfe06d50c