[INFO] updating cached repository liamdawson/txdo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/liamdawson/txdo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/liamdawson/txdo" "work/ex/clippy-test-run/sources/stable/gh/liamdawson/txdo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/liamdawson/txdo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/liamdawson/txdo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamdawson/txdo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamdawson/txdo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbfcb30f091e00e81fcb90ea935505a3ebbb6a66 [INFO] sha for GitHub repo liamdawson/txdo: fbfcb30f091e00e81fcb90ea935505a3ebbb6a66 [INFO] validating manifest of liamdawson/txdo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liamdawson/txdo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liamdawson/txdo [INFO] finished frobbing liamdawson/txdo [INFO] frobbed toml for liamdawson/txdo written to work/ex/clippy-test-run/sources/stable/gh/liamdawson/txdo/Cargo.toml [INFO] started frobbing liamdawson/txdo [INFO] finished frobbing liamdawson/txdo [INFO] frobbed toml for liamdawson/txdo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamdawson/txdo/Cargo.toml [INFO] crate liamdawson/txdo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liamdawson/txdo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/liamdawson/txdo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5489985495de253b2bb02dd14a446151fa210c04e4d1a1825a007da75c7f4428 [INFO] running `"docker" "start" "-a" "5489985495de253b2bb02dd14a446151fa210c04e4d1a1825a007da75c7f4428"` [INFO] [stderr] Checking txdo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:41 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'x' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:69 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | && buffer[0] == ('(' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'(' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | && buffer[2] == (')' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b')' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | && buffer[3] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | char == ('-' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | && buffer[DATE_LENGTH] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | let (date2, buffer) = match completed { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 21 | | true => matchers::parse_date(buffer), [INFO] [stderr] 22 | | false => (None, buffer), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { matchers::parse_date(buffer) } else { (None, buffer) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let completed_at = match completed { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | true => date1, [INFO] [stderr] 27 | | false => None, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date1 } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | let created_at = match completed { [INFO] [stderr] | __________________________^ [INFO] [stderr] 31 | | true => date2, [INFO] [stderr] 32 | | false => date1, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date2 } else { date1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:41 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'x' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:69 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | && buffer[0] == ('(' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'(' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | && buffer[2] == (')' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b')' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | && buffer[3] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | char == ('-' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | && buffer[DATE_LENGTH] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"x "` [INFO] [stderr] ... [INFO] [stderr] 66 | assert_eq!(parse_completed(input!("x ")).0, true); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"x"` [INFO] [stderr] ... [INFO] [stderr] 69 | assert_eq!(parse_completed(input!("x")).0, false); [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xylophone"` [INFO] [stderr] ... [INFO] [stderr] 70 | assert_eq!(parse_completed(input!("xylophone")).0, false); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" x"` [INFO] [stderr] ... [INFO] [stderr] 72 | assert_eq!(parse_completed(input!(" x")).0, false); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"X "` [INFO] [stderr] ... [INFO] [stderr] 74 | assert_eq!(parse_completed(input!("X ")).0, false); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(A) "` [INFO] [stderr] ... [INFO] [stderr] 79 | assert_eq!(parse_priority(input!("(A) ")).0, Some('A' as u8)); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:79:59 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(parse_priority(input!("(A) ")).0, Some('A' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(X) "` [INFO] [stderr] ... [INFO] [stderr] 80 | assert_eq!(parse_priority(input!("(X) ")).0, Some('X' as u8)); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:80:59 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(parse_priority(input!("(X) ")).0, Some('X' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(c) "` [INFO] [stderr] ... [INFO] [stderr] 83 | assert_eq!(parse_priority(input!("(c) ")).0, None); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" (c)"` [INFO] [stderr] ... [INFO] [stderr] 85 | assert_eq!(parse_priority(input!(" (c)")).0, None); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" (O).(o)"` [INFO] [stderr] ... [INFO] [stderr] 86 | assert_eq!(parse_priority(input!(" (O).(o)")).0, None); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01 "` [INFO] [stderr] ... [INFO] [stderr] 95 | parse_date(input!("2018-01-01 ")).0.map(coerce_to_string), [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01"` [INFO] [stderr] ... [INFO] [stderr] 104 | parse_date(input!("2018-01-01")).0.map(coerce_to_string), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"18-01-01 "` [INFO] [stderr] ... [INFO] [stderr] 110 | parse_date(input!("18-01-01 ")).0.map(coerce_to_string), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-1-01 "` [INFO] [stderr] ... [INFO] [stderr] 114 | parse_date(input!("2018-1-01 ")).0.map(coerce_to_string), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-1 "` [INFO] [stderr] ... [INFO] [stderr] 118 | parse_date(input!("2018-01-1 ")).0.map(coerce_to_string), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018_01_01 "` [INFO] [stderr] ... [INFO] [stderr] 124 | parse_date(input!("2018_01_01 ")).0.map(coerce_to_string), [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | let (date2, buffer) = match completed { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 21 | | true => matchers::parse_date(buffer), [INFO] [stderr] 22 | | false => (None, buffer), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { matchers::parse_date(buffer) } else { (None, buffer) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let completed_at = match completed { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | true => date1, [INFO] [stderr] 27 | | false => None, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date1 } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | let created_at = match completed { [INFO] [stderr] | __________________________^ [INFO] [stderr] 31 | | true => date2, [INFO] [stderr] 32 | | false => date1, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date2 } else { date1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:64:36 [INFO] [stderr] | [INFO] [stderr] 64 | let expected_date: &[u8] = "2018-01-01".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:74:46 [INFO] [stderr] | [INFO] [stderr] 74 | let expected_completed_date: &[u8] = "2018-01-01".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | let expected_created_date: &[u8] = "2018-12-31".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-12-31"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> benches/parse.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | fn parse_file() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> benches/parse.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/parse.rs:28:47 [INFO] [stderr] | [INFO] [stderr] 28 | c.bench_function("parse_file", |b| b.iter(|| parse_file())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `parse_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.74s [INFO] running `"docker" "inspect" "5489985495de253b2bb02dd14a446151fa210c04e4d1a1825a007da75c7f4428"` [INFO] running `"docker" "rm" "-f" "5489985495de253b2bb02dd14a446151fa210c04e4d1a1825a007da75c7f4428"` [INFO] [stdout] 5489985495de253b2bb02dd14a446151fa210c04e4d1a1825a007da75c7f4428