[INFO] updating cached repository liamdawson/pogpen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/liamdawson/pogpen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/liamdawson/pogpen" "work/ex/clippy-test-run/sources/stable/gh/liamdawson/pogpen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/liamdawson/pogpen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/liamdawson/pogpen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamdawson/pogpen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamdawson/pogpen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff474b395bd01772cf43ba400cc7cf874cce007c [INFO] sha for GitHub repo liamdawson/pogpen: ff474b395bd01772cf43ba400cc7cf874cce007c [INFO] validating manifest of liamdawson/pogpen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liamdawson/pogpen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liamdawson/pogpen [INFO] finished frobbing liamdawson/pogpen [INFO] frobbed toml for liamdawson/pogpen written to work/ex/clippy-test-run/sources/stable/gh/liamdawson/pogpen/Cargo.toml [INFO] started frobbing liamdawson/pogpen [INFO] finished frobbing liamdawson/pogpen [INFO] frobbed toml for liamdawson/pogpen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/liamdawson/pogpen/Cargo.toml [INFO] crate liamdawson/pogpen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liamdawson/pogpen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/liamdawson/pogpen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a204af79bb8ebcece1cb858eae514588eabf1403b6eb4e3be14458fb8145cca [INFO] running `"docker" "start" "-a" "1a204af79bb8ebcece1cb858eae514588eabf1403b6eb4e3be14458fb8145cca"` [INFO] [stderr] Compiling pulldown-cmark v0.0.14 [INFO] [stderr] Checking serde_test v1.0.11 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Checking linked-hash-map v0.5.0 [INFO] [stderr] Checking handlebars v0.26.2 [INFO] [stderr] Checking pogpen v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return include_str!("../config/default.html.hbs"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `include_str!("../config/default.html.hbs")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return Error::new(ErrorKind::InvalidData, reason); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::new(ErrorKind::InvalidData, reason)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return include_str!("../config/default.html.hbs"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `include_str!("../config/default.html.hbs")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return Error::new(ErrorKind::InvalidData, reason); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::new(ErrorKind::InvalidData, reason)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return include_str!("../config/default.html.hbs"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `include_str!("../config/default.html.hbs")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return Error::new(ErrorKind::InvalidData, reason); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::new(ErrorKind::InvalidData, reason)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok(context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(context)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(contents_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(contents_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / return std::io::Error::new(std::io::ErrorKind::InvalidData, [INFO] [stderr] 77 | | reason); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | std::io::Error::new(std::io::ErrorKind::InvalidData, [INFO] [stderr] 77 | reason) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return include_str!("../config/default.html.hbs"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `include_str!("../config/default.html.hbs")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return Error::new(ErrorKind::InvalidData, reason); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::new(ErrorKind::InvalidData, reason)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok(context); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(context)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(contents_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(contents_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / return std::io::Error::new(std::io::ErrorKind::InvalidData, [INFO] [stderr] 77 | | reason); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | std::io::Error::new(std::io::ErrorKind::InvalidData, [INFO] [stderr] 77 | reason) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `serde_yaml::from_str` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:61:71 [INFO] [stderr] | [INFO] [stderr] 61 | let context : render::context::ContextFile = serde_yaml::from_str(&mut context_str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `serde_yaml::from_str` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:61:71 [INFO] [stderr] | [INFO] [stderr] 61 | let context : render::context::ContextFile = serde_yaml::from_str(&mut context_str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.74s [INFO] running `"docker" "inspect" "1a204af79bb8ebcece1cb858eae514588eabf1403b6eb4e3be14458fb8145cca"` [INFO] running `"docker" "rm" "-f" "1a204af79bb8ebcece1cb858eae514588eabf1403b6eb4e3be14458fb8145cca"` [INFO] [stdout] 1a204af79bb8ebcece1cb858eae514588eabf1403b6eb4e3be14458fb8145cca